Received-SPF: pass (google.com: domain of linux-kernel+bounces-123132-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <10d89693-21af-4560-a088-d58d16cbb9dd@intel.com>
Date: Thu, 28 Mar 2024 16:02:12 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: create a dummy net_device allocator
To: Breno Leitao <leitao@debian.org>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <quic_jjohnson@quicinc.com>, <kvalo@kernel.org>, <leon@kernel.org>,
	<dennis.dalessandro@cornelisnetworks.com>, Jiri Pirko <jiri@resnulli.us>,
	Simon Horman <horms@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
	Lorenzo Bianconi <lorenzo@kernel.org>, Coco Li <lixiaoyan@google.com>, "open
 list:NETWORKING DRIVERS" <netdev@vger.kernel.org>, open list
	<linux-kernel@vger.kernel.org>
References: <20240327200809.512867-1-leitao@debian.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240327200809.512867-1-leitao@debian.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjRCQWFDbWN3QXUxcm1HYnlJWXBMcWY5QXVtbVJhT0tveXZwcmpBVVYybVY4?=
 =?utf-8?B?bzh3b08vUW5kRndjNHlGTmtQQkxQNnQvKzVEN3hGRjVBNVFFUlZOdW9FazZz?=
 =?utf-8?B?TmFJK3p6MXhyQTB1MEpsaHlEcEVmaTIxakxQd3BtVmZuOGhsOWZwejV0dE92?=
 =?utf-8?B?OGhLb0JycjlNSFptaVVGOXNDVSthWGp1VWJlK2NJckhhWlcrVTVZajg0WXlm?=
 =?utf-8?B?K3ZpalhLM3FTU0c4RTlydjBqZkp0Q1p6aG84emRuS1EvSlR4RTRhdElDMHVP?=
 =?utf-8?B?dlA1RWE3eDRTYmJva2l0VUVZMTZWZFJwRzgvNlIySEdqa2pveXpZcmg1NEJI?=
 =?utf-8?B?dEtQbk0wVWRYMktZK3R1Y3BWOHpzWlVWWjR1OVFmNUdsOXRWdWx3NHArUG5D?=
 =?utf-8?B?S0NabG81SVNRUzlHeDkwSUZCdFFRaGI4K1I5eU1JOWlyeEtCYmpLZzU2STJZ?=
 =?utf-8?B?OHg3OFFsalJLeVF0KzBTMWFWbWlqUGFNR0Q1LzRlNVk1VmpjeXdGR2hZWU1Z?=
 =?utf-8?B?MmtBVzErU1VWRDdFNE5waG1xYXFEMm1ORnMyVzBUSytNOS9ZdW1yNmhscThm?=
 =?utf-8?B?aThTdGlHdTgrVjFKK3FYckszOXowYytnc1pqVmI0UkNTZCtpeDUrSzhUbUo4?=
 =?utf-8?B?MDFlTHNrTmEzMmwxQno4ekMvRFh1VTlWYk5wV3N2bllLWnkxeFFZenY3QjFm?=
 =?utf-8?B?b1JyU0F4dTB1Ry9hQ1pNQXBsWjgzMXk0UjZXdnBUWjJ6UHBpSGhkTlV2cjhh?=
 =?utf-8?B?aXBkY0JJakNnQ2FjVk1vbEZzMmRHbVFhZzQ1U1Y3U0E2dEsrREZ6REtmN2sr?=
 =?utf-8?B?bWRaNS9XTmlEMjE5eml6RTgvTWJhNEtOY0ZuYm91RlRNMU9FRXg2RG83cm5U?=
 =?utf-8?B?VWZqdkZjUFF6c0RJN3cwc292Ujl2dXlva1lTaTVuSTY2dGtiQTZ4ODhDa1pl?=
 =?utf-8?B?RzRPSEVsaDlIUlpNU2djNUlPbDRDd2MyQ1lHcUVWQzh4dmVUbExtN2xMWDFp?=
 =?utf-8?B?VytHaUdJUmtxV255dy91dk9LQ1dNZ3BhbS92T2xSRXdYeVM0VTVNRDgwMnJh?=
 =?utf-8?B?bFRVOFo1dVhPdHNTWXFyWHg5OUVMb3pnWGY0QytmLzhQRCsrMnR2OXBpYXVs?=
 =?utf-8?B?NnNaakRiQzE4WExSRWg2YTN3K0pDV1RFQk1vdmxTSm12MWxnMHhDUjZRMDlT?=
 =?utf-8?B?UFVzOVpuekpxYXFqbU03Ty94R05CLzc4aEVqNVV6Q2d0RlVIaXBBdlFCN3ly?=
 =?utf-8?B?RzYwVEg1RWlkRWxoSW45K09VbHVIZDZnVVNad1hKdGxCMURJdEtRWGJRS1FQ?=
 =?utf-8?B?YUN1VzdZc2pJallnSkFDR00yN2QxdlBxZHlLRnZiTHVEWkFTSThPbUhLZEZB?=
 =?utf-8?B?TXRpaUd4QjRJaXAxaE5FNldzdTNMRUkvcDEybHhTY2QvaFpZK05UVm84YUdt?=
 =?utf-8?B?Q0EvZ1BCTC81QjUwSlBpcGtlT2NteFNvWkFHanpDUVVuc1dybHNCSHlhUkhj?=
 =?utf-8?B?VGNEcFlYekN5aE1pWEFoTTh5RXFhZW9oQXdxOFYrYk9wTWZYaFB3a3lOZ1Vv?=
 =?utf-8?B?ZllYeUtmTWVUMW5tZzN3aXNHOGJKc3kzV084ZU1zTzVtZ2pNSThMVElpZnJZ?=
 =?utf-8?B?TVFiOXdzZ3g4UzdNbHpmV3plQWNwWWVFRWFqUlVubms2eFNDaVB6VUtFdkJO?=
 =?utf-8?B?RUdFenYwS1BWRWNscjNvZkxSN2QwZFdkTCtXZG01azdMUjhEanNrUWZhc0Fu?=
 =?utf-8?B?UlFWUHh3UzdlSmVxV09nakdHZ3JVZXJPN3pEY1ZuOFpJY3Bob0dreXhyYlFq?=
 =?utf-8?B?eW9NTzhJNlpGdXJVUDBNSHdBRWJySnVxV3NINFlXaXM5dUkrL2ZQZGJmSTBZ?=
 =?utf-8?B?WFF4eVl2NHE1SVdINTNUQ2tQd2F0elprR3FMcVRvY0dRbnBWWHFTb2IrcTNU?=
 =?utf-8?B?dUx3VTY5dGR0NWtzWWtxQkVLS3RjUkdwUHV2NENzckRocDNGNE8waDZHbDBL?=
 =?utf-8?B?M09nNGxmU0hlWFA3bTZKLzNyL2diVmFnRlVnNHhoVWJYQWJueUlDVEdsdFQv?=
 =?utf-8?B?ZENvcUZ4dUlEamR1Q3RaeC92U1UrM1NvUnRMV0xhWVFtVzM0THNTRG9BaEs1?=
 =?utf-8?B?TXhSTEFKbVM0QTU2Y3ZYOENEQ3hZaXE4WElKRDV0QkhaRUdLQnV4dXQ5dVVL?=
 =?utf-8?B?ZVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b087dfa4-2757-4e9d-ba45-08dc4f381a20
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 15:02:35.7499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A/tBPSRDSzsXilXNV+LUh38Jo1Jpv95iPE/zmd7SWKU3bu/G1Wv5hb3bELYYYOvuRdJZAoWzuKykcpLdShtq/aEcZK75LRic05rrldSEEsI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4527
X-OriginatorOrg: intel.com

From: Breno Leitao <leitao@debian.org>
Date: Wed, 27 Mar 2024 13:08:04 -0700

> It is impossible to use init_dummy_netdev together with alloc_netdev()
> as the 'setup' argument.
> 
> This is because alloc_netdev() initializes some fields in the net_device
> structure, and later init_dummy_netdev() memzero them all. This causes
> some problems as reported here:
> 
> 	https://lore.kernel.org/all/20240322082336.49f110cc@kernel.org/
> 
> Split the init_dummy_netdev() function in two. Create a new function called
> init_dummy_netdev_core() that does not memzero the net_device structure.
> Then have init_dummy_netdev() memzero-ing and calling
> init_dummy_netdev_core(), keeping the old behaviour.
> 
> init_dummy_netdev_core() is the new function that could be called as an
> argument for alloc_netdev().
> 
> Also, create a helper to allocate and initialize dummy net devices,
> leveraging init_dummy_netdev_core() as the setup argument. This function
> basically simplify the allocation of dummy devices, by allocating and
> initializing it. Freeing the device continue to be done through
> free_netdev()
> 
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  include/linux/netdevice.h |  3 +++
>  net/core/dev.c            | 55 ++++++++++++++++++++++++++-------------
>  2 files changed, 40 insertions(+), 18 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index c6f6ac779b34..f4226a99a146 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -4545,6 +4545,9 @@ static inline void netif_addr_unlock_bh(struct net_device *dev)
>  
>  void ether_setup(struct net_device *dev);
>  
> +/* Allocate dummy net_device */
> +struct net_device *alloc_netdev_dummy(int sizeof_priv, const char *name);
> +
>  /* Support for loadable net-drivers */
>  struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
>  				    unsigned char name_assign_type,
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 0766a245816b..df2484bbc041 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -10340,25 +10340,12 @@ int register_netdevice(struct net_device *dev)
>  }
>  EXPORT_SYMBOL(register_netdevice);
>  
> -/**
> - *	init_dummy_netdev	- init a dummy network device for NAPI
> - *	@dev: device to init
> - *
> - *	This takes a network device structure and initialize the minimum
> - *	amount of fields so it can be used to schedule NAPI polls without
> - *	registering a full blown interface. This is to be used by drivers
> - *	that need to tie several hardware interfaces to a single NAPI
> - *	poll scheduler due to HW limitations.
> +/* Initialize the core of a dummy net device.
> + * This is useful if you are calling this function after alloc_netdev(),
> + * since it does not memset the net_device fields.
>   */
> -void init_dummy_netdev(struct net_device *dev)
> +static void init_dummy_netdev_core(struct net_device *dev)
>  {
> -	/* Clear everything. Note we don't initialize spinlocks
> -	 * are they aren't supposed to be taken by any of the
> -	 * NAPI code and this dummy netdev is supposed to be
> -	 * only ever used for NAPI polls
> -	 */
> -	memset(dev, 0, sizeof(struct net_device));
> -
>  	/* make sure we BUG if trying to hit standard
>  	 * register/unregister code path
>  	 */
> @@ -10379,8 +10366,28 @@ void init_dummy_netdev(struct net_device *dev)
>  	 * its refcount.
>  	 */
>  }
> -EXPORT_SYMBOL_GPL(init_dummy_netdev);
>  
> +/**
> + *	init_dummy_netdev	- init a dummy network device for NAPI
> + *	@dev: device to init
> + *
> + *	This takes a network device structure and initialize the minimum
> + *	amount of fields so it can be used to schedule NAPI polls without
> + *	registering a full blown interface. This is to be used by drivers
> + *	that need to tie several hardware interfaces to a single NAPI
> + *	poll scheduler due to HW limitations.
> + */
> +void init_dummy_netdev(struct net_device *dev)
> +{
> +	/* Clear everything. Note we don't initialize spinlocks
> +	 * are they aren't supposed to be taken by any of the
> +	 * NAPI code and this dummy netdev is supposed to be
> +	 * only ever used for NAPI polls
> +	 */
> +	memset(dev, 0, sizeof(struct net_device));
> +	init_dummy_netdev_core(dev);
> +}
> +EXPORT_SYMBOL_GPL(init_dummy_netdev);
>  
>  /**
>   *	register_netdev	- register a network device
> @@ -10991,6 +10998,18 @@ void free_netdev(struct net_device *dev)
>  }
>  EXPORT_SYMBOL(free_netdev);
>  
> +/**
> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
> + * @sizeof_priv: size of private data to allocate space for
> + * @name: device name format string
> + */
> +struct net_device *alloc_netdev_dummy(int sizeof_priv, const char *name)

Since the users of init_dummy_netdev embed &net_device into their
private structures, do we need sizeof_priv here at all? Or maybe we
could unconditionally pass 0?

> +{
> +	return alloc_netdev(sizeof_priv, name, NET_NAME_UNKNOWN,
> +			    init_dummy_netdev_core);
> +}
> +EXPORT_SYMBOL_GPL(alloc_netdev_dummy);
> +
>  /**
>   *	synchronize_net -  Synchronize with packet receive processing
>   *

As Jakub mentioned, you need to introduce consumers of the functionality
you add within the same series. Personally, I'd like to see a series
with agressive conversion of all the affected drivers from
init_dummy_netdev() to alloc_dummy_netdev() and final removal of
init_dummy_netdev() :D

(and then a followup which converts &net_device to proper flex arrays)

Thanks,
Olek