Received-SPF: pass (google.com: domain of linux-kernel+bounces-123204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <09fe8f18-7f68-4d5d-89e4-68c1e5487b05@quicinc.com>
Date: Thu, 28 Mar 2024 09:01:33 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for
 function-like macro
Content-Language: en-US
To: Barry Song <21cnbao@gmail.com>, <akpm@linux-foundation.org>,
        <linux-doc@vger.kernel.org>
CC: <apw@canonical.com>, <broonie@kernel.org>, <chenhuacai@loongson.cn>,
        <chris@zankel.net>, <corbet@lwn.net>, <dwaipayanray1@gmail.com>,
        <herbert@gondor.apana.org.au>, <joe@perches.com>,
        <linux-kernel@vger.kernel.org>, <linux@roeck-us.net>,
        <lukas.bulwahn@gmail.com>, <mac.xxn@outlook.com>,
        <sfr@canb.auug.org.au>, <v-songbaohua@oppo.com>,
        <workflows@vger.kernel.org>, Max Filippov
	<jcmvbkbc@gmail.com>
References: <20240328022136.5789-1-21cnbao@gmail.com>
 <20240328022136.5789-3-21cnbao@gmail.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240328022136.5789-3-21cnbao@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/27/2024 7:21 PM, Barry Song wrote:
> From: Xining Xu <mac.xxn@outlook.com>
> 
> If function-like macros do not utilize a parameter, it might result in a
> build warning.  In our coding style guidelines, we advocate for utilizing
> static inline functions to replace such macros.  This patch verifies
> compliance with the new rule.
> 
> For a macro such as the one below,
> 
>  #define test(a) do { } while (0)
> 
> The test result is as follows.
> 
>  ERROR: Parameter 'a' is not used in function-like macro, please use static
>  inline instead
>  #21: FILE: mm/init-mm.c:20:
>  +#define test(a) do { } while (0)
> 
>  total: 1 errors, 0 warnings, 8 lines checked
> 
> Signed-off-by: Xining Xu <mac.xxn@outlook.com>

if you are re-posting somebody else's work you need to add your own Signed-off-by

> Tested-by: Barry Song <v-songbaohua@oppo.com>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Huacai Chen <chenhuacai@loongson.cn>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Cc: Max Filippov <jcmvbkbc@gmail.com>