Received-SPF: pass (google.com: domain of linux-kernel+bounces-123253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3fac7a3d-cd8a-4367-8ad7-206b850d2e41@t-argos.ru>
Date: Thu, 28 Mar 2024 19:23:56 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] gpio: davinci: Fix potential buffer overflow
Content-Language: ru
To: Alexander Lobakin <aleksander.lobakin@intel.com>
References: <20240328091021.18027-1-amishin@t-argos.ru>
 <b2c6bc3e-11c5-4a20-8a30-666821ab2613@intel.com>
CC: Keerthy <j-keerthy@ti.com>, Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>, "Andrew F. Davis" <afd@ti.com>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<"<lvc-project"@linuxtesting.org>
From: Aleksandr Mishin <amishin@t-argos.ru>
In-Reply-To: <b2c6bc3e-11c5-4a20-8a30-666821ab2613@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


28.03.2024 18:27, Alexander Lobakin пишет:
> From: Aleksandr Mishin <amishin@t-argos.ru>
> Date: Thu, 28 Mar 2024 12:10:21 +0300
> 
>> In davinci_gpio_probe() accessing an element of array 'chips->regs' of size 5 and
>> array 'offset_array' of size 5 can lead to a buffer overflow, since the index
>> 'bank' can have an out of range value 63.
>> Fix this bug by limiting top index value.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: c809e37a3b5a ("gpio: davinci: Allocate the correct amount of memory for controller")
>> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
>> ---
>>   drivers/gpio/gpio-davinci.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index bb499e362912..b65df1f2b83f 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -257,6 +257,9 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>>   	spin_lock_init(&chips->lock);
>>   
>>   	nbank = DIV_ROUND_UP(ngpio, 32);
>> +    if (nbank > MAX_REGS_BANKS || nbank > 5) {
>> +        nbank = MAX_REGS_BANKS < 5 ? MAX_REGS_BANKS : 5;
>> +	}
> 
> Static analysis warnings make no sense until you provide a reliable way
> to trigger the problem on real systems.
> 
>>   	for (bank = 0; bank < nbank; bank++)
>>   		chips->regs[bank] = gpio_base + offset_array[bank];
>>   
> 
> Thanks,
> Olek
> 

I can only see the code at this time. And I see the following:
1. In some configurations CONFIG_ARCH_NR_GPIO value is 2048. So nbank 
value can be 64.
2. Previously, a patch was proposed that removes restrictions on the 
number of GPIOs 
(https://lore.kernel.org/all/cb540a9d73cad36d288664f8b275c6308a4a3168.1662116601.git.christophe.leroy@csgroup.eu/).

-- 
Kind regards
Aleksandr