Received-SPF: pass (google.com: domain of linux-kernel+bounces-123255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6d228b37-fec7-4a0c-b888-6311c5e17c24@intel.com>
Date: Thu, 28 Mar 2024 17:32:53 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] gpio: davinci: Fix potential buffer overflow
To: Aleksandr Mishin <amishin@t-argos.ru>
CC: Keerthy <j-keerthy@ti.com>, Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>, "Andrew F. Davis" <afd@ti.com>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<"<lvc-project"@linuxtesting.org>
References: <20240328091021.18027-1-amishin@t-argos.ru>
 <b2c6bc3e-11c5-4a20-8a30-666821ab2613@intel.com>
 <3fac7a3d-cd8a-4367-8ad7-206b850d2e41@t-argos.ru>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <3fac7a3d-cd8a-4367-8ad7-206b850d2e41@t-argos.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTVqbTQzOVJOc1hNYS94aUFoanpVd1ZwbEcwOXlDNE13bmlTQVNzVkY5cEd3?=
 =?utf-8?B?U21ja05QcHd3eGNHcHNEYWFkZlJWMU9sbitEeGdCS1ovQ2xnT0lPY250b0hC?=
 =?utf-8?B?RFNrTGRIcFJkM2VGRmFDU3NOdzNhYTFQOWNRNnl5cFA2UWtYNDV0R3Y0QkxX?=
 =?utf-8?B?OVgycjNydmNMREFPbGZUQkdqdVh5NmwzaDhhbG5ZakhkNlMrQjRZMG5MUGNV?=
 =?utf-8?B?RnNSR1YxOWQ2bjArRUFicVVaMXFaYVhsc2VFZEhWWS95ZHd6REVVSDQ1NlVz?=
 =?utf-8?B?NG5vRDQxN2tIT1BWbHMxaW56Zzh0d3pKaTNaWVFvdjBYbFdUWDFDUTl6c1pm?=
 =?utf-8?B?dGIvdThtVWc1ZWgzUWFraWQ3SHZRVlQrV2VJRFdnVnRmSDcraU1iUUNhTWZZ?=
 =?utf-8?B?dHI4R0FVWWRqUjdtUTVNODR2UVlaRStFZEtYUFJyNUVFdk51ejRCRWYwOWVk?=
 =?utf-8?B?b0ZLWTd6VXB4VXl2cE1tQXNISWZjRHR3K2hldlM5VmdGbG9DV0xwN0xkSnZ6?=
 =?utf-8?B?NDR4SExRd3lOUGNWb0lUdWpqbFJFKzJ2VGJabFVYY20xZ2lNQno2TjQ5bkpL?=
 =?utf-8?B?TnBDemZleWJqazZrVURzNUdhWWpnTFJuN3dlY3dEQ0J3NmY1WGI1QW5ta3lh?=
 =?utf-8?B?dDNRb0NZV3c4K3d1azF5SFNjcjZRR21LRUtDRzQ0OWRHelFpMXkzRXBhOUNa?=
 =?utf-8?B?b1Q4a0hydUJNbkFsbi9Kc3o0WjErWFh3S0J5Z3AyZER3Ni94OFVRRUhJYWx5?=
 =?utf-8?B?Z2ZoTUY0a0ZocGY5NXJhNm1hRFFVdzRibFViQWhpcWEzQ0E4TGsyTno2T0dL?=
 =?utf-8?B?VFZDNG9hT3V3OHpvL0JyVXhsRjEwTFZvTXB2MGJnUlc5eXFTYjR6dzNFeWJC?=
 =?utf-8?B?b1hJMHFGQ0o2RzVpd2F5UVFpOGd5ZVI1alAxNmdZMjFYUng4Q1orR3ZSL2ZI?=
 =?utf-8?B?bHI2RTR0S3lHU3ZSTU95RGp5MWYvVWVFa1hHTlV1SDhKd3dlTHhSOXh5OURs?=
 =?utf-8?B?L01zajEzWG00cTlwRjB2U2pSUzRTd1QxcTNBOUdPdENmVEVKVFdIYnNRaUJH?=
 =?utf-8?B?dS90ZC9ZbFJ2bVB3STJUd2ZLSngwSXg3MnF1OUg2SnZlbEhuZmVqV3NHYTJZ?=
 =?utf-8?B?T0tBY3pwTWI4bXFnb2Jjd1h6L3lZRytWdE95YjN6eDZFcy81KzBuNGJ2djFT?=
 =?utf-8?B?WGhJdlhNaGlhRlF0eUE0dFhPZ3NURnNRTXVOWVYvZmdSVXh6UG1wRnFZV2d4?=
 =?utf-8?B?d1lzamZkY0JDaWVFY250NTY3RnBjMnBWTldtcjdKR2dRR1RGSUJmcWFLKzJS?=
 =?utf-8?B?bnRNcXY1NG1ZVVRSZ2ZaTnhiZzA3ME5yRVRURFVDSCtld2tYZmpVSTlzNWt0?=
 =?utf-8?B?YUJURlhlQ2l5SFBrTGlDWnJpcVM0Q3M0aHNPdnZQcnEvT3hSMW9xcmxUVWJN?=
 =?utf-8?B?MlpqRGluTUozYnk0b1hWWnc0US8xUm1xOWN5N0xrMDZXZDlCVEZYRjBFS0gr?=
 =?utf-8?B?eEgrK2YyQ0NvMjNTT1R3RVkzWktOeE4rYnhwVEJRajNPR3RINWptTDZaMVJJ?=
 =?utf-8?B?OGdZQXViNXVHU3lycENEZS8ybDhFQVpxdHNsbXA1U1Q0MkhOTDdCVXFRNVZB?=
 =?utf-8?B?cGFhekhXSldaQm5XOFJyOE9nb2x4bGJRdERlSTdkdUNSUzNRUUhQRnRIQVdL?=
 =?utf-8?B?OXN3aUtCOVZ1V3JIVjlRSlFyaUFtZDkzUFBQVVA2UmJTQU9ISUVSRXhPYXdt?=
 =?utf-8?B?dGl0ZFdST0hJWVA4M25CU2swT09tYzBqQ2ttY1R2MGh3dDcySXVwcngva3gr?=
 =?utf-8?B?cnJVekl1VHk1azBkNzRQcXl0V0EvVE05c08zaWUwQ3o1Tk1yclNHc3EwK25O?=
 =?utf-8?B?SGMyaWxhdU4yaFFkbDNKZ2FBdGV6Wnk0RUt0QktIdDJyWkZ6ZlhmallrdC9B?=
 =?utf-8?B?K0k4Z0pTY0hOVmdoNWZ6ZU4zcHpIVDYzTDZJYjA3WWcveHNTR1dBZC9HVTdv?=
 =?utf-8?B?VEpsVG02bE5rY3lrZzR0M3g4a0NBbnBVcEw5UTBOeTFsU0J4VzY5RzRjNm1C?=
 =?utf-8?B?L0RzTjZla3pxcE5zNFZETVA2dExpNVRDd0UyaHdjTE5odXNQSUNyM1VaekJ3?=
 =?utf-8?B?VnBXSlN3THNMbWFrWHZ6QkZzWjFMc3RGTTZibWpHcEFDamprUnNmNHJzYmNw?=
 =?utf-8?B?RFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e372100-a075-4bae-a138-08dc4f44c458
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 16:33:15.2422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 70SLbZbqw4g3atIzWnWZ2ZvbgS2xdkamvXpIX+Xfi28di3fZ3wYmMRnUETl3vKuQSNZExPBTiR8u2R1EBCguXpEggogfyX72gDEUOZd5CLk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8349
X-OriginatorOrg: intel.com

From: Aleksandr Mishin <amishin@t-argos.ru>
Date: Thu, 28 Mar 2024 19:23:56 +0300

> 
> 
> 28.03.2024 18:27, Alexander Lobakin пишет:
>> From: Aleksandr Mishin <amishin@t-argos.ru>
>> Date: Thu, 28 Mar 2024 12:10:21 +0300
>>
>>> In davinci_gpio_probe() accessing an element of array 'chips->regs'
>>> of size 5 and
>>> array 'offset_array' of size 5 can lead to a buffer overflow, since
>>> the index
>>> 'bank' can have an out of range value 63.
>>> Fix this bug by limiting top index value.
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>>
>>> Fixes: c809e37a3b5a ("gpio: davinci: Allocate the correct amount of
>>> memory for controller")
>>> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
>>> ---
>>>   drivers/gpio/gpio-davinci.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>>> index bb499e362912..b65df1f2b83f 100644
>>> --- a/drivers/gpio/gpio-davinci.c
>>> +++ b/drivers/gpio/gpio-davinci.c
>>> @@ -257,6 +257,9 @@ static int davinci_gpio_probe(struct
>>> platform_device *pdev)
>>>       spin_lock_init(&chips->lock);
>>>         nbank = DIV_ROUND_UP(ngpio, 32);
>>> +    if (nbank > MAX_REGS_BANKS || nbank > 5) {
>>> +        nbank = MAX_REGS_BANKS < 5 ? MAX_REGS_BANKS : 5;
>>> +    }
>>
>> Static analysis warnings make no sense until you provide a reliable way
>> to trigger the problem on real systems.
>>
>>>       for (bank = 0; bank < nbank; bank++)
>>>           chips->regs[bank] = gpio_base + offset_array[bank];
>>>   
>>
>> Thanks,
>> Olek
>>
> 
> I can only see the code at this time. And I see the following:
> 1. In some configurations CONFIG_ARCH_NR_GPIO value is 2048. So nbank
> value can be 64.
> 2. Previously, a patch was proposed that removes restrictions on the
> number of GPIOs
> (https://lore.kernel.org/all/cb540a9d73cad36d288664f8b275c6308a4a3168.1662116601.git.christophe.leroy@csgroup.eu/).
> 

But no real hardware / device tree which declares such huge number of
GPIOs, right?

CONFIG_ARCH_NR_GPIO is architecture-specific. Davinci is a platform, not
an architecture. If no Davinci board can have a number that would
overflow, the fix doesn't make sense.

Thanks,
Olek