Received-SPF: pass (google.com: domain of linux-kernel+bounces-123344-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f0f985b272af85aea912479ced50ff52f29506b1.camel@gmail.com>
Subject: Re: [PATCH v4 0/6] iio: temperature: ltc2983: small improvements
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Nuno Sa via B4 Relay
	 <devnull+nuno.sa.analog.com@kernel.org>
Cc: nuno.sa@analog.com, linux-kernel@vger.kernel.org,
 linux-iio@vger.kernel.org,  devicetree@vger.kernel.org, Lars-Peter Clausen
 <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
 Olivier Moysan <olivier.moysan@foss.st.com>, Jyoti Bhayana
 <jbhayana@google.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date: Thu, 28 Mar 2024 18:07:21 +0100
In-Reply-To: <20240328165650.1d8d4216@jic23-huawei>
References: <20240328-ltc2983-misc-improv-v4-0-0cc428c07cd5@analog.com>
	 <20240328165650.1d8d4216@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-28 at 16:56 +0000, Jonathan Cameron wrote:
> On Thu, 28 Mar 2024 17:22:00 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:
>=20
> > The v4 introduces an new dev_errp_probe() helper to deal with cases
> > where we want to return error pointers. The refactor in the IIO ltc2983
> > is an heavy user of the pattern and was the main motivation for this.
> >=20
> > Also added two new patches so we have three users of the new
> > dev_errp_probe() helper.=20
>=20
> Probably better to do this as 2 series. The other ltc2983 changes in one =
series
> and one with a cover letter title that will get noticed by
> those who care about dev_printk helpers.
>=20

That makes sense, yes.

- Nuno S=C3=A1

> From a quick look the content of the patches is fine.
>=20
> Jonathan
>=20
> >=20
> > ---
> > Changes in v4:
> > - Link to v3:
> > https://lore.kernel.org/r/20240301-ltc2983-misc-improv-v3-0-c09516ac0ef=
c@analog.com
> > - Patch 1
> > =C2=A0* New patch
> > - Patch 2
> > =C2=A0* Use dev_errp_probe() instead of local variant
> > - Patch 5
> > =C2=A0* New patch
> > - Patch 6
> > =C2=A0* New patch
> >=20
> > ---
> > Nuno Sa (6):
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk: add new dev_errp_probe() helper
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iio: temperature: ltc2983: convert to de=
v_err_probe()
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dt-bindings: iio: temperature: ltc2983: =
document power supply
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iio: temperature: ltc2983: support vdd r=
egulator
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iio: backend: make use dev_errp_probe()
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iio: common: scmi_iio: convert to dev_er=
r_probe()
> >=20
> > =C2=A0.../bindings/iio/temperature/adi,ltc2983.yaml=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 |=C2=A0=C2=A0 4 +
> > =C2=A0drivers/iio/common/scmi_sensors/scmi_iio.c=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 45 ++--
> > =C2=A0drivers/iio/industrialio-backend.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=
=C2=A0 8 +-
> > =C2=A0drivers/iio/temperature/ltc2983.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | =
260 ++++++++++-----------
> > =C2=A0include/linux/dev_printk.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 +
> > =C2=A05 files changed, 151 insertions(+), 171 deletions(-)
> > ---
> > base-commit: 27eea4778db8268cd6dc80a5b853c599bd3099f1
> > change-id: 20240227-ltc2983-misc-improv-d9c4a3819b1f
> > --
> >=20
> > Thanks!
> > - Nuno S=C3=A1
> >=20
> >=20
>=20