Received-SPF: pass (google.com: domain of linux-kernel+bounces-123399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 28 Mar 2024 18:05:41 +0000
From: Conor Dooley <conor@kernel.org>
To: Allen Lin <allencl_lin@hotmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Rob Herring <robh@kernel.org>, dmitry.torokhov@gmail.com,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jikos@kernel.org, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
Message-ID: <20240328-aggregate-greasily-9d57e3ebf3ce@spud>
References: <20240322-mammary-boil-f9a4c347fba1@spud>
 <20240322183009.GA1227164-robh@kernel.org>
 <20240322-rectified-udder-fef9102f58da@spud>
 <TY0PR06MB56110ADEA805B68BE2B887069E352@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240326-whoever-spotter-1fe7ace35428@wendy>
 <TY0PR06MB561197578717990F4BEA93D29E352@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240326-granite-snipping-7c8b04480b2e@spud>
 <TY0PR06MB5611AE812B72B349E85118D59E342@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240327-pegboard-deodorize-17d8b0f1e31c@spud>
 <TY0PR06MB5611F7123B22C4FDEE319C049E3B2@TY0PR06MB5611.apcprd06.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Mfo/8yhR1A6ClAQa"
Content-Disposition: inline
In-Reply-To: <TY0PR06MB5611F7123B22C4FDEE319C049E3B2@TY0PR06MB5611.apcprd06.prod.outlook.com>


--Mfo/8yhR1A6ClAQa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 28, 2024 at 02:05:17PM +0800, Allen Lin wrote:

> OK, I will list all supplies required by the driver in the Yaml
> document as shown below,
>=20
> properties:
>   compatible:
>     const: himax,hx83102j
>=20
>   reg:
>     maxItems: 1
>=20
>   interrupts:
>     maxItems: 1
>=20
>   reset-gpios:
>     maxItems: 1
>=20
>   vccd-supply:
>     description: A phandle for the regualtor supplying IO power.
>=20
>   vsn-supply:
>     description: Negative supply regulator.
>=20
>   vsp-supply:
>     description: Positive supply regulator.
>=20
>   ddreset-gpios:

I think this should be s/dd// with the description explaining how this
display reset is related to this device.

Otherwise, this looks okay to me.

On another note - every time you reply to me I get it 3 times. Can you
fix that please?

Thanks,
Conor.

>     description: A phandle of gpio for display reset controlled by the
> LCD driver.
>=20
> required:
>   - compatible
>   - reg
>   - interrupts
>   - reset-gpios
>   - panel
>   - vccd-supply
>   - vsn-supply
>   - vsp-supply
>   - ddreset-gpios
>=20
>=20
> Thanks,
> Allen
>=20

--Mfo/8yhR1A6ClAQa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgWxdQAKCRB4tDGHoIJi
0vS2AQDVKCfNhoux/bC73lKwK5MggLxe6/BaQ+SFiWnlPp5UmwEA7qgpLq6NEiIz
Q/jEyL++OjVlGLmSuojJktze+2x77gk=
=LUxA
-----END PGP SIGNATURE-----

--Mfo/8yhR1A6ClAQa--