Received-SPF: pass (google.com: domain of linux-kernel+bounces-123408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 28 Mar 2024 18:18:32 +0000
From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, Jonathan Corbet <corbet@lwn.net>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Support Opensource <support.opensource@diasemi.com>,
	Cosmin Tanislav <cosmin.tanislav@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Antoniu Miclaus <antoniu.miclaus@analog.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-input@vger.kernel.org
Subject: Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference
 supplies
Message-ID: <043b347b-2652-4ffb-a8e0-954a89899ade@sirena.org.uk>
References: <20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com>
 <20240327-regulator-get-enable-get-votlage-v1-1-5f4517faa059@baylibre.com>
 <ZgWw66OpLnLPdCn-@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cUF0P50pg6+6H6Lf"
Content-Disposition: inline
In-Reply-To: <ZgWw66OpLnLPdCn-@google.com>


--cUF0P50pg6+6H6Lf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 28, 2024 at 11:03:23AM -0700, Dmitry Torokhov wrote:

> So because we decided that we could not have devm_regulator_enable()
> because of (IMO) contrived example of someone totally mixing up the devm
> and non-devm APIs we now have to make more and more devm- variants
> simply because we do not have access to the regulator structure with
> devm_regulator_get_enable() and so all normal APIs are not available.

I don't follow what you're saying here?  What normal APIs are not
available?  AFAICT this has nothing to do with a devm enable, it's a
combined operation which reports the voltage for the regulator if one is
available which would still be being added even if it used a devm
enable.

> This is quite bad honestly. Mark, could we please reverse this
> shortsighted decision and have normal devm_regulator_enable() operating
> on a regulator?

Nothing has changed here.

--cUF0P50pg6+6H6Lf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYFtHcACgkQJNaLcl1U
h9B0aQf9GhSPMJsemBBQsnirWqzi3QaGUE29Rt78hmG7hRYC5m9vngooWRxd8hO5
n0JQPednZleR4Sv9xLb6kXcNskt+l4KyvRc7wL1xJ2M1CjTshtxSEscQs22KTbag
wvoakMhfgWdqb+Rz9KI2XnTEUJHB5ZrKh1iygy656jIu2+RiRN94upSZWv09gtKT
zW0jUaUPKe6gO/wod5bKYVhbmPYEyOZ7Ya8ZvuZNQoYUqbii4oYBpb1EAT27p8u2
3k2eKUYu64XwASkizaqo6Vn0xu2LTBtaUg9tYYyCyhD0V9Suju3H41F42PgLfrWo
Q55X+JAPty/mqfVn+05geMu2OBjk9g==
=9vNv
-----END PGP SIGNATURE-----

--cUF0P50pg6+6H6Lf--