Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp630143lqh; Thu, 28 Mar 2024 11:21:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU96Y5V9arpV2Sg0N723dQAVrNk3EploVLTY2Ybbq5l2sIzTGgHN31Vu/18Cvd89i8HQEMjTR9iBgA5y5OZIhpS+GabN4I49Yxtjrhr/A== X-Google-Smtp-Source: AGHT+IGdHLOSlt25hS5pngninPP5ET/+KQurHQ0CxUaxi5w+siCmH+ny88OnMazrY4NQwef3svbE X-Received: by 2002:a17:902:db11:b0:1e0:b3a8:7db4 with SMTP id m17-20020a170902db1100b001e0b3a87db4mr229759plx.45.1711650110347; Thu, 28 Mar 2024 11:21:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711650110; cv=pass; d=google.com; s=arc-20160816; b=oJztk3b0tmuVc0gIQUQrtVJjdHTvpHGuWDzILJfCyxdA4R+shzjYkdSkNI4SQOKgte l8Jw3/pH1hIk0Pk199zh3hz/MWt427hNBNkAdkv9PCNY/Zq0e3DA2g2UQJ7dMygV9Pap ZSh5K9sgJZHctcxDkSCuzUfMrtUPDSSD4qTIO0OSp5EMfmHZGo0TrR94BXkYthDPaJZ6 2ElCBrI2WwqNg2znVa7kS+FICOesiIBajJaG1Mlj37tEruMkTXkIlWqm3XNkveiX9cxd oJ7e/4/tCAT4YJazQVwaC4fQ9zcXC+XUM/5ToX557Tm/pvFpP406/lGxaLbMXl1j0aAe 6pdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=y4lkCyDTamK3cX78ncv2CGTAYAyyy3FiJvV1FCjqbRc=; fh=Fa7MwpiRiKHvHC/prTq1HViSLYGqe02zCL1nve5+2po=; b=kAO1jm9lzYxsWxTvyhFy1GroABpNKXKWHvlbiAYN1pvSyWbh4zP2k+tcz9MKzQ/pBz j4eEGAgmulnFyfSQRMMyKphJqANxc2ibdAY/3q1AS/JgzC/YEB0LAJGCF9b66Zv9c+Lo i5mDKoCuShjQgIBazBVg7vbc3imO2OD/g9XsI81Aeg2pKNQ/gZk671tcbi5yNmwz2cA4 lVzl+9cUI/yllSkS+W7WesoylyJ/Bdj+TOnX1J102gULIi9a0oAaYXwJz0JFgjIdLz/q vCBXaoP6h1uscyF/CKjANWqjvHbm7wkKHpRlp9Tl5cSQQFl+sjZLZTvHaLI1cwBuyKDE sTAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuJiS4X6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123405-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id k17-20020a170902c41100b001dd01526874si2013563plk.325.2024.03.28.11.21.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 11:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuJiS4X6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123405-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 31F2DB243CE for ; Thu, 28 Mar 2024 18:16:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7FEF413664E; Thu, 28 Mar 2024 18:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QuJiS4X6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA2321879; Thu, 28 Mar 2024 18:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711649751; cv=none; b=BvutotCyfWDgCANKk3t7emJQraVW/cnGVQEyTad9ECn0XzXrdabC4qf0sLtI/8i37ZllRD2ahgfx0J9dYsjRIEtGicUnzYbnUeszV54QonXn+sXTddAexLyQcWE+EwXJCvGCYG4aEZ/ODODFtYeloSTwSRQtV0udvdH4KusbR38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711649751; c=relaxed/simple; bh=UMRSyA2bFP0rXa5J3dxBKBlpn6kkbV2kY4w4LwiVwHY=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=RpPZHmihZ5qrULVBIIZ4XIo0MI/uI1NNxCDCFYEglau5WTmhzQMFCxEdGQORHu41JyqhKqXrLhQ6Kr/y0ufmquIRA3h6a34c9O5peBWkqQrSzhnoGiZJjzXKvpUMEkfUDTmctDtTnNq7nJDRkYyD4++5MubRPqqgNQNDOBjjtrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QuJiS4X6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A4FCC433C7; Thu, 28 Mar 2024 18:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711649751; bh=UMRSyA2bFP0rXa5J3dxBKBlpn6kkbV2kY4w4LwiVwHY=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=QuJiS4X6+SdOhHuV25qq6pjN7O5OWbXkQDTacNSecHOhaFO6IA0wGTntXz42drxV4 B24ttCqs4lZoBY0A9jpzP6I7hVETkOOcxhGYYzEal5997+QqBZvORtiLiXALeX00OG JMlAMtUqPNtl9+oJy8LgLxFwSm1l68w4fEUayhmxfeIX43rXTdExy1QYi4IvoBF7Qm L3YbtCpZVvvZLJvsjxOQUlVd1RHe7nUXskPLDPoMB/kdLGMCcTE7cwQZjzIf4cilE7 R6S3hTEwPD1C/TNSDYlPQQi1BdkgLrjTZPdHK/zcs/7IzB+5GZEE64vWmGCKHTlSFf /VTBDaY7wGKLg== From: Vinod Koul To: linux-sound@vger.kernel.org, Bard Liao Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com In-Reply-To: <20240326060021.973501-1-yung-chuan.liao@linux.intel.com> References: <20240326060021.973501-1-yung-chuan.liao@linux.intel.com> Subject: Re: [PATCH] soundwire: bus: don't clear SDCA_CASCADE bit Message-Id: <171164974802.128475.13743967735828669575.b4-ty@kernel.org> Date: Thu, 28 Mar 2024 23:45:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Tue, 26 Mar 2024 06:00:21 +0000, Bard Liao wrote: > The SDCA_CASCADE bit is a SoundWire 1.2 addition. It is technically in > the DP0_INT register, but SDCA interrupts shall not be handled as part > of the DP0 interrupt processing. > > The existing code has clear comments that we don't want to touch the > SDCA_CASCADE bit, but it's actually cleared due to faulty logic dating > from SoundWire 1.0 > > [...] Applied, thanks! [1/1] soundwire: bus: don't clear SDCA_CASCADE bit commit: b3a6809e623c03371ba51845129cdec3ebb7896e Best regards, -- ~Vinod