Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp651806lqh; Thu, 28 Mar 2024 12:01:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6blxvBDcQ1sJ6Pv+FbwjPtOuPN7F40LNWUAw+/42QFt/nEnhs5fnYIr7RqxiA4uNF2OusVmcfJflOpQVlmg8H4mw9zp+qaxPhZzYWsw== X-Google-Smtp-Source: AGHT+IHMF70ZcDAXyuQ51sRE9DrUZHYOeedQ36mdbKKMrRHmc90H0TX63oXpvPtucN5E4UQBJTmN X-Received: by 2002:a05:6a20:4faa:b0:1a3:8a93:aa76 with SMTP id gh42-20020a056a204faa00b001a38a93aa76mr34496pzb.44.1711652510589; Thu, 28 Mar 2024 12:01:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711652510; cv=pass; d=google.com; s=arc-20160816; b=Et+NtjQa09nJ3R+Or9VGofYLtNoKTbTxAZFc6rlJCJp5g2+tePQsqJ5Fd4EK5eB3QO jYlLMUw5kEyNd1K2cOPlpeDQm10EWHE7qA+WNl1AjUSIKPA4ABRxMUQNJmnCFaLtVe4i rl0KSLfVcl4l+8wX0RbLCss5LBImWhnVOd7cWBI/ROLipvQUk45dR6mhWO76LRkELqvN 3PjybX/7a5aK8zRIVsNNLf6dFUgpmptGbkWzJ3dWsK5XfKEhHjuLXMRZQX+zSX19DMiw h65r1K5Ifg21zbxDdsA28d+UkWSNmZxeKYh0FM1elNwzwzsA8qTT0APTdMRpA/GO6OSd 0AGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=LzHJvfogbnZ7V35IfKtne+N2aEzgKrna74HazkohkkY=; fh=nsxpqO/Ix5++z+daWVJubZGSdCSxpYUZYRPjnHQD7aE=; b=XocD5vEiO5/iR+sO/HqRaSTBljK9NmHIz2kZXfD2lwCKmK0ViGzImMIW/CnJqf5EQJ y5t2Nmabr0ArGGZyQ+acdtpSYjPbJnXyvXV6a0Fr4AucUOL5dbLyA5wFlzxBDToHp5qS aA5pOy6tNS9DQremtHSydOf/hOKfvpKovCxArqasNj1KCHhpf1MWFnyuDrGGxc9ktRte VGsocEq+z9CRrkgTgmkugeR5li9xBrlh/7eQQa7Gn9mw30hjFh6xc6959mRo8UZokbnZ xO4QyRHsORw2Ds+DstyiQrDXaTme3rwtTTLWnkaAjTI/3b5eG2WokppaNesJdZShXdps 6uvg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=EuRHhQSu; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123448-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a19-20020a637053000000b005d8b59b8da3si1965817pgn.839.2024.03.28.12.01.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:01:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=EuRHhQSu; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123448-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 42C9A2967FB for ; Thu, 28 Mar 2024 19:01:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F000C13791B; Thu, 28 Mar 2024 19:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="EuRHhQSu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2587A13775B for ; Thu, 28 Mar 2024 19:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711652504; cv=none; b=mnNTAhxQ0LIiOBQ0RBDjVMeEGFw5R+i3ZXOQ7gdYChpsoFx6VQqcUWa7r26Lh9oqwcqtUZfvJOfFPn4aaRVAzyt7IIt7mqcczURmh9MKW6pok/BfAERepmqWJNc5NqLnyIJpkiUAfaMc2AEmCzA24VSZwVFT6SyVqG0AQ2Xgeqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711652504; c=relaxed/simple; bh=75zJQi6/t8Bugee7Y/WvYhL+nXJNnuKScwY0EXrSoes=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ZXI+M8hjvSKSTpkNNqJMgiWt89R7M+ZAx7DFenE0jikZL72UYjstpzQqXsWAdKMSpKTJT9VY6YFsQLGz0X1ElxVCYdBrrdKdZ5euSw7VhIgEEAV6dNKruBY9USmlFVn8J+pOVJzNb60Dz14B5Y/qSxPv7VgxUTcz2jMSJlbVxgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=EuRHhQSu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F78C433F1; Thu, 28 Mar 2024 19:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711652503; bh=75zJQi6/t8Bugee7Y/WvYhL+nXJNnuKScwY0EXrSoes=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EuRHhQSuhT6UhLje68IlwmCQqCGilcULpK7LoI7ffKimNB38kuwasGAwdmey5M3bK w76Dbmfxu5cMJPhJmPKXGTUSaluFio9ZuNxZZjD9m62mGWpZNm0O1s3PHo4jeQl/xU PchmtkI3nAt7scT0o5FtyP+3XAlYHJwqdV8wlpBc= Date: Thu, 28 Mar 2024 12:01:42 -0700 From: Andrew Morton To: David Hildenbrand Cc: peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: Re: [PATCH v4 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-Id: <20240328120142.32c6676dc7fbf1af82da5e58@linux-foundation.org> In-Reply-To: <372a9331-6d95-4083-9a8f-a4f714868bea@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-7-peterx@redhat.com> <372a9331-6d95-4083-9a8f-a4f714868bea@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Mar 2024 11:10:59 +0100 David Hildenbrand wrote: > @Andrew, you properly adjusted the code to remove the > gup_fast_folio_allowed() call instead of the folio_fast_pin_allowed() > call, but > > (1) the commit subject > (2) comment for gup_huge_pd() > > Still mention folio_fast_pin_allowed(). > > The patch "mm/gup: handle hugepd for follow_page()" then moves that > (outdated) comment. OK, thanks, I fixed all that up.