Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp660597lqh; Thu, 28 Mar 2024 12:15:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWI9y4Cix277JWF1GTMFWdCzvhnLIdxQzq2aQ/Z9WTxeTc+0UeFyXwm6XVlimKXiysXVNaZxQfT5syikOg74O64UEsQZ7FJxF52nfnXrg== X-Google-Smtp-Source: AGHT+IG5N6SaQyY9O/2PiWJsHlb8+GyVGTmX4tBWH56ziT9XwMxgEyDgOI/nbGqHFpgV3Lbsf3ba X-Received: by 2002:a0c:e64e:0:b0:696:755f:c0cb with SMTP id c14-20020a0ce64e000000b00696755fc0cbmr637056qvn.8.1711653322451; Thu, 28 Mar 2024 12:15:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711653322; cv=pass; d=google.com; s=arc-20160816; b=BjCl9m6UineWZnAS/12Pb9Gu02rn0QEbZpVYUmJeq5nRpz/sdtWF3H7ftgs4YmFdn0 rtWrcwO6IURiL9You7q3GmmyPKWklftQkry2N+a5QagpJ18Qe0WYfLGc9Y2WihCwe1b3 eNf3LcnhhCJJAUbSrWE437CNfcj86vnxIfboPkOehyfSALN3ZNeFX1Xb5JhxlHrte08s CWQQSRsawEgf33vVAcmG2TG14hSFUDXjQMw0FUjTf1etCMQVQTCh/TTzgD9sO7P6q6Mv RgbS1R7NreWiT93kBy93W+5qI0BCRl/VJ7U6NmJmTWjMoptPeCWpLG5A5+Va14x0NgM+ hK9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=UiiYaB+fnO7Vb9P9+KhFx8SmJF7I5vpoUotl6zT2/zs=; fh=gfNB88oOgmyLtzs3J9TRMdZJMaHLNEzM7+cHhTRzd+s=; b=cZ6NffgDHvGNgRQGco4moIw1w/eNU9XsLRhGBasRnY5rxqQFiq8NcMPGPTQjm6b/E/ lLBy6QQjUWtUZ2djf1d3LiD4TvIF/BwoST/mLhmlT5iWG1hh+wIcGeZShrltUNFVAgR/ xzApVq2YjwvbmufU4wjqPxDEyA8oZUc5FBFgnqMfmc4M/GxE0xlnt++Md/T7/LcURNfj fgcz+8FtIAi+jx0hVqAZIot4YYmMDCcm29Y/RShdxn40yFdUUuGT7rHy6kEaH9aXnTFO miDYud9SlK6IPZwY8VC5ynU4R6ZF91jcUdlPWfBFOzBZbFvxuNWOLMiu2o9pqUytMCtC IEig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KvJB7SoZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-123460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123460-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id l8-20020ad44d08000000b006968a799886si2018457qvl.314.2024.03.28.12.15.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:15:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KvJB7SoZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-123460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123460-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2F5771C2D1DF for ; Thu, 28 Mar 2024 19:15:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F7C5137C25; Thu, 28 Mar 2024 19:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KvJB7SoZ" Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3582B9A7 for ; Thu, 28 Mar 2024 19:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653313; cv=none; b=Ls+qPKUvFuoL3lKoNr5dj81YTxuqat6J217fKCfColZvMLhvpwpnpoxjQEI5R5D1F3TpnvI/impUvA3H/IeoKasdslfnlzBXqoG1dL0X4rlQ7i7PeQh0WNFEn1faP/RkhCKFbzSXvS6Ees1Si6xtF8pC0d7bCSVo81RRmz6ejJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653313; c=relaxed/simple; bh=zM7PQiHxWzOWOO4OCrDwshJ55wl6Sv3jEAqMenXlYfw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FJxQFLIx6J154FTbFhp8krfFxXLq2Sks1EWJccag20scJiZ8NBIF3evjbhQ5hUd103cHq+SStPtTswAJWo+ijif/q0kcd+dnvZt2TBfM4nc9+fYTOx36LKO8GKmTwTBwzo+8ZAHQXXvNvUuAUIfMLIYAGvosHGlkhFDLkE76VCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KvJB7SoZ; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Thu, 28 Mar 2024 15:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711653308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UiiYaB+fnO7Vb9P9+KhFx8SmJF7I5vpoUotl6zT2/zs=; b=KvJB7SoZJKVuzlqFVWM0vRr2iWIHkYGpJutBec/Y0CDeoRB3ZqbEZnoiYkOlkksKTFjkgc ZCl0V6MkQaKz+XlvCm77TLAL4XRYFaNjdlbdfH1ZqLGFKR/WklakWlabZ6DvLfZlpu8cMo T9CtcB9YVXDlDIj6D7xWNsnofVKorJA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Kemeng Shi , willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-ID: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> X-Migadu-Flow: FLOW_OUT On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote: > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > > > This series tries to improve visilibity of writeback. > > Well... why? Is anyone usefully using the existing instrumentation? > What is to be gained by expanding it further? What is the case for > adding this code? > > I don't recall hearing of anyone using the existing debug > instrumentation so perhaps we should remove it! Remove debug instrumentation!? Surely you just? I generally don't hear from users of my code when things are working, I only expect to hear from people when it's not.