Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp665393lqh; Thu, 28 Mar 2024 12:24:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVIsF3a7j8pjz7A8FkVsvSXnea2JLsrZgD++VjNuKDG6Hsd3QILL5fOxOga2DYwTY6QLSnYZXkO477HRENk75IDA1GRqnhIMAEkoQwuDg== X-Google-Smtp-Source: AGHT+IETPbVUE499ugA9DmvLt29CdXW1PLtzJsrkNjFn1p3zdaE3yw8XBzvtNoKPkOyLseALsDql X-Received: by 2002:a05:6358:2486:b0:183:676f:c751 with SMTP id m6-20020a056358248600b00183676fc751mr319694rwc.27.1711653870352; Thu, 28 Mar 2024 12:24:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711653870; cv=pass; d=google.com; s=arc-20160816; b=tZPZKhHqVa6uZhV03iXaR22oRSZhYzravYUNUSv5564ortsFzELPm9yGhjtHFsOQwG gX8zj6OaCxvkc12aCLmJibIq723cBac4HpmBSPFNaMbTamhgVLm9u3P/dfrxYV7wKGAI SPpDPuW2ibGBPTZrJpEe2ooYb9uarNijkqVY1KUxrUHmnom/3dj2EWdP36y0JxZtP72y NebL4JakJ+qIjoxv6bI9heclKCKhCiVp5TMsjINjGyiQ7yEP38NIFWnWFIyahdQumKkJ PWQok6JWWjUeH2/fqiY+ZqmQXn9iRht2J3EDNe3KmtQV9BGdE6wANuAb8OBd45paXDmr NYtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=JzBS+/xVvFDhcJN1h5hnPEsa2ynBSFaXeLo5f0WBMPU=; fh=ft4b4ImeaV6hWDFiM8k+6OhPZ17PwqjYmywZc/LqE8A=; b=j8e97eBvPKNINTWDD71uDl+XhFD0vV+qFqMmkOS4TsAxP5bYHhHnEWqKsTWlqRDyJH +uFeFu00G2aDWuugaFvmFObGQMSgqT/weZ2S1ljv3uS7hF8N21k/oHKqNIGR5A8hfK+k 01qbdaT4g3RmHqo53fYS5TEvHQftKB+6ECi8hgSA0uZMdxUO7iUWPvsUBUI1u2uQK6bD 6s7LTB9cSpsIgRWR8Cvm5eRoDftD+VL0EHR+KkTo3p1ftAIDc3eM07zeEOx69dCtkPfa m1+ohDPvsYAqh+9g8JLUhAN4RN8CAbg0mBEXdc4itwSOw3I4T9rQ+ki2pp8ziHLnWYFV VGWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="FMMm7I/L"; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123472-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m184-20020a633fc1000000b005f0568ad21asi2035293pga.691.2024.03.28.12.24.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="FMMm7I/L"; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123472-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D08E428165E for ; Thu, 28 Mar 2024 19:24:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D2EC1C6BD; Thu, 28 Mar 2024 19:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FMMm7I/L" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552E013248F; Thu, 28 Mar 2024 19:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653833; cv=none; b=mC03snFC0KjGLWi4YVEG4UCNuUk3POkHncw6BwXT4PgbRfqU9nmAeaRmSIc3xElkI7JGw8nnSynI3uisIVMJr1SVhFbyJJ+7PjzgA8nY6Tln4IcEJwDC5oYOq2YIMPCuiIBPLbJMVZLWtIxBOhI4+7JevQ7oupoya/8ZPbAeMVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653833; c=relaxed/simple; bh=tcx4rokV5inKUefW+ngsLLPSFNOMgp1ujfya8z+v1X8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=qkjZS4QTh4mfYrJSfGr2nUekfLGtziNevKIkf/6DN5YGxSp9FvpB4ERB1SUpwx4TekElmCZrwAVq45IZkX1cghv3FZsVSA3zTxzouJL2MXmOS5ds+CH1m/dbxh8PJjrjbkrsNJRpG1lH8cduTuMzlDVMT+dGL8WgK7R6VbH2pfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=FMMm7I/L; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA7B6C433F1; Thu, 28 Mar 2024 19:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711653833; bh=tcx4rokV5inKUefW+ngsLLPSFNOMgp1ujfya8z+v1X8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FMMm7I/LQg14E2kZhWOtK7FkrhQk+qoShv1oMXBR+paFWvhtwpW3zLjaZpIzuUIls QfYEDIGkonhzH9jI8vLznzLfSLepKnYGheW6f0U+k3Ni0dvIk8xoCe7WJE5s/GA/vc S8Yf+QpIbH6vM0GdO5Qz6qH/vF/Kq/3ei4Bmwd2E= Date: Thu, 28 Mar 2024 12:23:52 -0700 From: Andrew Morton To: Kent Overstreet Cc: Kemeng Shi , willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-Id: <20240328122352.a001a56aed97b01ac5931998@linux-foundation.org> In-Reply-To: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Mar 2024 15:15:03 -0400 Kent Overstreet wrote: > On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote: > > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > > > > > This series tries to improve visilibity of writeback. > > > > Well... why? Is anyone usefully using the existing instrumentation? > > What is to be gained by expanding it further? What is the case for > > adding this code? > > > > I don't recall hearing of anyone using the existing debug > > instrumentation so perhaps we should remove it! > > Remove debug instrumentation!? Surely you just? Absolutely not. Any code in the kernel should have ongoing justification for remaining there. If no such justification exists, out it goes.