Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp671156lqh; Thu, 28 Mar 2024 12:36:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXcLsLuHH74SJeRi5vUql+G58BpGm2FwAX3bicHawMc1ihMNdIm0y55Do7P2bja6jx8VA9Ab7FzTQ1nGwseL47+UHJEhXBxGGVM3xOvYA== X-Google-Smtp-Source: AGHT+IHTou2bqSxy1CPZK3QNsC1AZv63CWitzom3CtOM9B+82hBgbRIdJYcrqq6QUwzYGCg4qf2f X-Received: by 2002:a17:902:7598:b0:1dd:de1a:bd02 with SMTP id j24-20020a170902759800b001ddde1abd02mr439399pll.41.1711654575679; Thu, 28 Mar 2024 12:36:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711654575; cv=pass; d=google.com; s=arc-20160816; b=M8QrhwOl5/on2EHWlgLsoW3wVsRvorEdViicbfZvWijeVIsrg/7qKYUGpN2S+onyfT LikyIAkaRsuKKPXi2c7gKtw+KXw14S5J2txeLgKj5BOUIoJXZF9ApdB7u5KYrtGKT393 GN85NoRzKnZT7u7pfFMfQk/Rx4hI8ak+bOTFHjfl44yzvBKcs8iXlI//XUvafqlsfN0T 1I4x3OCI4VFYTbiD9mwukuv4QW/XEpJX4Aj+C0wmU1Nne4h8SVUK5j37XOiN54vnuQfa BJHgloxa83eiU50lbJcLpFZeemCChrngOK8VKafOt5ZJ/6vmUz14NVSs3KxOC1mJ2wf0 kueA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=CiOoNkpY/2Z2DuY5SFDdy83sq+K++JKpyfO5431hRLo=; fh=+cBn7C/NWSYeMXGnjFlCUmPw3CM2F8wZpMD1x9ZH+7M=; b=QW+2ZI8nLi0/2mDcH6HgrLZOOJYJ/erWEICxYbagm4hW6WlNKQvRefHmn69UerV0Lx XTIhO1QhHdHR5vX9qNNs3tvGeoO1AjkxMfHvAOIeR/heOeb8MjbIC5CCj3jW93ZKBWUm Ew7zLebmFDFMe7S4mf02eaCc/104mUwwDkwGAMfIVSyqpJq9ympxoIn9oeWAa6ExPapJ VxYzJ/JBU1plnMeAY9VMx1iwimzqmjyTPfzju0N2BX1IIO+EuJDA2lS8wnpq2tbMzgKg 1L2LkTdEtgEZk17u6vMZMty6yXsirCHO9HFNXUsJRcTwZVPkpbSNfOqWyCNQx3yan8Df wI4Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=PHcNGxwx; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123484-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q8-20020a17090311c800b001e0b603f5b4si2061152plh.504.2024.03.28.12.36.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:36:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=PHcNGxwx; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-123484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123484-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 605CB291DD4 for ; Thu, 28 Mar 2024 19:36:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18AD01384A4; Thu, 28 Mar 2024 19:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="PHcNGxwx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F64B137C4D for ; Thu, 28 Mar 2024 19:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711654570; cv=none; b=g1j9+LTy2p439hlX+aT774BBhAJUzdHG2npbBdCPEpx3mUGQDe7MEJcEuGeFL8oqWVepMxQdqYSuh2CFImKva59/KmrA4vqsyE0IXN/PtKPvbHlxjCGcv0y0boU3kSgnN3ppAdGPuZaFMR1AoK0FJ0niNb1Rh7GdRVU/ho3BZXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711654570; c=relaxed/simple; bh=LeT5xJzgVsEttbRtHWNAa/8vqU+I5zEfspgibVh5G+U=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ZGn7pD1Gt6PKm6+sWnNYiZZwXplJNoL4nMX9BKlNwFKZsN89EuovKlYvfNtBJ0dQhWksZpd4oQA4qC3YdxGRhZ/gHSW9AIy6wBAxF+eRfDMcQLSDhdT3EpDya5O8zXXswav/Uno+wS0wDOMZJNY58ZVqKDvEpbBm5cbrCirQQMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=PHcNGxwx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65FBC433C7; Thu, 28 Mar 2024 19:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711654568; bh=LeT5xJzgVsEttbRtHWNAa/8vqU+I5zEfspgibVh5G+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PHcNGxwx0bideR0J9s+r1ppJyoVlRk+cPMJ048+M5G2sOPhehYOa9II9ErMGGteHu xzFdCXHVvhS6uUub8L5IuDRUogFWTarp3XLDJ7DaJ+u/UnwbwPVOjV0gEBSxx50F3N pbxJFiU+LdqzMH27WMT829LsSZZyjj0xfGJq22oI= Date: Thu, 28 Mar 2024 12:36:08 -0700 From: Andrew Morton To: I Hsin Cheng Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] rbtree: Introduce rb_remove() Message-Id: <20240328123608.a20ba1260aa9467df9f4256d@linux-foundation.org> In-Reply-To: <20240328064539.95795-1-richard120310@gmail.com> References: <20240328064539.95795-1-richard120310@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Mar 2024 14:45:39 +0800 I Hsin Cheng wrote: > Implement the function "rb_remove()", which can perform the removal of a > certain key from the tree. Once the node with the searched key is found, > we call "rb_erase()" to perform the removal of the node, otherwise the > key doesn't exists in the tree then we return NULL. > > ... > We wouldn't merge a change like this unless there are callers of the new function. Please tell us everything about that.