Received-SPF: pass (google.com: domain of linux-kernel+bounces-123494-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240326202859.960577-1-weilin.wang@intel.com> <CAP-5=fVAKRa7LsvyuNhjQpQuQyY5hvQ7yBnaWjeAJFYtS648Xg@mail.gmail.com>
In-Reply-To: <CAP-5=fVAKRa7LsvyuNhjQpQuQyY5hvQ7yBnaWjeAJFYtS648Xg@mail.gmail.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 28 Mar 2024 12:43:24 -0700
Message-ID: <CAM9d7ci+8m1-Hcm9OjkaLk4ZOs6J0ah+pg0phyQGA_HVX9Qb-A@mail.gmail.com>
Subject: Re: [RFC PATCH v5 0/6] TPEBS counting mode support
To: Ian Rogers <irogers@google.com>
Cc: weilin.wang@intel.com, Arnaldo Carvalho de Melo <acme@kernel.org>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Perry Taylor <perry.taylor@intel.com>, Samantha Alt <samantha.alt@intel.com>, 
	Caleb Biggers <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Thu, Mar 28, 2024 at 9:36=E2=80=AFAM Ian Rogers <irogers@google.com> wro=
te:
>
> On Tue, Mar 26, 2024 at 1:29=E2=80=AFPM <weilin.wang@intel.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@intel.com>
> >
> > Changes in v5:
> > - Update code and add comments for better code quality [Ian]
> >
> > v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@int=
el.com/
> >
> > Weilin Wang (6):
> >   perf stat: Parse and find tpebs events when parsing metrics to prepar=
e
> >     for perf record sampling
> >   perf stat: Fork and launch perf record when perf stat needs to get
> >     retire latency value for a metric.
> >   perf stat: Add retire latency values into the expr_parse_ctx to
> >     prepare for final metric calculation
> >   perf stat: Create another thread for sample data processing
> >   perf stat: Add retire latency print functions to print out at the ver=
y
> >     end of print out
> >   perf vendor events intel: Add MTL metric json files
> >
> >  tools/perf/builtin-stat.c                     |  211 +-
> >  .../arch/x86/meteorlake/metricgroups.json     |  127 +
> >  .../arch/x86/meteorlake/mtl-metrics.json      | 2551 +++++++++++++++++
> >  tools/perf/util/data.c                        |    3 +
> >  tools/perf/util/data.h                        |    5 +
> >  tools/perf/util/metricgroup.c                 |   88 +-
> >  tools/perf/util/metricgroup.h                 |   22 +-
> >  tools/perf/util/stat-display.c                |   65 +
> >  tools/perf/util/stat-shadow.c                 |   19 +
> >  tools/perf/util/stat.h                        |    4 +
> >  10 files changed, 3076 insertions(+), 19 deletions(-)
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgro=
ups.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metri=
cs.json
>
> Thanks Weilin,
>
> I'm happy with this series, my Reviewed-by is on all the patches.
> Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
> enablement? For the sake of tools, for the series:
>
> Reviewed-by: Ian Rogers <irogers@google.com>

Let me review this series again.

Thanks,
Namhyung