Received-SPF: pass (google.com: domain of linux-kernel+bounces-123588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 28 Mar 2024 13:34:46 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: WangYuli <wangyuli@uniontech.com>
Cc: rrangel@chromium.org, shaoyang@uniontech.com, helugang@uniontech.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	huangbibo <huangbibo@uniontech.com>
Subject: Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard
Message-ID: <ZgXUZtEwHEF8Rs3i@google.com>
References: <593C1A73FB93BACE+20240326131718.20497-1-wangyuli@uniontech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <593C1A73FB93BACE+20240326131718.20497-1-wangyuli@uniontech.com>

Hi,

On Tue, Mar 26, 2024 at 09:17:18PM +0800, WangYuli wrote:
> Modified keyboard_ids in function ps2_is_keyboard_id
> for Lenovo Xiaoxin keyboard.
> 
> Signed-off-by: yuanjianye <yuanjianye@uniontech.com>
> Signed-off-by: shaoyang <shaoyang@uniontech.com>
> Reviewed-by: huangbibo <huangbibo@uniontech.com>
> Signed-off-by: helugang <helugang@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  drivers/input/serio/libps2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
> index 6d78a1fe00c1..39d46526c56a 100644
> --- a/drivers/input/serio/libps2.c
> +++ b/drivers/input/serio/libps2.c
> @@ -189,6 +189,7 @@ bool ps2_is_keyboard_id(u8 id_byte)
>  		0x5d,	/* Trust keyboard		*/
>  		0x60,	/* NMB SGI keyboard, translated */
>  		0x47,	/* NMB SGI keyboard		*/
> +		0x83,	/* Lenovo Xiaoxin keyboard	*/

Could you please tell me more about the keyboard? What ID does it use?
Majority of keyboards are using 0xab83, does your device forget to send
0xab by chance?

Thanks.

-- 
Dmitry