Received-SPF: pass (google.com: domain of linux-kernel+bounces-123651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 28 Mar 2024 22:07:55 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Eric Dumazet <edumazet@google.com>, Luis Chamberlain
	<mcgrof@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysctl: treewide: constify
 ctl_table_header::ctl_table_arg
Message-ID: <20240328210755.awnuhfwws3323j3d@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="np2kr66pm2g23oxb"
Content-Disposition: inline
In-Reply-To: <20240322-sysctl-const-table-arg-v1-1-88436d34961b@weissschuh.net>
CMS-TYPE: 201P
References: <CGME20240322203446eucas1p27f8eecc9a9f4686394aa1ff2e525dd03@eucas1p2.samsung.com>
	<20240322-sysctl-const-table-arg-v1-1-88436d34961b@weissschuh.net>

--np2kr66pm2g23oxb
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 09:34:36PM +0100, Thomas Wei=DFschuh wrote:
> To be able to constify instances of struct ctl_tables it is necessary to
> remove ways through which non-const versions are exposed from the
> sysctl core.
> One of these is the ctl_table_arg member of struct ctl_table_header.
>=20
> Constify this reference as a prerequisite for the full constification of
> struct ctl_table instances.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
> This patch is only sent to LKML and the sysctl maintainers to avoid
> spamming lots of maintainers for trivial changes.
>=20
> It is based upon the branch sysctl/constfy.
>=20
> It was implemented by manually searching for "ctl_table_arg"
> throughout the tree and inspecing each found site.
>=20
> If somebody comes up with a cocciscript for this, I'll be happy to use
> that.
> ---
>  drivers/net/vrf.c                       | 2 +-
>  include/linux/sysctl.h                  | 2 +-
>  ipc/ipc_sysctl.c                        | 2 +-
>  ipc/mq_sysctl.c                         | 2 +-
>  kernel/ucount.c                         | 2 +-
>  net/ax25/sysctl_net_ax25.c              | 2 +-
>  net/bridge/br_netfilter_hooks.c         | 2 +-
>  net/core/sysctl_net_core.c              | 2 +-
>  net/ieee802154/6lowpan/reassembly.c     | 2 +-
>  net/ipv4/devinet.c                      | 2 +-
>  net/ipv4/ip_fragment.c                  | 2 +-
>  net/ipv4/route.c                        | 2 +-
>  net/ipv4/sysctl_net_ipv4.c              | 2 +-
>  net/ipv4/xfrm4_policy.c                 | 2 +-
>  net/ipv6/addrconf.c                     | 2 +-
>  net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +-
>  net/ipv6/reassembly.c                   | 2 +-
>  net/ipv6/sysctl_net_ipv6.c              | 6 +++---
>  net/ipv6/xfrm6_policy.c                 | 2 +-
>  net/mpls/af_mpls.c                      | 4 ++--
>  net/mptcp/ctrl.c                        | 2 +-
>  net/netfilter/nf_conntrack_standalone.c | 2 +-
>  net/netfilter/nf_log.c                  | 2 +-
>  net/sctp/sysctl.c                       | 2 +-
>  net/smc/smc_sysctl.c                    | 2 +-
>  net/unix/sysctl_net_unix.c              | 2 +-
>  net/xfrm/xfrm_sysctl.c                  | 2 +-
>  27 files changed, 30 insertions(+), 30 deletions(-)

I was expecting a lot more ppl cced for such an extensive patch; I only
see Eric Dumazet <edumazet@google.com>, Luis Chamberlain <mcgrof@kernel.org=
>,
and myself in the "To:" list. I'm missing the network maintainers. How
are you calculating the CC? Are you using get_maintainer.pl?

Best

--=20

Joel Granados

--np2kr66pm2g23oxb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYF3CsACgkQupfNUreW
QU+eYAwAhRzxTFP5Wm3qobBtjk7UiR8hMUce0eDVXA1XztUCVcnXYClaG5Mohmhb
duIlXItHpNkH5oA43vRC8TULuMz5SD9T4zopVjrQMomap/oxZzTWOOxZ0XbNNJzT
S8IgbbmevvoxJSohtLK3HiF+ImdDOQIzOZ2Ksbx0i/JIKa1oLlKAAKpeqke8MLg0
2Pg8IZOdn4nBerrVvqGuMEfN+PVoU3BmczTd1LXB0kneYZzF+VMkWZsJi6cAhfJh
2vUXPcv6PFuInn7nOwX2mNrq0o9uG7VN5INaPCTXVLkxigZ0f1hGBLeby0duAtxH
NifxkaZ84pxobyJyrrboixpjQMw2pUVOWvGUkSMHmlpRk9j1Zv09HzhwUhwp1jmA
jtbLeN0sZO8WR66LxSNkZFsCuptzK8+kIs7u40j65Su1PAS8BCGQt9ZRgPidDknx
h6jxaBeGLEgGy7czCkBhmRTCDpDORBLWLomrHMJi7jYpx6ojrznQvsgQPJs9gzan
eXm/e6SC
=LHak
-----END PGP SIGNATURE-----

--np2kr66pm2g23oxb--