Received-SPF: pass (google.com: domain of linux-kernel+bounces-123659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 28 Mar 2024 14:12:02 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: Chao Gao <chao.gao@intel.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
	Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v19 092/130] KVM: TDX: Implement interrupt injection
Message-ID: <20240328211202.GT2444378@ls.amr.corp.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <b2d9539b23f155b95864db3eacce55e0e24eed4d.1708933498.git.isaku.yamahata@intel.com>
 <ZgVM2kJTx1p4BjbM@chao-email>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZgVM2kJTx1p4BjbM@chao-email>

On Thu, Mar 28, 2024 at 06:56:26PM +0800,
Chao Gao <chao.gao@intel.com> wrote:

> >@@ -848,6 +853,12 @@ fastpath_t tdx_vcpu_run(struct kvm_vcpu *vcpu)
> > 
> > 	trace_kvm_entry(vcpu);
> > 
> >+	if (pi_test_on(&tdx->pi_desc)) {
> >+		apic->send_IPI_self(POSTED_INTR_VECTOR);
> >+
> >+		kvm_wait_lapic_expire(vcpu);
> 
> it seems the APIC timer change was inadvertently included.

Oops. Thanks for catching it.
-- 
Isaku Yamahata <isaku.yamahata@intel.com>