Received-SPF: pass (google.com: domain of linux-kernel+bounces-123614-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 28 Mar 2024 21:42:32 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, "Eric W.
 Biederman" <ebiederm@xmission.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Luis Chamberlain <mcgrof@kernel.org>,
	Kuniyuki Iwashima <kuniyu@amazon.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] fs/proc/proc_sysctl.c: always initialize i_uid/i_gid
Message-ID: <20240328204232.jh2ymioigvptjooa@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="f5njphdhtcms5gyn"
Content-Disposition: inline
In-Reply-To: <20240322-sysctl-net-ownership-v2-1-a8b4a3306542@weissschuh.net>
CMS-TYPE: 201P
References: <CGME20240322195138eucas1p14ff532294e26ed63a400321066f03d98@eucas1p1.samsung.com>
	<20240322-sysctl-net-ownership-v2-1-a8b4a3306542@weissschuh.net>

--f5njphdhtcms5gyn
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 08:51:11PM +0100, Thomas Wei=DFschuh wrote:
> Commit e79c6a4fc923 ("net: make net namespace sysctls belong to container=
's owner")
> added default values for i_uid/i_gid.
> These however are only used when ctl_table_root->set_ownership is not
> implemented.
> But the callbacks themselves could fail to compute i_uid/i_gid and they
> all need to have the same fallback logic for this case.
All this text is related to commit e79c6a4fc923; which is not the one at
fault. I think mentioning e79c6a4fc923 here is incorrect. Please mention
5ec27ec735ba0 ("fs/proc/proc_sysctl.c: fix the default values of
i_uid/i_gid on /proc/sys inodes") and how it missed adjusting
net_ctl_set_ownership when it was committed.

>=20
> This is unnecessary code duplication and prone to errors.
> For example net_ctl_set_ownership() missed the fallback.
This paragraph can be dropped

>=20
> Instead always initialize i_uid/i_gid inside the sysfs core so
> set_ownership() can safely skip setting them.
>=20
> Fixes: e79c6a4fc923 ("net: make net namespace sysctls belong to container=
's owner")
Why did you leave this? Do you disagree with my comment in
https://lore.kernel.org/all/20240319130716.vne4nhb3mbwtabfb@joelS2.panther.=
com/?

> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
> Changes in v2:
> - Move the fallback logic to the sysctl core
> - Link to v1: https://lore.kernel.org/r/20240315-sysctl-net-ownership-v1-=
1-2b465555a292@weissschuh.net
> ---
>  fs/proc/proc_sysctl.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 37cde0efee57..9e34ab9c21e4 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -479,12 +479,10 @@ static struct inode *proc_sys_make_inode(struct sup=
er_block *sb,
>  			make_empty_dir_inode(inode);
>  	}
> =20
> +	inode->i_uid =3D GLOBAL_ROOT_UID;
> +	inode->i_gid =3D GLOBAL_ROOT_GID;
>  	if (root->set_ownership)
>  		root->set_ownership(head, table, &inode->i_uid, &inode->i_gid);
> -	else {
> -		inode->i_uid =3D GLOBAL_ROOT_UID;
> -		inode->i_gid =3D GLOBAL_ROOT_GID;
> -	}
> =20
>  	return inode;
>  }
>=20
> ---
> base-commit: ff9c18e435b042596c9d48badac7488e3fa76a55
Now that v6.9-rc1 is out, I would rebase your next version there.


The change looks good, but the commit message still needs work.
--=20

Joel Granados

--f5njphdhtcms5gyn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYF1jcACgkQupfNUreW
QU8Y4Av/apOhPma8wv0im4TrTo3uhkhiSmUil+CyJBYvKIDNanwIE+NtlSRluYs4
b0RTC96XXRfQJe57wd+Sm+pDTKL8rlbtEILfegr+IMMigtZcqIRQZz77GzVQCIhe
AavNY/BlRGpsZiGxCJT4YHJjZsDBuJdy0W57eIZoXNFOqtEAmv5hmRcMKEi2IN2l
faKxpbppNHN3YyOH1cHkA1ObdizsL01VJIIwdh5EjJDHae6a4RJZd0kWpSw/uBkR
DKb+Bej/Hf2uBDHdThJKEJVB9V5+ByzABF8fTaXmsy80WFAKJLkuw5nKi+rNZoAd
YFJsejAO5lpy8ZSTR6BzDWYosfJJndGXp2uuKEPibxquSk+N1NVptujPdsurIczT
3kTSrWh9sInYjpi5wQ78Z9sFqDZyn7t7mLa1OHg/izqI2qcA/+zrnYm9IDbke/PT
FZ9DtiFtJIYYOoqyUKfeJMoaOGd+QhHtGGIAJNQn2ceYuOMPBz5G+SlmWNJ0qFsX
EsOvDGKO
=z7bl
-----END PGP SIGNATURE-----

--f5njphdhtcms5gyn--