Received-SPF: pass (google.com: domain of linux-kernel+bounces-123790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 28 Mar 2024 15:51:31 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: TaheraFahimi <fahimitahera@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: gdm724x: Align descendant argument to the open
 parenthesis
Message-ID: <ZgX0c7mTJkipSkmQ@aschofie-mobl2>
References: <ZgXupx0nXwIOjy7F@tahera-OptiPlex-5000>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZgXupx0nXwIOjy7F@tahera-OptiPlex-5000>

On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> 	CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>

Tahera,

I'm seeing this from checkpatch:

WARNING: From:/Signed-off-by: email name mismatch: 'From: TaheraFahimi <fahimitahera@gmail.com>' != 'Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>'

Folks sometimes miss checkpatch reports if they only run checkpatch
on their head commit. Please run it on the formatted patch before
sending it.  

Please refer to checkpatch documentation, but if it's useful, here's
what I do:

While developing a patch do this:
$ git show HEAD | scripts/checkpatch.pl --strict --codespell

Confirm with this before sending a patch to a mailing list:
$ scripts/checkpatch.pl --no-tree --strict --codespell $1
($1 is the formatted patch and that location is usually out of tree
in my development environment.)

--Alison

> ---
>  drivers/staging/gdm724x/gdm_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
>  	int ret;
>  
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> -				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> +						TTY_DRIVER_DYNAMIC_DEV);
>  		if (IS_ERR(tty_driver))
>  			return PTR_ERR(tty_driver);
>  
> -- 
> 2.34.1
> 
>