Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp763298lqh; Thu, 28 Mar 2024 16:09:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWn0O4kB29UpxDg9wJdcHxT1OgYwlIHS18NHUXdMQXRlByXDLnvwprtS3c+iS+UFEcLDkF5trf1ohjXMNIlB2ZjoD036UEFgJ55QnigCg== X-Google-Smtp-Source: AGHT+IGKQ1Zef8qfos4PITw858vTg88aUE8AgFeqJwNzEMnFbI1W3zDmXYPP7kti9jZ7HfeIzSfy X-Received: by 2002:a17:902:e750:b0:1dd:b73a:352c with SMTP id p16-20020a170902e75000b001ddb73a352cmr890654plf.53.1711667355527; Thu, 28 Mar 2024 16:09:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711667355; cv=pass; d=google.com; s=arc-20160816; b=QMlBxds38+ngA8BQo9z32A1NgLze8dCDoMj/xtrloXJ80QQYxyX3l1VUiLIAMG1Nk8 aqfE7ojIU4xCrZRRvbCezxIJg2Z+2opCCjjTV7gHuP6Khm19PiuG4Eq4AuAYKjZ2bk7h tkzT4tFKGvby4b1UdjUF/PN0wk0aZ6MPFE8ttH2PDhSeVaGNPlN0X59sHLBuG/tAEbAP /rydaFO0vLj7XtJ1GG0TcnXGJM9PxVXb19LUqlEmQei66wmbx3Vdg8bsguRnB7PEQL+7 QbWDmu285zny816k53WQs/aldZWYGyko3hX7UXm9W1end4BpfEdbpy4qg1PFv4YXLeic h+uw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=TC3w1eT+YOsaXteg2qVtMJgL5tF8CMgimfXlC6ruSkI=; fh=oNFAL5BxQo48bsF0ZoRJkPvdd+zbRwfXGpU6Yo76pVQ=; b=pG0cCQIKtoiCgFFuAWxZwxriAXYfMgcZW4evmd3YkcLdoG3MOUAEisKauYcnvF+KnH Y7sUbbkbi/JzqaQVldDJpbJX9T456Ml2Ja1megOjBCi2CjxSLH/ZxjFZaZm+hdery8gg WOVf3FZBWWEGWJhKzc9tO0yVo4Wq2pNm/8NmSZc0fULeipHZwkler0EZDDoTYvLbZMIe 7Vbf54XE/5DGcZIrFesBpEKdheK4mTOr4oSXOOEdy17CeHP4jB+2i32Zpsmm94ryud6N VWLiDZfiFMibPeKTsF1joB8g3oT+97K7rRX9j3HBEmCdWx5sCI09F2+FbqpqromDRHhM m1xw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=y6Tygybz; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-123799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123799-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id lw6-20020a1709032ac600b001e0b8743f67si2335984plb.265.2024.03.28.16.09.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 16:09:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=y6Tygybz; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-123799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123799-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E2A982947DD for ; Thu, 28 Mar 2024 23:08:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F1D055C3C; Thu, 28 Mar 2024 23:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="y6Tygybz" Received: from mail-108-mta243.mxroute.com (mail-108-mta243.mxroute.com [136.175.108.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6CC2C19D for ; Thu, 28 Mar 2024 23:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.243 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711667315; cv=none; b=E+GlrgRc6Aa+buyo2nfZhyp1erb2rX8apWAbKz6JHUJQAQM6tVoreVou4VsVoqxSloQ0UMSdg20I4orCa62hU7P2h6++Ij2V3UNjDiwCunTyeW+HnGbdIqeJ40fF0lxEVwylgLWGtSxLbR32SE/9SiMeNEA/POVUoa9sjKuekLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711667315; c=relaxed/simple; bh=i6aU2MtMCVyaE+TeqyLWdPClsm5ZLopHbGuDJCIXnsk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IID1GcyBaTwokBmSwn3dESttDq1VbSd4dfGGOPKyjpS0Q7Q1NjnojaAettTFbCWXqb8vACZgnGb2QZgTl48kkftnDw3gyjysnh0JharX3k0fU0mbiAGeUOFPdWrkSTp5kBQgLZfS1Z8eFoVzLXVw1CYT/rePXfikty+lQa+wuFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=y6Tygybz; arc=none smtp.client-ip=136.175.108.243 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta243.mxroute.com (ZoneMTA) with ESMTPSA id 18e874db4270003bea.00f for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Mar 2024 23:03:20 +0000 X-Zone-Loop: 54d4e7b1693efeeb64162e6523c95a4d144447c05dc5 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TC3w1eT+YOsaXteg2qVtMJgL5tF8CMgimfXlC6ruSkI=; b=y6TygybzO2Cr9wSYC2NJXkCwuC AFTWAAuaWd7sJd4RnWCb6d1ujehDsM/sXXr8ZLcUmQXVPHY2tGGvSXatHXCJ4loL/nPnYp8fXKqI6 9BcTcKJbm2WUDibln+UbTKvN+DvITBXtRn6wrXSHvRcyLnjFyKSdkgVhIRA4DPe13jMf7I0aDT0wn hXJXwPjIc9AEKkaLj4KMZxWzkaYmyaVtbQd8taSDqy3oH8wet/8jQf49afQw0QVaYvYhHnFyi+ySY 0/a7DMiA2RpcEqbOiB5pZ4Bqo61O1YxnEm3vGqSNGGRYQ4XxTPd2y5LezWbzgI/+6e/B6p+FE6pCs Ay+FgTKg==; Message-ID: <7e207725-3eb9-4549-8fdf-3d2ddd12e36e@luigi311.com> Date: Thu, 28 Mar 2024 17:03:15 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/23] media: i2c: imx258: Add support for 24MHz clock To: Sakari Ailus Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240327231710.53188-1-git@luigi311.com> <20240327231710.53188-9-git@luigi311.com> <11f2e7d8-fd4c-4e14-81d8-cbc2cd2442fa@luigi311.com> Content-Language: en-US From: Luigi311 In-Reply-To: <11f2e7d8-fd4c-4e14-81d8-cbc2cd2442fa@luigi311.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authenticated-Id: git@luigi311.com On 3/28/24 11:55, Luigi311 wrote: > On 3/28/24 02:09, Sakari Ailus wrote: >> Hi Luigi311, >> >> Thank you for the patchset. >> >> On Wed, Mar 27, 2024 at 05:16:54PM -0600, git@luigi311.com wrote: >>> From: Dave Stevenson >>> >>> There's no reason why only a clock of 19.2MHz is supported. >>> Indeed this isn't even a frequency listed in the datasheet. >>> >>> Add support for 24MHz as well. >>> The PLL settings result in slightly different link frequencies, >>> so parameterise those. >>> >>> Signed-off-by: Dave Stevenson >>> Signed-off-by: Luigi311 >> >> Is Luigi311 your real name? As per >> Documentation/process/submitting-patches.rst, anonymous (or pseudonym I'd >> say as well) contributions are not an option. > > Luigi311 is not my real name but it would be a lot easier to find me if > it was. My real name is Luis Garcia which is a super common name so its > actually way easier to find me and all my work using my online name of > Luigi311. I can go ahead and swap over to Luis Garcia if required but a > name like that would provide no value in contacting/finding me since I'm > not famous like all the other Luis Garcia's that appear on google. > >> >>> --- >>> drivers/media/i2c/imx258.c | 133 +++++++++++++++++++++++++++++-------- >>> 1 file changed, 107 insertions(+), 26 deletions(-) >>> >>> diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c >>> index 351add1bc5d5..6ee7de079454 100644 >>> --- a/drivers/media/i2c/imx258.c >>> +++ b/drivers/media/i2c/imx258.c >>> @@ -76,9 +76,6 @@ >>> #define REG_CONFIG_MIRROR_FLIP 0x03 >>> #define REG_CONFIG_FLIP_TEST_PATTERN 0x02 >>> >>> -/* Input clock frequency in Hz */ >>> -#define IMX258_INPUT_CLOCK_FREQ 19200000 >>> - >>> struct imx258_reg { >>> u16 address; >>> u8 val; >>> @@ -115,7 +112,9 @@ struct imx258_mode { >>> }; >>> >>> /* 4208x3120 needs 1267Mbps/lane, 4 lanes */ >>> -static const struct imx258_reg mipi_data_rate_1267mbps[] = { >>> +static const struct imx258_reg mipi_1267mbps_19_2mhz[] = { >>> + { 0x0136, 0x13 }, >>> + { 0x0137, 0x33 }, >>> { 0x0301, 0x05 }, >>> { 0x0303, 0x02 }, >>> { 0x0305, 0x03 }, >>> @@ -133,7 +132,29 @@ static const struct imx258_reg mipi_data_rate_1267mbps[] = { >>> { 0x0823, 0xCC }, >>> }; >>> >>> -static const struct imx258_reg mipi_data_rate_640mbps[] = { >>> +static const struct imx258_reg mipi_1272mbps_24mhz[] = { >>> + { 0x0136, 0x18 }, >>> + { 0x0137, 0x00 }, >>> + { 0x0301, 0x05 }, >>> + { 0x0303, 0x02 }, >>> + { 0x0305, 0x04 }, >>> + { 0x0306, 0x00 }, >>> + { 0x0307, 0xD4 }, >>> + { 0x0309, 0x0A }, >>> + { 0x030B, 0x01 }, >>> + { 0x030D, 0x02 }, >>> + { 0x030E, 0x00 }, >>> + { 0x030F, 0xD8 }, >>> + { 0x0310, 0x00 }, >>> + { 0x0820, 0x13 }, >>> + { 0x0821, 0x4C }, >>> + { 0x0822, 0xCC }, >>> + { 0x0823, 0xCC }, >>> +}; >>> + >>> +static const struct imx258_reg mipi_640mbps_19_2mhz[] = { >>> + { 0x0136, 0x13 }, >>> + { 0x0137, 0x33 }, >>> { 0x0301, 0x05 }, >>> { 0x0303, 0x02 }, >>> { 0x0305, 0x03 }, >>> @@ -151,9 +172,27 @@ static const struct imx258_reg mipi_data_rate_640mbps[] = { >>> { 0x0823, 0x00 }, >>> }; >>> >>> +static const struct imx258_reg mipi_642mbps_24mhz[] = { >>> + { 0x0136, 0x18 }, >>> + { 0x0137, 0x00 }, >>> + { 0x0301, 0x05 }, >>> + { 0x0303, 0x02 }, >>> + { 0x0305, 0x04 }, >>> + { 0x0306, 0x00 }, >>> + { 0x0307, 0x6B }, >>> + { 0x0309, 0x0A }, >>> + { 0x030B, 0x01 }, >>> + { 0x030D, 0x02 }, >>> + { 0x030E, 0x00 }, >>> + { 0x030F, 0xD8 }, >>> + { 0x0310, 0x00 }, >>> + { 0x0820, 0x0A }, >>> + { 0x0821, 0x00 }, >>> + { 0x0822, 0x00 }, >>> + { 0x0823, 0x00 }, >>> +}; >>> + >>> static const struct imx258_reg mode_common_regs[] = { >>> - { 0x0136, 0x13 }, >>> - { 0x0137, 0x33 }, >>> { 0x3051, 0x00 }, >>> { 0x3052, 0x00 }, >>> { 0x4E21, 0x14 }, >>> @@ -313,10 +352,6 @@ static const char * const imx258_supply_name[] = { >>> >>> #define IMX258_NUM_SUPPLIES ARRAY_SIZE(imx258_supply_name) >>> >>> -/* Configurations for supported link frequencies */ >>> -#define IMX258_LINK_FREQ_634MHZ 633600000ULL >>> -#define IMX258_LINK_FREQ_320MHZ 320000000ULL >>> - >>> enum { >>> IMX258_LINK_FREQ_1267MBPS, >>> IMX258_LINK_FREQ_640MBPS, >>> @@ -335,25 +370,55 @@ static u64 link_freq_to_pixel_rate(u64 f) >>> } >>> >>> /* Menu items for LINK_FREQ V4L2 control */ >>> -static const s64 link_freq_menu_items[] = { >>> +/* Configurations for supported link frequencies */ >>> +#define IMX258_LINK_FREQ_634MHZ 633600000ULL >>> +#define IMX258_LINK_FREQ_320MHZ 320000000ULL >>> + >>> +static const s64 link_freq_menu_items_19_2[] = { >>> IMX258_LINK_FREQ_634MHZ, >>> IMX258_LINK_FREQ_320MHZ, >>> }; >>> >>> +/* Configurations for supported link frequencies */ >>> +#define IMX258_LINK_FREQ_636MHZ 636000000ULL >>> +#define IMX258_LINK_FREQ_321MHZ 321000000ULL >> >> These values aren't used outside the array below and the macro names are >> imprecise anyway. Could you put the numerical values to the array instead? > > Ok I've removed the defines and just threw the values into the array instead. > >> >>> + >>> +static const s64 link_freq_menu_items_24[] = { >>> + IMX258_LINK_FREQ_636MHZ, >>> + IMX258_LINK_FREQ_321MHZ, >>> +}; >>> + >>> /* Link frequency configs */ >>> -static const struct imx258_link_freq_config link_freq_configs[] = { >>> +static const struct imx258_link_freq_config link_freq_configs_19_2[] = { >>> [IMX258_LINK_FREQ_1267MBPS] = { >>> .pixels_per_line = IMX258_PPL_DEFAULT, >>> .reg_list = { >>> - .num_of_regs = ARRAY_SIZE(mipi_data_rate_1267mbps), >>> - .regs = mipi_data_rate_1267mbps, >>> + .num_of_regs = ARRAY_SIZE(mipi_1267mbps_19_2mhz), >>> + .regs = mipi_1267mbps_19_2mhz, >>> } >>> }, >>> [IMX258_LINK_FREQ_640MBPS] = { >>> .pixels_per_line = IMX258_PPL_DEFAULT, >>> .reg_list = { >>> - .num_of_regs = ARRAY_SIZE(mipi_data_rate_640mbps), >>> - .regs = mipi_data_rate_640mbps, >>> + .num_of_regs = ARRAY_SIZE(mipi_640mbps_19_2mhz), >>> + .regs = mipi_640mbps_19_2mhz, >>> + } >>> + }, >>> +}; >>> + >>> +static const struct imx258_link_freq_config link_freq_configs_24[] = { >>> + [IMX258_LINK_FREQ_1267MBPS] = { >>> + .pixels_per_line = IMX258_PPL_DEFAULT, >>> + .reg_list = { >>> + .num_of_regs = ARRAY_SIZE(mipi_1272mbps_24mhz), >>> + .regs = mipi_1272mbps_24mhz, >>> + } >>> + }, >>> + [IMX258_LINK_FREQ_640MBPS] = { >>> + .pixels_per_line = IMX258_PPL_DEFAULT, >>> + .reg_list = { >>> + .num_of_regs = ARRAY_SIZE(mipi_642mbps_24mhz), >>> + .regs = mipi_642mbps_24mhz, >>> } >>> }, >>> }; >>> @@ -410,6 +475,9 @@ struct imx258 { >>> /* Current mode */ >>> const struct imx258_mode *cur_mode; >>> >>> + const struct imx258_link_freq_config *link_freq_configs; >>> + const s64 *link_freq_menu_items; >>> + >>> /* >>> * Mutex for serialized access: >>> * Protect sensor module set pad format and start/stop streaming safely. >>> @@ -713,7 +781,7 @@ static int imx258_set_pad_format(struct v4l2_subdev *sd, >>> imx258->cur_mode = mode; >>> __v4l2_ctrl_s_ctrl(imx258->link_freq, mode->link_freq_index); >>> >>> - link_freq = link_freq_menu_items[mode->link_freq_index]; >>> + link_freq = imx258->link_freq_menu_items[mode->link_freq_index]; >>> pixel_rate = link_freq_to_pixel_rate(link_freq); >>> __v4l2_ctrl_s_ctrl_int64(imx258->pixel_rate, pixel_rate); >>> /* Update limits and set FPS to default */ >>> @@ -727,7 +795,7 @@ static int imx258_set_pad_format(struct v4l2_subdev *sd, >>> vblank_def); >>> __v4l2_ctrl_s_ctrl(imx258->vblank, vblank_def); >>> h_blank = >>> - link_freq_configs[mode->link_freq_index].pixels_per_line >>> + imx258->link_freq_configs[mode->link_freq_index].pixels_per_line >>> - imx258->cur_mode->width; >>> __v4l2_ctrl_modify_range(imx258->hblank, h_blank, >>> h_blank, 1, h_blank); >>> @@ -747,7 +815,7 @@ static int imx258_start_streaming(struct imx258 *imx258) >>> >>> /* Setup PLL */ >>> link_freq_index = imx258->cur_mode->link_freq_index; >>> - reg_list = &link_freq_configs[link_freq_index].reg_list; >>> + reg_list = &imx258->link_freq_configs[link_freq_index].reg_list; >>> ret = imx258_write_regs(imx258, reg_list->regs, reg_list->num_of_regs); >>> if (ret) { >>> dev_err(&client->dev, "%s failed to set plls\n", __func__); >>> @@ -946,9 +1014,9 @@ static int imx258_init_controls(struct imx258 *imx258) >>> imx258->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr, >>> &imx258_ctrl_ops, >>> V4L2_CID_LINK_FREQ, >>> - ARRAY_SIZE(link_freq_menu_items) - 1, >>> + ARRAY_SIZE(link_freq_menu_items_19_2) - 1, >>> 0, >>> - link_freq_menu_items); >>> + imx258->link_freq_menu_items); >>> >>> if (imx258->link_freq) >>> imx258->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; >>> @@ -964,8 +1032,10 @@ static int imx258_init_controls(struct imx258 *imx258) >>> if (vflip) >>> vflip->flags |= V4L2_CTRL_FLAG_READ_ONLY; >>> >>> - pixel_rate_max = link_freq_to_pixel_rate(link_freq_menu_items[0]); >>> - pixel_rate_min = link_freq_to_pixel_rate(link_freq_menu_items[1]); >>> + pixel_rate_max = >>> + link_freq_to_pixel_rate(imx258->link_freq_menu_items[0]); >>> + pixel_rate_min = >>> + link_freq_to_pixel_rate(imx258->link_freq_menu_items[1]); >> >> The arrays currently have two entries so this works but it'd nice to have a >> bit more robust way to handle differences between the two arrays. Could you >> maintain e.g. the number of entries in the array in a struct field perhaps? > > Would it make more sense to do something like default to index 0 and then use > ARRAY_SIZE to iterate through the array and do a comparison to get the min and > max size so it would always choose the correct value no matter how many entries > there are? > Actually down the patch series 15/23 set pixel_rate range to the same as the value, changes the logic and removes those two lines all together >> >>> /* By default, PIXEL_RATE is read only */ >>> imx258->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &imx258_ctrl_ops, >>> V4L2_CID_PIXEL_RATE, >>> @@ -1086,8 +1156,19 @@ static int imx258_probe(struct i2c_client *client) >>> } else { >>> val = clk_get_rate(imx258->clk); >>> } >>> - if (val != IMX258_INPUT_CLOCK_FREQ) { >>> - dev_err(&client->dev, "input clock frequency not supported\n"); >>> + >>> + switch (val) { >>> + case 19200000: >>> + imx258->link_freq_configs = link_freq_configs_19_2; >>> + imx258->link_freq_menu_items = link_freq_menu_items_19_2; >>> + break; >>> + case 24000000: >>> + imx258->link_freq_configs = link_freq_configs_24; >>> + imx258->link_freq_menu_items = link_freq_menu_items_24; >>> + break; >>> + default: >>> + dev_err(&client->dev, "input clock frequency of %u not supported\n", >>> + val); >>> return -EINVAL; >>> } >>> >> >