Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp809481lqh; Thu, 28 Mar 2024 18:17:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUPlDqfw4RAi5BA1/rmcIQRx0ki/3WRCUNkQGa9jKpFD2222mO3hmRhT1mn2sFGcE6Oa9iGyX+aTLJP8QIbwgO87FVM22gqHLgoGDjdZg== X-Google-Smtp-Source: AGHT+IFY4IorI/qA6MCWdrcngX7DzVBHdT4Ir1f1sgoyWG4p88XUjnt6dNhmDVyzRaZeEzILwDDP X-Received: by 2002:a17:906:46d3:b0:a47:3887:db68 with SMTP id k19-20020a17090646d300b00a473887db68mr523656ejs.38.1711675078345; Thu, 28 Mar 2024 18:17:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711675078; cv=pass; d=google.com; s=arc-20160816; b=rjTITzgH0BsNs5DV/o7Lei0dyn6MpFofasEtm1I4O1IfjxDwf8J5yDvEAdksH2H0MG 0tZIhfHTRoGUweZpW+EyYWwZX4+mKloItS5TtCVQUyiZ7cXRvoK0EbpV+54yM92rfCtX zd5RNFVi5jnfbWPpJAHOkLtf56XWMbJJx1cYqObs0ckq7J88Qee0YImB3uXJl+DADFVm gnHFLNa2zqZEGIv+zUvHPqaQUITr0L/kYTHlXQFWtqLweArOwVu7/q/O0csE1bX3uzCJ 9Dcsk4Arth/ob7jjPG2HfUdf3Kboz2c6dpd6HSgrDGOK7XHUMIpWm5ibw4zH+ZpTg/jn Gy6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=EMYBWUpy2Kx+wix1R6RcOV/OzTRFlOawcoR4xyntAn4=; fh=hyH4/WUCK/r4HvMyN7H+2rOR0mBygXebDj8Ngm33/lE=; b=SqSLeQ6aJE83w6WosJE8AHZse73PqsXLUwA0hGlwOlO6i3Bv8PBhCn+IAzqepF+M+o hpQCUq8qg7V08O7tczdpxPciafDI7tD/WOIlnLZxY8hT8MeA+fqTZ3f6bOTcoMioIE4f Ll3eE968HOT/y+lXOTqGofOQDZhkG8vWx8wTaVAPM3k2/avmYDelzgIrw6vgnSMgyDcQ yvRflGDON02C1PauZDMHIo/fCGr30ZkRiI968jA1mfe1HK5QP+QVrwGbf+l9zWlx/Cjs ZBM5QGXn7uddfWuxiiERVl3nG/GPV7yGyM2i78AU1UHgtOJmt7tjFW/hV2X5aB4Q8h0g k3cg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fZ5AfGP4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f5-20020a17090624c500b00a4e2617385fsi927267ejb.54.2024.03.28.18.17.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 18:17:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fZ5AfGP4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5F7741F2737C for ; Fri, 29 Mar 2024 01:11:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C74481426A; Fri, 29 Mar 2024 01:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fZ5AfGP4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBFB139FD7; Fri, 29 Mar 2024 01:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711674623; cv=none; b=UJxpX85GD3eCEduRpH/eJxVSEJajuQRwdlW87jykmrypBZsfifEYjs4m0aOVuMzUgiUFIC0LEHC2L9qcutilHohSnh26NDihXyjZ0iKXzxARNgDFJBj5OCkjeCrlVPrStzpSMifgJeGl1CST28WtYNHYAkVzS9UypJW/9u7kJgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711674623; c=relaxed/simple; bh=7JnxwlqzuSgt3eWXjoIiGflT6soWAUdDEi2na6CjuF0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ST7sA5IHnSiaZUfu4y1jrgDY/dm0BeYFyt/IjW1WmlExZKba6auY64LAL6MF40iuCp1a9lOCcGmDtVsKyoi4OVBpJwYl3G+Ezp9FsxJ6djOe6QJ4JCREDDyRn0tEnAGmpI1MU0hWAcsvwAQRc3s3aKRJIz6ahqC4ZIAtPtqHTCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fZ5AfGP4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25D4C433C7; Fri, 29 Mar 2024 01:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711674622; bh=7JnxwlqzuSgt3eWXjoIiGflT6soWAUdDEi2na6CjuF0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fZ5AfGP4OUTFqC5Rlvth6ogwgOkxeOQ9X3d0S3Uabjj02Q9lKWsAV3/b5HCqjE79Y Hd2AvSzncl9FDgTfQvwgBbMVhGr9pAXTBENcN3UXr9lG3pqCNuVeSAYBtV9xV6NyDN CXg/jnCgNq+x57TuYK40ZsD/4fxK5qA/kEJE3CTTKdqWs0G7QkUvyjQdzi2ZfibLLm oK8InEmcL25rkKDvc1t9VkVKvi36ICdTI9EiA82eVOZgowQR4R7lkISy2TPIPIb6Dg z7vONLIwavmt96OayxXnD5QSAhmCGTpV9/Bas3cKAfmFzSBrHUWaRYb3XtBrEEDQuK k5O7dXdxbV1bw== Date: Thu, 28 Mar 2024 18:10:20 -0700 From: Jakub Kicinski To: Nikita Kiryushin Cc: Michael Chan , Pavan Chebbi , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Rafael J. Wysocki" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Michael Chan Subject: Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend Message-ID: <20240328181020.1bc21a3c@kernel.org> In-Reply-To: <20240326183544.488242-1-kiryushin@ancud.ru> References: <20240326183544.488242-1-kiryushin@ancud.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 26 Mar 2024 21:35:44 +0300 Nikita Kiryushin wrote: > Found by Linux Verification Center (linuxtesting.org) with SVACE. Please stop adding these lines, they are unless. If you want to attribute the work to some project / employer add (SVACE) to your author lines. > Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management") How is deleting dead code a fix? Please read: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html Hopefully you can find in there whether we suggest posting new versions in reply to the old ones.. -- pw-bot: cr