Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp820557lqh; Thu, 28 Mar 2024 18:56:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU2+jZwTUwb7ncCjyg8NXh8RtB517U/1CegK4fV9koLOwSVUQzoY+/68Umwuhkn4RegFwcxUxQOZAb1TQFc6DBG7H5VmRHEbttS6uN+KQ== X-Google-Smtp-Source: AGHT+IEcL1liH4EzsOwPqyL9QkZJMYT17pqyv/fLnLWHA12FbClsqEvg9RIo6+1LQRdA0eQHJqAD X-Received: by 2002:a17:906:aca:b0:a46:b809:4b22 with SMTP id z10-20020a1709060aca00b00a46b8094b22mr541182ejf.45.1711677419362; Thu, 28 Mar 2024 18:56:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711677419; cv=pass; d=google.com; s=arc-20160816; b=ms5R94Iro76Kw05uqNl+yz6m2mm2Y1o/mZEmW4d+j/1pUD5qYBilF3Qo1yuZiBtvQd KiuuMfH+GEdNpF6Y9N2Tt5N+0gDBS7lmt3SYu4wxfYr8F8J6CZuc8lJoqJyIy2atdfGD 9jfoUNII7RuZNcSYvj5n6WIY5QJG+qIGNcfa4sdosH5F2tBSnlngkfw9xr+UDSjV53Uy ZZELaY5thSJ72BbOlVmeL3N+yNeOWtG+bfghOUeoN37eiu7sLlBQ4SBdjR+RZb26xGuB 2U94qVeykXLy1r41ayfbauUYhBufEoTZaa7HS6XqlZ7Lix7q9WOoyWuYWpLwU3S9ay/l XpRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=HnoWopqeEhgUSDrAxtnUhuDZR8QdjUiaKbpLIYgV22M=; fh=1mIyILWkoENmFcFS2+Ac/pIq8m2bHaEjwFlM0fDja7U=; b=Dzu/OLbuxXYSQeQLdbX/TRolQBiLQ7Caeyuoh4B4zBqBkb7S+eRpY73aB8qNYSXLHB afxJc6oizSkulNSF923rXfGiCxtbjZZa9xXsVqORC6VcwjVeje1caHGB5eC6u/RWdOdN k5pgOCxL+7pMbTvfCm6Irehkobn7lvWlR7mUBstOQYwJTVfglVIX04+10d3ldf+FuTUE bhagI5uYVo0KuRUEChhWsStL98ofD+70oPkgw2oDXDzEfnBD3OLcex2jryn3nF/bVEW/ 8CPTlJeDEotPDdvXxhcaW52PcuityEemfDOVkYg72ZGe/IAva0kWYx8RxRAGcTyrt1Dt UTiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=NbJm49eL; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-123761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123761-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k22-20020a1709065fd600b00a4dffd58150si1251825ejv.914.2024.03.28.18.56.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 18:56:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=NbJm49eL; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-123761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123761-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F3BA81F26CE7 for ; Thu, 28 Mar 2024 22:21:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BABB213DDDD; Thu, 28 Mar 2024 22:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NbJm49eL" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C87E13B795; Thu, 28 Mar 2024 22:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711663875; cv=none; b=gYDnPeRwWDAiw010+aaNRme+hUw9d48G4cccWYVNA0UN2lk8KNw/J606svMds958LXcCelqUTE0TID9y/T53FrllDTumrisQFY2YjRFl1iNUNK7nkdtDTFGxzHjNe6Vqdwbgj+q9kUQNyouB+1wUYuyvBXLZzuJFU3m+B+u4pQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711663875; c=relaxed/simple; bh=JVuXWZU7ypGWL4ciDE6dFgx2siJQMrXVakqC0WXbnd0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WjeDCmuy1zQEgYuBc0cmLt/E+KI2gpzycBQwmosnnTAi1GhqDTKRxyMBaBVgIdj5LgyPaMP4UK4C2itEHA0ipl6v8GxdaIBpg23DCtvsyP8WeEGWkGgoV7m+6ziOAZVXgdApHJGz+vp7swO6jKbWcA/5IzPtklv4RE9Ral8R39o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=NbJm49eL; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=HnoWopqeEhgUSDrAxtnUhuDZR8QdjUiaKbpLIYgV22M=; b=NbJm49eLsaBJIDmaaGUPIwTP6s RdCdHdp9gJrWgLOyWIaGiU2iEa3h0mDLeFNu8MpWBCcjIt+F1mBI8g082Y+IpFySLM/hEsNJi6SK1 JBk39TG18J9OCNVQporM5qOQ71kG0TDUjkZcnc4dAvsUfuM70hJvQAllMyhnggYK0MKVKGnTD8s/J pwz0gob9RjN5DyrV1KCIE79TcNpQT0Fn18OWvlWWNJjye4FkmJFqE0E/qDklUsVta8jWE3bO374Mz wFZ7SPWQCxzZ1K0xUYogPf2vhybumDglajK78Iq4x/BmSLLRdWq0eNniSqEvN8UThtFfomA7d21P3 PMZSsxhQ==; Received: from [50.53.2.121] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpxxf-0000000Fs9X-3pVK; Thu, 28 Mar 2024 22:11:04 +0000 Message-ID: Date: Thu, 28 Mar 2024 15:11:03 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 01/20] security: add ipe lsm Content-Language: en-US To: Jarkko Sakkinen , Fan Wu , corbet@lwn.net, zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com, tytso@mit.edu, ebiggers@kernel.org, axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, eparis@redhat.com, paul@paul-moore.com Cc: linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, fsverity@lists.linux.dev, linux-block@vger.kernel.org, dm-devel@lists.linux.dev, audit@vger.kernel.org, linux-kernel@vger.kernel.org, Deven Bowers References: <1711657047-10526-1-git-send-email-wufan@linux.microsoft.com> <1711657047-10526-2-git-send-email-wufan@linux.microsoft.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/28/24 13:45, Jarkko Sakkinen wrote: >> +/** >> + * ipe_init - Entry point of IPE. >> + * >> + * This is called at LSM init, which happens occurs early during kernel >> + * start up. During this phase, IPE registers its hooks and loads the >> + * builtin boot policy. >> + * Return: >> + * * 0 - OK >> + * * -ENOMEM - Out of memory > Just a suggestion: > > * 0: OK > * -ENOMEM: Out of memory (OOM) > > Rationale being more readable (less convoluted). > > And also sort of symmetrical how parameters are formatted in kdoc. It needs the " * *" to make a formatted list in the generated output. Otherwise the use of '- or ':' as a separator doesn't matter AFAIK. -- #Randy