Received-SPF: pass (google.com: domain of linux-kernel+bounces-123988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 29 Mar 2024 09:54:04 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 093/130] KVM: TDX: Implements vcpu
 request_immediate_exit
Message-ID: <ZgYfPAPToxbgGZLp@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <3fd2824a8f77412476b58155776e88dfe84a8c73.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3fd2824a8f77412476b58155776e88dfe84a8c73.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E/aRR9ObiLfdbadr9iBOuapVz+uCJiacv4DS/3mi0AjL/FLHtQdzSq6sQgjz?=
 =?us-ascii?Q?qHESUohHEAMTDew8q7OtEvq4JJIOBVbPiM9gvsR2OoEsOzpyAkCGm2scmZTH?=
 =?us-ascii?Q?rvGOpmimNkwtekKz156MZKYRd29LdQ/ti0cz45vAK09Zr4SXrCagKtLXIpvr?=
 =?us-ascii?Q?p+XUiMDxi97L3dhrrhdlA73mlvbeLJMRTO9epOtf7pRdNIxTY4SbUD5EsYhY?=
 =?us-ascii?Q?I7gVSym2miWPD1S8m0S3hSHg+1idOoJtUYFxgZcEdXPtNVRMSPCmxsZcwAYf?=
 =?us-ascii?Q?UhGiDwXEdBGHLy6ngWG0FYFWqqrKN863C2P8KxfCcOviJEL2DSb1wru1+2Dj?=
 =?us-ascii?Q?U+gHNu1jyN3FyRFkDh4aDpLfm01nrPaFCXUjIDq6/1jokZFV0QGWw7ueqj8d?=
 =?us-ascii?Q?FicPnODDjEjyQdDnLbqz4xBk7VXlu5eEPFRLlFfFyR6LbsMyHwo2O4TcPJEq?=
 =?us-ascii?Q?Z7gt8A4tGO03uXuQeg+CItQNKEi+8/b/+dQLd28LKuc5grKp68LSb+95vZeP?=
 =?us-ascii?Q?GQyy7Pp6P8OjzWoQPF3Z9IcQdfA2jKLS5ZFAM1JHYSXoBP/X6MuLf90unDKu?=
 =?us-ascii?Q?EKlcI+rX+dVN5G1/oOMIbVCsF3ouO/OxTATf7RLpjaqTQxIVMdkakFtwvPPq?=
 =?us-ascii?Q?YZ7acWKn1Bv7FjW3DW8r+gZ5vBoNZhHN5ql0HQCB3olAqS/gv/5vPG13IF1I?=
 =?us-ascii?Q?lD9PNBXPSdEoAUa0jtVh9bogTFi3maVDDjBGOH9sOrfX90MhvGC/l+YTZlXp?=
 =?us-ascii?Q?LsOjsrIxJtpJlAoWCYJzSzo6D1ovAI0VFB+7HtfR8dZ7O+jr28dDAXE/DpNX?=
 =?us-ascii?Q?uC1a9CK9+XoDfsS5VIQAqidbnUm1NbnQX1PryeQtCYAe9di2sNwqUF73Z/w0?=
 =?us-ascii?Q?ElNK05h7GAakpjVnIJTAx89qaL2j3Vi2jKudHH933cTj8H64dONl3V7hBER8?=
 =?us-ascii?Q?Sdv09QxLtIwPYgzp/+XBRdwxlx4sJZqlRg8Cozd8d9FN1MzZvgZFZnz2u9fP?=
 =?us-ascii?Q?/a/lgPa5Gq1sHMO54U5c1GFRCpb9EH+Ui5uZQT7wKcXax94C527FmVE3HEen?=
 =?us-ascii?Q?qQymqiUXOYDP6NOZiOkGh2w11nz04eyJ+F1y0VBVa/7o0c4KmUZCcWKMQJFM?=
 =?us-ascii?Q?L6fiP3zZr9ldkqBHQnA4QlC0o6IbjU2IHZm18q3G4N0bHPRxZr00+Ui7xfk5?=
 =?us-ascii?Q?x9YDW2G7oVs6BImcic/za66rxQq0svPe62kNVFvl18vX+Z8BHSxR8fCAhzt4?=
 =?us-ascii?Q?TrU3vAsj5YVaDXK2m2vn46YtWns8g4h+Qbnqyo6bvI8XUx7VydIzckaPQKdL?=
 =?us-ascii?Q?+7qkzJTMMCLSUHhOhbsHsRbvvguhjWguUt7NNsAyGKpJj+dpvpMJOs0xzjVl?=
 =?us-ascii?Q?I5bPNMliIl9U6WnUCgAz5XbpuKxEZLbBI2ZWSwbBZqELUq0c2/uxTP4TfAXt?=
 =?us-ascii?Q?FMpDXrKyjqYQ/LYfKx02/oXybv3GOjC6QRztBHzQPYKFQDlu7m6hmBwpjyW/?=
 =?us-ascii?Q?CoTnduNGo6SvRnwbjYnNN+TG5unSFN5wDhPNc4S1wvz3sm/F+71zu1WsgpVU?=
 =?us-ascii?Q?U0by+AP2K8Ww4YYqC/xFNVpDvZMZdtMUP+9Zqilh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82b81dc0-482e-40e3-b0f0-08dc4f932291
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 01:54:13.9805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 55IyzqrnCEnTU8DbZYVLHCd/CKrjbsoSBLCfFHDAXBXFTIRrHVM6iioNIDat90U/bSPcVelDOVbWEJ6qtZ1Uyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5819
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:35AM -0800, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>Now we are able to inject interrupts into TDX vcpu, it's ready to block TDX
>vcpu.  Wire up kvm x86 methods for blocking/unblocking vcpu for TDX.  To
>unblock on pending events, request immediate exit methods is also needed.

TDX doesn't support this immediate exit. It is considered as a potential
attack to TDs. TDX module deploys 0/1-step mitigations to prevent this.
Even KVM issues a self-IPI before TD-entry, TD-exit will happen after
the guest runs a random number of instructions.

KVM shouldn't request immediate exits in the first place. Just emit a
warning if KVM tries to do this.

>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>---
> arch/x86/kvm/vmx/main.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
>index f2c9d6358f9e..ee6c04959d4c 100644
>--- a/arch/x86/kvm/vmx/main.c
>+++ b/arch/x86/kvm/vmx/main.c
>@@ -372,6 +372,16 @@ static void vt_enable_irq_window(struct kvm_vcpu *vcpu)
> 	vmx_enable_irq_window(vcpu);
> }
> 
>+static void vt_request_immediate_exit(struct kvm_vcpu *vcpu)
>+{
>+	if (is_td_vcpu(vcpu)) {
>+		__kvm_request_immediate_exit(vcpu);
>+		return;
>+	}
>+
>+	vmx_request_immediate_exit(vcpu);
>+}
>+
> static u8 vt_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
> {
> 	if (is_td_vcpu(vcpu))
>@@ -549,7 +559,7 @@ struct kvm_x86_ops vt_x86_ops __initdata = {
> 	.check_intercept = vmx_check_intercept,
> 	.handle_exit_irqoff = vmx_handle_exit_irqoff,
> 
>-	.request_immediate_exit = vmx_request_immediate_exit,
>+	.request_immediate_exit = vt_request_immediate_exit,
> 
> 	.sched_in = vt_sched_in,
> 
>-- 
>2.25.1
>
>