Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp824633lqh; Thu, 28 Mar 2024 19:08:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVss7jyPyuTd9CnVzba5XDNS2utpQs9rQmZ/hLI0OllahQ9yIQhUcNxMWqGOC6sKDEAlmnSYs2He7HWG+ev6lS7Y6YSQ2fLcATPitiHMA== X-Google-Smtp-Source: AGHT+IGbd8ds2EbCM/84yCVj6tVLI6qjR/KuByK8EUNiQNOZPB8A3yYu0b20lJq4Cm5Xez7BLeAL X-Received: by 2002:a05:6a00:1daa:b0:6e7:386d:ac95 with SMTP id z42-20020a056a001daa00b006e7386dac95mr1096543pfw.1.1711678125955; Thu, 28 Mar 2024 19:08:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711678125; cv=pass; d=google.com; s=arc-20160816; b=ifaz8YpKOt7oefly8X9meEhvz8BnX9+t8g5mTPdIi7F959a1MFVI+nMR3tpQKxw31M Lat7RMidcY5jaCTMvJ/AymSRnH5Clu1taicHBQRWWYCHg1HzvFTtrEZDpB8cGNPre0d2 8+szDbTkFV71PVAkHIwrH9rnUnerMs5eYaOo1eTQJeF09DGx8aaeQ/zm2wdQEFa1GlI2 56GJfdhUwkbvwbtBFIqkvfjjExQMj6yquK8heM77pWH8aD0kQTkxfLzEkYftSJDp85I8 8aAAe+N9BykDGVKj/wMVAPTDm/hUHZEqbwDPRT5yXNROEct9AjTwZ0aPTCK1AaRyXifz xa2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=bZ9pG4B9nGRafy5pviDQ+t6Ja+dC+HfN6Fq7ez+Awgc=; fh=4RCZgwpSSQIa12DJseXF+lgVdFsoN2/VljKxiQub01Q=; b=LLqdpiVg9QmcEtXcn90+E3USK5BZbey9h9gX/XXDLlJBcv4yiW4pAK4ICel6nObUK5 JDVA6qFc0YPjCL9Qnd/STWsg5kLkmtKKuLXxTglM6QpCMx/rbxuklzrCvfJX2U832FVf YjeHN0FCTm93DYzkE/EXUw3cZL0Vc17xrBZw75uP/1cwWgx/dpBZCxFnkUbeJNEOODdc KhyXv04MLtMvJKG9g3WD/ezgJK3n4/39WIO2jjAejSaZvNI7toi/IUy1C8OLB3esPalm GLxuQxjJgrnaFrlxyf9Qh+3k/szr2Joui0PWY0XKkjGei5tswvgJnRXYncFH1sMyqViR plXw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdQcq9fd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-124022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-124022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id x6-20020a056a00270600b006e68943a381si2548953pfv.233.2024.03.28.19.08.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 19:08:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-124022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdQcq9fd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-124022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-124022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6F37628C6B2 for ; Fri, 29 Mar 2024 02:08:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 011F324A12; Fri, 29 Mar 2024 02:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MdQcq9fd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2625F11182; Fri, 29 Mar 2024 02:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711677748; cv=none; b=tUS9CV09X+59z2jCWxCLX9yWXepSjdN+HWM3YJmTDE/FNp5maOBbRApLAla4QY/1HPrVdJp85trmQL+TphVc0CEOuxTq7IRm36Ede3NuletGPGl7kl4TLmXiKh/ehP2YVytRG2QuJnS4P2upZWh3qnTD4l3Y1ao2w2LZMqShcSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711677748; c=relaxed/simple; bh=bZ9pG4B9nGRafy5pviDQ+t6Ja+dC+HfN6Fq7ez+Awgc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q4XWUHWVi6VZMXlPtKRE3pMqgieidnLrZzoJCY2XfINUPqKbP5Vh5ZOI1bU0uShWfkl0rYboHOtcQz76mUpy0eXsvuKqVWhMwNV219/glHv9YRNvBrOzvhdTSv2JtedFbA9I6yEaUClTrs5TfQhGpMBST8Jh3IDZFZOr6iSdD8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MdQcq9fd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25140C43394; Fri, 29 Mar 2024 02:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711677747; bh=bZ9pG4B9nGRafy5pviDQ+t6Ja+dC+HfN6Fq7ez+Awgc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MdQcq9fdpZ3+rq7tnElCgdpKheh5fsIXzBZxJC6H1Pe5v1OOpJ+sX+3WQYH6wNxzE b2z092UtDjwySkpSyV4wBq03YBJsYgUv4orlgGSg4NNeBrcvjDDJ2qn/hzE6QOp1lu inBskuyyIP+TAJ4FTu9Mqx/qYmm3KE6X+VssQ9P969jFDHVsAuHIbgqkEK74QAXG6B 6JMSnliZrsunORKsrBTOa+BACDoHe8H6CnZQzNlNvyzNDNJxAIxgq7GvSgjItBw0G5 r1G8zEEQkqEKcEfmpJa+T27xGChezdVJl/bKiTvApZD7T3So+CelQSvYDPidPDI6eX yCieP7/osw9Og== Date: Thu, 28 Mar 2024 19:02:26 -0700 From: Jakub Kicinski To: Pawel Dembicki Cc: netdev@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Stefan Eichenberger , Dimitri Fedrau , Kory Maincent , Maxime Chevallier , Shay Agroskin , Ahmed Zaki , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: ethtool: Add impedance mismatch result code to cable test Message-ID: <20240328190226.7aab8b76@kernel.org> In-Reply-To: <20240327162918.2426792-2-paweldembicki@gmail.com> References: <20240327162918.2426792-1-paweldembicki@gmail.com> <20240327162918.2426792-2-paweldembicki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 17:29:13 +0100 Pawel Dembicki wrote: > This commit introduces a new result code: > ETHTOOL_A_CABLE_RESULT_CODE_IMPEDANCE_MISMATCH > which represents the results of a cable test indicating abnormal impedance. I'm not a cable expert but going purely by the language abnormal != mismatch. Mismatch indicates there are two values we are comparing.