Received-SPF: pass (google.com: domain of linux-kernel+bounces-124050-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 29 Mar 2024 10:11:05 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 094/130] KVM: TDX: Implement methods to inject NMI
Message-ID: <ZgYjOfkH2p/fSXuw@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <a7ce6023eb8dd824e61023a95475629bd7ae2278.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a7ce6023eb8dd824e61023a95475629bd7ae2278.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7wtXrSdoS+FONpdjGZRII8Ba8B36bbV376L5gEZgA2hvZTJvrVRcZ1xL2vFM?=
 =?us-ascii?Q?NBHn7yGNLyY+Jtl5Ft6t0oRTCCuoqF34q0PM2c3VQA9RcwGpWGt611LTGen8?=
 =?us-ascii?Q?uacIFNApodf+P/coec1rpGGW5OGuc+AcjMLTbKDJSF3aV/lF8L6FcD2uqy5G?=
 =?us-ascii?Q?VvD7+wXSlVck2F7l2Ws54f58aShKS5hAl2B2+FeBP9+pLCV/fooGXEBTDIjQ?=
 =?us-ascii?Q?PMTQOFcvZzq+EGx8qcPuoa/W705eWdbdvDyGBjxxd/UuaEyYHzvXGHcM2pqG?=
 =?us-ascii?Q?tE6TCNAR9tqSyzaXoYmMqG+/E+A4zZNzVMDMmavsJG0oXVhJAHwCWdZzesOE?=
 =?us-ascii?Q?CLRvAO47x5WX/Vdoe7VAbKYhr5fkw+ioHt9DVW/fLAc1EURP6rvsgQ4jltRU?=
 =?us-ascii?Q?BG2z1PNzAZ2MDEcTiCMXgMvygSlLBxnq6Yy61uEiuD3KxqWMz80kg2cNCWAN?=
 =?us-ascii?Q?9V5q64RxyH1JBuiWHcS6C5upDoBftg0VJc+qmCsfvgcjxmcgKdg87s0nedkX?=
 =?us-ascii?Q?rpBW+lZIVZdGJAj4oo8msjv/fIeqm65dZZYc+VCpS3zT1lT0075mIJh+2fMJ?=
 =?us-ascii?Q?yTHtSgA0qQmigngamCYiLX59+UtlvQvyCnGhmIYosfywY/ZfLKZ/cUGnsJsB?=
 =?us-ascii?Q?hJdNIGZw+/4DXCArCDgxNOiFO3CckEzhHKhcUh2UuJCOOZwl5+hrf+KS4P1J?=
 =?us-ascii?Q?IlFflz5V6y3CoJL/Ua/+7sPE373V+Dfixtl8L9VUlgJdCEzFmTwSxemBb1ss?=
 =?us-ascii?Q?OudKPJq60uKkjFR6hAcGF/lIKySGqyc99C2YuEkTfXoKyHs1TX2bNv49yFfK?=
 =?us-ascii?Q?BC+2+3fej+H9hkrp+3ZLAAFPr/nGKxObLpvPIJpiPxd+12KrxTq5SW7uRzlr?=
 =?us-ascii?Q?fXk02QTD9M33AtbnL6h0/mcCuI8duvhhSCQmmjRmOakOShBYt9gE8LLTys4M?=
 =?us-ascii?Q?80Ha3BEZitNwNYeU8X6kxbFoXl45c1rW88T0ShBERQWC7eLoZkhqoHYQZ01M?=
 =?us-ascii?Q?pu9UjWZpYHrui+XbTMI01Ox1gZ+qTJQmUmswKeCDad98Tpe+BCdzGUN5CCsG?=
 =?us-ascii?Q?razhx2IEhlMp99R84gVMHuqY8RRdiIMHocn+y9UMxlk2c42EZ059ntmD8gw5?=
 =?us-ascii?Q?zMQucwwD4BCkbqJZuuyNvFrdXzmI1X3VoSV9MOLUrxzrafrPsX7Gzz4bFaYX?=
 =?us-ascii?Q?RLxW1q1Gwvyg2l6aBAD5Ao5+UINfA0obkH3SO0Ky+oCnZ+6dFGUz4nJhcIgT?=
 =?us-ascii?Q?VfXbKMluOGdl9OQnsIvPTvuu48hNEcR29/8jhwZfIY8ZNWk8mdnpgBVKDP2N?=
 =?us-ascii?Q?YwpKO4Lm+hEGYsdxRNbIPHOXwA+e7alEy+FnTn1D7XoNuD5REBhljF3SwLpF?=
 =?us-ascii?Q?eTD0JUcNWFBuN2bcHJpHgcamWNv1xSNjPaSseZ8ByHHmflpvioy8TDuvv4mL?=
 =?us-ascii?Q?iiqMMVHIfcdOEynXY8qfXNoe/4mBLyOtAZ8R+f7afaNiOc8TAP73kLgx6FjR?=
 =?us-ascii?Q?iVsnCCJRq2FhXB5OM1f+HQEIi4OVrF2r/UIojb0Qu3YihotwtFR0O+YPb2Fq?=
 =?us-ascii?Q?H+3TZJ7Z6Rikp8Zosu+u8RjUNmV+xamzX+g3TdAz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 42e66841-5eb6-4ab6-b4ef-08dc4f9582f0
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 02:11:14.6772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9JbG0YPM5cJPMVvf6ilys3aBvfSCn7ZjZlnxwGtgYiu+lq2KDJyaaZ2t1cntoFBqNNXq69DXReXxKdOKgA9MaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4611
X-OriginatorOrg: intel.com

>+static void vt_set_nmi_mask(struct kvm_vcpu *vcpu, bool masked)
>+{
>+	if (is_td_vcpu(vcpu))
>+		return;
>+
>+	vmx_set_nmi_mask(vcpu, masked);
>+}
>+
>+static void vt_enable_nmi_window(struct kvm_vcpu *vcpu)
>+{
>+	/* Refer the comment in vt_get_nmi_mask(). */
>+	if (is_td_vcpu(vcpu))
>+		return;
>+
>+	vmx_enable_nmi_window(vcpu);
>+}

The two actually request something to do done for the TD. But we make them nop
as TDX module doesn't support VMM to configure nmi mask and nmi window. Do you
think they are worth a WARN_ON_ONCE()? or adding WARN_ON_ONCE() requires a lot
of code factoring in KVM's NMI injection logics?