Received-SPF: pass (google.com: domain of linux-kernel+bounces-124069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 29 Mar 2024 10:55:01 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>, Sean Christopherson
	<sean.j.christopherson@intel.com>
Subject: Re: [PATCH v19 095/130] KVM: VMX: Modify NMI and INTR handlers to
 take intr_info as function argument
Message-ID: <ZgYthRHalTwRm6AT@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <c7ea98e64cee7458e1a09d5aa3fddd1e1f83629f.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c7ea98e64cee7458e1a09d5aa3fddd1e1f83629f.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lgz8XXsbciGZTrbSJnh423gI82JmYTR3migAfY5mkCkCXL3h/OPCsKnOLNVy?=
 =?us-ascii?Q?ZLiZ0v0EhI+EaxQt/JjqMeWPaLRHS4AX3KJQwDM9VaggmDo/P17V1I7nqwM3?=
 =?us-ascii?Q?jU5R3zN0n2Jjytn+OgZJZI6CaONTfCl1cnlqHL0iXdm9OdE7rCYIQEZTmGgf?=
 =?us-ascii?Q?gJKwdBKj3wLvA5pBtGnzTolbjN7HV8efAgBpqYsTWrcNGLHpMZq782n6HylW?=
 =?us-ascii?Q?c8oh8ZL2oG5EkW4aDSjvlvABKNo6wzugiccODgN92qje1uK8Zdv+9285gDHa?=
 =?us-ascii?Q?H3t7v3NjAWdTlxtqTPuycnhG93X5gFM08MdYP9FuhSsQ8XLBCFj0l75bzbj8?=
 =?us-ascii?Q?3eaC1j3uVTaRJXcHJWC0Css7hLqCIMdGMUOlBO3filxxBm8O5KogWl3ToKJd?=
 =?us-ascii?Q?7vMPgXFWbn4x9iHdLbkXPjmsupsL99mjxve6cCYmbeIp7755AcbsaBbNHWVa?=
 =?us-ascii?Q?cD9uE1JL9tzLLeV1HfyVkUW8QzNvBLSD+jw1XALX6zYHkFc0QJdtBmsG+HzW?=
 =?us-ascii?Q?EWQhZutr7YiH0QmMp27memq1z/pvkARH3AEibeXAaSmbddMR08wj5p4dKoDd?=
 =?us-ascii?Q?+1q341LK32yPotCJdoQQfroaBof0nD0rXc+QkRlbshxtoc3UMgfpKEk6OpIe?=
 =?us-ascii?Q?HRudODA/XxlJAVrVZ69FbWZd/AoLayD3VSoHPUQpyjQDk4cWZALyupy2lWIJ?=
 =?us-ascii?Q?aICTXYaXn4tq9yc4z5WBsJPViijhnaEhHQeGEuvHL2pgHRm3O9yFk3iTWMce?=
 =?us-ascii?Q?BIoDf35qC94oBfNYwtrpvT1yMVOs+NPWhBzI1kn507FMQ11Er+CKzTRC4StB?=
 =?us-ascii?Q?DiCRQiiXKlltWzcLtFyn89+LimL9OXs12pxN6vwcLj51cEDBKRTjHreOVQXq?=
 =?us-ascii?Q?mofXtccrBPKPPrFm4BBhJxyA3WJncdmCZ8pswWCK5s7anHMY/09QXAm9wndi?=
 =?us-ascii?Q?PxU0D+ZS/iN5Q68nu2BSvY6zCZDaVIs90P+GGKJsWajTakiXhrOpV5EhSl8T?=
 =?us-ascii?Q?edEf1WVdMTYzc2njhxMX0++wzt4CQgk+pMwnr/XQHX1s8N0/5NGwL4P/rIi1?=
 =?us-ascii?Q?VTJhXfWzx3UkEt7aZHjYZwTYcbVpwpSSNnvbfEH3NxOgFQY0PYczjxJWE0Gx?=
 =?us-ascii?Q?pbasnWZUnzIESCNXNWbKLcb7us3LdlIvjZXSN5UhBzWr1aHUdBQjA9DfT8pU?=
 =?us-ascii?Q?nCilO7P8UYP0p0V1f8U+K+TmYGzg6m4qgGs0cPRQSe2BBA17IGX+UkZg9HfN?=
 =?us-ascii?Q?4pIfVy3gSJ44XVskVU592iSadw4F/D7h3pP1J/H0JnCBl90TX3/TLS8CgIhe?=
 =?us-ascii?Q?Xc4gcPJ8Ep/rK28lCbnwMi1Tnky1qXNqzLcX2ltonQfp/Hp3pdm9ZRbc8RFU?=
 =?us-ascii?Q?I62ruPcLoKCC+QDhq/BlGUj7WCfFpA2W4FDU1ICczss0jyrllCHyJQ0L0a4G?=
 =?us-ascii?Q?pUUQ9iigYUlq1+EyAJs2WAr72wK9qE/Rt1XN3lFYWJ/IA2AzO6RKiNrdmRcc?=
 =?us-ascii?Q?YtLXLZt79qu44paqsl1lyHimQ52a/472pNYDZy1CpkVBFZ3JaD0NmGpZYDmE?=
 =?us-ascii?Q?V84jlHudWOHu+daO30PLrZsDMG59iemdzkcHPWQJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62d192d8-5b48-4ac9-9af0-08dc4f9ba689
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 02:55:11.3559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iXishBJpZTmklBWy8wlNBciwpJ+Qg03xLf2XyAjNiv0g32jCw5r/vXLdLsLmG0jk7qAC+/wmq5fjDP32rmgKoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7715
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:37AM -0800, isaku.yamahata@intel.com wrote:
>From: Sean Christopherson <sean.j.christopherson@intel.com>
>
>TDX uses different ABI to get information about VM exit.  Pass intr_info to
>the NMI and INTR handlers instead of pulling it from vcpu_vmx in
>preparation for sharing the bulk of the handlers with TDX.
>
>When the guest TD exits to VMM, RAX holds status and exit reason, RCX holds
>exit qualification etc rather than the VMCS fields because VMM doesn't have
>access to the VMCS.  The eventual code will be
>
>VMX:
>  - get exit reason, intr_info, exit_qualification, and etc from VMCS
>  - call NMI/INTR handlers (common code)
>
>TDX:
>  - get exit reason, intr_info, exit_qualification, and etc from guest
>    registers
>  - call NMI/INTR handlers (common code)
>
>Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>