Received-SPF: pass (google.com: domain of linux-kernel+bounces-124076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ba351ec5-21c6-3ac3-f3a3-6690c9d0682b@amd.com>
Date: Fri, 29 Mar 2024 08:46:53 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [RFC PATCH 0/1] sched/eevdf: Curb wakeup preemption further
Content-Language: en-US
To: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
 Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>,
 Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira
 <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>,
 linux-kernel@vger.kernel.org, Tobias Huschle <huschle@linux.ibm.com>,
 Luis Machado <luis.machado@arm.com>, Chen Yu <yu.c.chen@intel.com>,
 Abel Wu <wuyun.abel@bytedance.com>, Tianchen Ding
 <dtcccc@linux.alibaba.com>, Youssef Esmat <youssefesmat@chromium.org>,
 Xuewen Yan <xuewen.yan94@gmail.com>,
 "Gautham R. Shenoy" <gautham.shenoy@amd.com>, Ingo Molnar
 <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
 Juri Lelli <juri.lelli@redhat.com>,
 Vincent Guittot <vincent.guittot@linaro.org>,
 20240325060226.1540-1-kprateek.nayak@amd.com
References: <20240325060226.1540-1-kprateek.nayak@amd.com>
 <8bce19b2-37d9-4722-ba83-0088a4c9fc6a@linux.ibm.com>
From: K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <8bce19b2-37d9-4722-ba83-0088a4c9fc6a@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V0k5eU9kLytwTmNsME8xWnZqWW11OGhkZjV2V2pvWnhyTkI5aDZLUlZGaHU5?=
 =?utf-8?B?NW9KZVdDdXNmdENhdk1WbDJsY3Q3MmxtaVE5bmUvREFkMTRHc3ZETUhGOHdR?=
 =?utf-8?B?VzJBazVuMWRWeGJsTVpZZlliOUQ2UGs3M1g4bE8yUjRRWG9IcXBwTlAyVmhT?=
 =?utf-8?B?bDYzYkpGb1UxZ0xjL0VTUGlVM1RRN0pGR05BVWx3Q25DcFZ1VXd1bVcxS0x0?=
 =?utf-8?B?OVR1UVFodVJRbjd2ZEEwZTZCRXZ3cTk2STBQS1FtcjFsMytGbmJXemdUMjky?=
 =?utf-8?B?UkxBdHFXcjdPT2dhZUM5ZGJxNWpJWk8vUHNQdTh1QXFtT0l2bFBEc3lBMW9F?=
 =?utf-8?B?QmJSNU9MYTlYajdFa2lKY1Y5TTYzbXNMbm5CSmdueGt2RlBWQmgwdjNaZzk1?=
 =?utf-8?B?eGlmUnVYUXBIY0FHalVBdXM5OFVidW1PWUJIMllyTThtZzgwd2NZQlZhU1JV?=
 =?utf-8?B?ZE9VdkZQTlE2bko0WXgrZHRmOHpIVWxHWG0rL0Jhbkt6aStaK3kvbytDRkZT?=
 =?utf-8?B?K01GaGwzWERLSHlIYzhpbjJGRFBMVDJ1emZpRXR2cE1FdFhaS0VzNExvOHRR?=
 =?utf-8?B?dW1YN2xrSXQ1ckhwMlI3R1VJVFZadkZCVUt3SGU5RzNrRkhvSHp6WHRRMk0v?=
 =?utf-8?B?RXN3OVpQYTNkR3RJUUVxeUN2a0I2UElIaWRJdmdrd29ST0FMMnZvK2xvcXhw?=
 =?utf-8?B?RVo0SHdUMlgzTUtaUWpvR243bCtteHhOME5rQXN4WVREaFdZWmxDWGtmR2Rz?=
 =?utf-8?B?NDJVc0pXY3FmY1VqWUVJYXhRSmVnR1l2ekFNZlNsU1M0NWUzSEtGTEJBOWNx?=
 =?utf-8?B?UXNlWE1vbklkMVF6WHlpenBkdGtZRjU4Z1h5OFppVFBJK04wUWlZejU3UVNY?=
 =?utf-8?B?NTNFaEI3SzM5K3l4ZmtCSURFbHhDSXFlZkNWUFBsdkRZVG5Wekg1aTN5eE9h?=
 =?utf-8?B?RXlHRzNsNjNuN2Q0ekRnbnNjVWRpMzNaSzNtYjEzTElNMVRLaGIzLzVxZEZI?=
 =?utf-8?B?OENUbzBsN0w4NjAvYStYZ3JHck1HZ3FlUkVGMnJ5MVcrOXQ3VlFRUno5eGpm?=
 =?utf-8?B?ZTJXUUIvVU1rdjdYbTl0djJFVUU1OXlxeUFRZHZQL0wzc3phT0hrUWIvemJ3?=
 =?utf-8?B?bUQyeThoZkhYS3JuMjNvZHNxZVEwc1BuZmozbmV1Zlp3TzZKMDAwYUsyNUFJ?=
 =?utf-8?B?VGZUK3lid1QxYkFSUm5NOFhxKy9FeWFTNm9kb3FJNDQ4TlNiY0hsdW1HN0ZB?=
 =?utf-8?B?QmpwS0RsWENoMGxSY1pFOG1sSkF3ZWhkK2NJUzkvay9YbjdPVXgySTVJcVlG?=
 =?utf-8?B?MDc0Qmorenl3eVJkVjVKaE55aVVWd0hYTmtETmdWeG9sLzJndGhTVE5jT0FP?=
 =?utf-8?B?NlFvNlQwRkUzNE1GSlpCbXBnZ05mOHNJLzEwQ1BwV2lPRHpyT1FNajk2WWEz?=
 =?utf-8?B?c25pWkJwVTRISzlJb3hmVnRINHI2U1RVTnhibFlsTEYyQWZHTllad0g4N3Q5?=
 =?utf-8?B?TzZvQnpNZGI2eEFORG91TDdYd0RzOE1EM1BEeVQ0clB3SFQzZmg1dnU3YTVX?=
 =?utf-8?B?c1J6U25oTFFxUjZUZmJnK0VzWjBmRDhzMGNWcUVEM2ZlMWt5SXZaam5jV1Vh?=
 =?utf-8?B?NWpDM3VhMVZwSVI1UTJOaXNlTitYNmltSHo3WXJuL2F3bmlFR2YxeW9MWndy?=
 =?utf-8?B?eDd1NHB4OHFXT0dYOXlOOG41NEhSM3YrVjlMRENkb0kwbFNxSVRFQnp5Uzds?=
 =?utf-8?B?OE0vTU1zWFFhekFYcHdtU28rMWtsZzFSMFRub3BJWDgxTENWSkIvazBqL3RB?=
 =?utf-8?B?K0JxalJhWmJqcWZuMmM5WGZyclBNeDRjQlhYSmlUc2VDQUM0dU9ZaGlpWXRK?=
 =?utf-8?B?MXVzVTlqS1R4cHRlNlVhdlVOTXpnUEZVUi9EaGtkTjFGb3UyU3dSWkNaMGE2?=
 =?utf-8?B?TG5SalVCUXgyV3haNmpBWWd4ZnBlajNCVXlPWnBXbHV1cG5ic0kzOUtCekY0?=
 =?utf-8?B?a0R2RXZSeXFqRnBnbmVPdmo1UUJPTmFTblFWaFNNS0pXZmUyMVh0bC93VjFr?=
 =?utf-8?B?UDNZT2dveURmOXhoMFFMSjNDZjdUVnhYd2pnTmp5S3hyRUhJbGhiak9uV2JW?=
 =?utf-8?Q?qy9uExQbMWNq35lPMCjch84AM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5e58e3-23a2-4415-8541-08dc4f9eb522
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 03:17:04.5196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 75CqQhbV9oE6EA2bYPhl3/V4oVNTv7GRABFCel+KefQoDgx/2EIAPFIWtIYdXAaaX1SAjMKz8DMgfJaBlHQAXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5655

On 3/28/2024 3:56 PM, Madadi Vineeth Reddy wrote:
> Hi Prateek,
> 
> On 25/03/24 11:32, K Prateek Nayak wrote:
>> Wakeup preemption problem
>> =========================
>>
>> With the curr entity's eligibility check, a wakeup preemption is very
>> likely when an entity with positive lag joins the runqueue pushing the
>> avg_vruntime of the runqueue backwards, making the vruntime of the
>> current entity ineligible. This leads to aggressive wakeup preemption
>> which was previously guarded by wakeup_granularity_ns in legacy CFS.
> 
> Is base_slice_ns not guarding it in EEVDF?

"base_slice_ns" guards it in some sense since lag clamping is based on
the entity's slice but the problem is the eligibility criteria which is
purely based on rq's avg_vruntime and entity's vruntime. Previously
"wakeup_granularity_ns" would have added a buffer before preempting the
current task soon into its run but this is no longer the case with EEVDF
especially if new entities join the runqueue with positive lag pulling
the avg_vruntime backwards.

Please do correct me if I've missed something.

> 
>> Below figure depicts one such aggressive preemption scenario with EEVDF:
> 
> Thanks and Regards
> Madadi Vineeth Reddy

--
Thanks and Regards,
Prateek