Received-SPF: pass (google.com: domain of linux-kernel+bounces-124083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 29 Mar 2024 11:24:55 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>, Sean Christopherson
	<sean.j.christopherson@intel.com>
Subject: Re: [PATCH v19 097/130] KVM: x86: Split core of hypercall emulation
 to helper function
Message-ID: <ZgY0hy6Io72yZ9dF@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <d6547bd0c1eccdfb4a4908e330cc56ad39535f5e.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d6547bd0c1eccdfb4a4908e330cc56ad39535f5e.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iMX9Wuqx5Zs2tPy825weMjD607neOLtgkcpdQykztrn90AD1tTmDahdR5ni+?=
 =?us-ascii?Q?8EZoUMpxAjAOR2KaadZC8wp6WLkQlj7uSlW77zaBz4MthtkXhTqxtROYgLyH?=
 =?us-ascii?Q?9/OZATdlpfdQjbwBUdrE4GE1qx/C9ptIa4p2FDzsqZ2jYfmUrqMaM0tEmGZ8?=
 =?us-ascii?Q?2Yz9TlRg6VZCP0JLkgYVeie8DCv2Je0VrGwSqfkcMMw7wiYBxki/mq0rzszm?=
 =?us-ascii?Q?0Y1wJtg+OBTmiOIeqQIxPFlLEq76OYkNxdw/F7tzk29HiWUlCPzxvbaOqRU6?=
 =?us-ascii?Q?npB+5jxF6DwWd0YDr6iTNmFIJkyDTd0qvP8z1h7StMnRSpqdk+hvaJ3NhD3k?=
 =?us-ascii?Q?mwX0/cnI9zBr6buLc3OBQ2yV77A/66TVyffBJ8s4S34b48jtqs2kjG4Gjjnc?=
 =?us-ascii?Q?g3H688pXMPSmYDA7mA5U2anNcIXMEvc8XfswveY3KXMVQVf23Fl3lh1wDhdS?=
 =?us-ascii?Q?JGtiSHQNuxVOW1sorCpIqOyMVi0XJq7/1ypgHa9I44oZgUB1U1rTnrjIxlDM?=
 =?us-ascii?Q?Kblp6/SlGRabAOo5SV61pxu1h2FG7iiRBdZtpJFJ/1E2h1sCAf/5TevOUFvx?=
 =?us-ascii?Q?PYbUsH3QZLXx6GbCVseOjoULtRlWqTk4H+DRGKLn5c/joP6DkDw1Z5hj8kTz?=
 =?us-ascii?Q?J2uY5FLd9ibXPNXyDybdVIa5x/6FrJvHgBSpcgkZcqKqW4/yrC/M+q6/vXqL?=
 =?us-ascii?Q?43HiA0scBND81Jo38vd0AGbJICqGnkTdaFmCAKw5seIaI5s2Tf3d1aLJmAkX?=
 =?us-ascii?Q?RSlJXp8FoY1FlWCxFY6Fep5+A8JOYthPgjnON7If8rqRYNj8clviNQ+ASz4I?=
 =?us-ascii?Q?YMnEiCxJzTMRFyzhQ6iu4bVJNmz6ZCoS9Zuhwcm9NaLtINKTuFpA5B+Gjoxe?=
 =?us-ascii?Q?Fw6qzSpOpHKScyfsRG39L+KqmlC/b3bje1yVn2pxc6la/rxi1Hccnas8RN+V?=
 =?us-ascii?Q?4/9UlFQgg92O3IFUZYk9sRWJmcWXGVu5eYcBgfrIjUESFsb/RdsEcccNVdm6?=
 =?us-ascii?Q?7qVvHBK1NBh+j/JoYXPRc3CqjyJDIuoDvfhAsqssJzu8Gb2BARdGyzyxboOb?=
 =?us-ascii?Q?jFvmpKuMXWEF9zrRlrI1ycjtmM8Es4X55g0EhJchTVlT14gUk/b5Noha8qRy?=
 =?us-ascii?Q?A5ExeQmb/A4HdGWVkyTJwzBaoigpdecuEhlvUj4JNnFWzbkEZl8KcUwBesuD?=
 =?us-ascii?Q?Z3TGhHlwtOYudz+P+8rOtFsadF0Pcu7N7sTwe20XCFnZ43uxGMmrsPvsA37C?=
 =?us-ascii?Q?WEYhnfyG+wzPfRUK36B5vkoT2BuTziCAhR6RgUcSLnVZaQ2HjR94p4XA45qZ?=
 =?us-ascii?Q?JNTjnncyvXt9jy3gWKdAQ1ZivCdmkLQuf+ypUtHifmnjRBmSzp29dFuqfo8t?=
 =?us-ascii?Q?nQewa475eOb9qso5cThi4g9qpyihLDD189dvVps/9i5Fvidh69ecKRTMfVNU?=
 =?us-ascii?Q?SjjWNeZsm5F4TZqzQOG0APibVpVjb7xtDrSQRczXgPN7mecf+rKIxaCqfMmC?=
 =?us-ascii?Q?zKOf4llxMTHQgte8EJD1A7D6YyOMP7R1SESFP5GijjFzDupcyZ0aQGBicDts?=
 =?us-ascii?Q?eFoR9Mz3aHufTet9gkcEAMfvZMKiPPQ0KktkhHmp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 74d3aa9e-f07a-4598-c6e3-08dc4f9fd394
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 03:25:04.9020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1QQw5BhmpvY92i/mRtPpEhlI6tN332Q44kqTZ1Y8jaWGxV3xE5SY25mwrsq25n9VwhRFbLmnfsGvG/0OdZbDwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7711
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:39AM -0800, isaku.yamahata@intel.com wrote:
>@@ -10162,18 +10151,49 @@ int kvm_emulate_hypercall(struct kvm_vcpu *vcpu)
> 
> 		WARN_ON_ONCE(vcpu->run->hypercall.flags & KVM_EXIT_HYPERCALL_MBZ);
> 		vcpu->arch.complete_userspace_io = complete_hypercall_exit;
>+		/* stat is incremented on completion. */

Perhaps we could use a distinct return value to signal that the request is redirected
to userspace. This way, more cases can be supported, e.g., accesses to MTRR
MSRs, requests to service TDs, etc. And then ...

> 		return 0;
> 	}
> 	default:
> 		ret = -KVM_ENOSYS;
> 		break;
> 	}
>+
> out:
>+	++vcpu->stat.hypercalls;
>+	return ret;
>+}
>+EXPORT_SYMBOL_GPL(__kvm_emulate_hypercall);
>+
>+int kvm_emulate_hypercall(struct kvm_vcpu *vcpu)
>+{
>+	unsigned long nr, a0, a1, a2, a3, ret;
>+	int op_64_bit;
>+	int cpl;
>+
>+	if (kvm_xen_hypercall_enabled(vcpu->kvm))
>+		return kvm_xen_hypercall(vcpu);
>+
>+	if (kvm_hv_hypercall_enabled(vcpu))
>+		return kvm_hv_hypercall(vcpu);
>+
>+	nr = kvm_rax_read(vcpu);
>+	a0 = kvm_rbx_read(vcpu);
>+	a1 = kvm_rcx_read(vcpu);
>+	a2 = kvm_rdx_read(vcpu);
>+	a3 = kvm_rsi_read(vcpu);
>+	op_64_bit = is_64_bit_hypercall(vcpu);
>+	cpl = static_call(kvm_x86_get_cpl)(vcpu);
>+
>+	ret = __kvm_emulate_hypercall(vcpu, nr, a0, a1, a2, a3, op_64_bit, cpl);
>+	if (nr == KVM_HC_MAP_GPA_RANGE && !ret)
>+		/* MAP_GPA tosses the request to the user space. */

no need to check what the request is. Just checking the return value will suffice.

>+		return 0;
>+
> 	if (!op_64_bit)
> 		ret = (u32)ret;
> 	kvm_rax_write(vcpu, ret);
> 
>-	++vcpu->stat.hypercalls;
> 	return kvm_skip_emulated_instruction(vcpu);
> }
> EXPORT_SYMBOL_GPL(kvm_emulate_hypercall);
>-- 
>2.25.1
>
>