Received-SPF: pass (google.com: domain of linux-kernel+bounces-124110-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 29 Mar 2024 00:18:39 -0400
From: Frank Li <Frank.li@nxp.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: vkoul@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, shengjiu.wang@gmail.com,
	linux-imx@nxp.com, dmaengine@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] dmaengine: imx-sdma: support dual fifo for
 DEV_TO_DEV
Message-ID: <ZgZBH/HsO8YmgFZx@lizhi-Precision-Tower-5810>
References: <1711682887-15676-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1711682887-15676-1-git-send-email-shengjiu.wang@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RypH2/UfRlD/dpMgkdP9lYd/wj6YZx17R0ZZu5/eCzUtagsdkC2v4h5eUj+a?=
 =?us-ascii?Q?DL1Cg7cNQeNMxGNkwG4azoj9oXdg6Lw0MVCAbWEGKJmItDP9g9Hv0TCtY0hs?=
 =?us-ascii?Q?JO630DFRBTt9+KAbf8h8e4aiDi57EPKSP2BIg+8t1Wz0cNmvCBu/4epIDSab?=
 =?us-ascii?Q?nCNNaO+lE0AOh+7xWnaC0+m/CkZK6Mb1fdpBaVpwpRASmY8njNlGNBQcsEed?=
 =?us-ascii?Q?KEn72l9maFkgk5Yx0MJ4zsD6dbvziesxyhLGT0K82Ulc9QlT+xWIQDmtmvgV?=
 =?us-ascii?Q?TJW4JNbDz/YOA3A8ryPRIeLbruR4BcpIg1i0SyZi6FXr+HN4sw1yF3gz1Jzl?=
 =?us-ascii?Q?PIIbZLdCHifIxbeZFoPrSzapKUNUB5qefKyat3SEMethB0pbcmrUnB0Zdloi?=
 =?us-ascii?Q?FCGlpCBGzfJafPHzYOHOfYEACE0/2g+5PH8NqcimEzY9Kcml0t+dtijzJ/hL?=
 =?us-ascii?Q?EfHPmd9b0iV3+Y9gh08jm+oqxgGBSpfavFtbKZMEtmX1rm0lBzp2vw5IYvn/?=
 =?us-ascii?Q?e8QsYkDNFFlJiNUwR4z7jftlG913flVRxi4LnocGrHSXmY62UkQmc1EzZuRR?=
 =?us-ascii?Q?qgTPJrwjb/bexN6iPIdUSJoJ9TxMhW/kyMmwimSD9XNYqTHNq9vDXseQ5SVG?=
 =?us-ascii?Q?nlQyZImYLPzfkG06lDbR+96bAnnku9X/+zEb/0S2z6c1EzRb7Vb+QAzt3MF8?=
 =?us-ascii?Q?vio+TS3/VwVkI7o85bxkSqajhYqH8IQyOIUCUJsEWbbAMONUx1Wnm7rjnAzT?=
 =?us-ascii?Q?QeO6cRfYJW/wp3wZ6G2HIm+Edrv1CwUBKXPPyY56YBm+gqub55qqpWig/NqB?=
 =?us-ascii?Q?vwVnos+YFHjDrGuPhFCgNDLVAg4QZVSFJC4xtw2rmqV8/EHQFdq7RJQ9dxMx?=
 =?us-ascii?Q?KqW5r6hvz7myQI94F4xkiX1DwWhDp2u0K1dHdrGruO+hvfNXJIeztqopWyjq?=
 =?us-ascii?Q?XKaFQhrtmJ8HiWWjjoHN45Toh8XYgt3oFyemGoQ7kHwPIj4becnJt4XFjM/j?=
 =?us-ascii?Q?jxkY+klqCY6Q3ne9vpD2kEwO3zVsCBgWMVDoVADMSyjihwBDkCejAuPUFQG1?=
 =?us-ascii?Q?zAMxPmhBnP9KUo6HHaoDW8i7sAvAZQSr1RYJEPk15uSfmV03jhDz+83U3DGA?=
 =?us-ascii?Q?9rwIj4M7f6EYDZn/bIwHfuQEWI6bHeMA2O4CDEtdkkP2R4TEGbpZeM1SYOFQ?=
 =?us-ascii?Q?LaC0j+wXAqG2wSBjnh8SlPvgjMiGqyIOXUc41WH0kUJ0KuI59AfDoK1NrD9Z?=
 =?us-ascii?Q?p13ZfBtH4WBMOIay6q1cDqMiNAR0OHbmaff/mIgODwUuR1tD6Pf9SavJlPt2?=
 =?us-ascii?Q?wgJiaZRjrB/L7gcBYduzv11kR6wfncu5VQWio85wp5Kdi7HPuChWR/u6nqQo?=
 =?us-ascii?Q?z8hkw+tkWp42vqQQxcLZJ6ZSlc01Hcp84PKSqzBhzhxT4OM5QoT7WQfAwosL?=
 =?us-ascii?Q?lgyZSHjTcauDZTmcpQw3ft1SABaqYMw7NIa+SIE1/tYQm18BWXurBdyOaUFg?=
 =?us-ascii?Q?mcMTarrgpcMQv7DJMWU6Vi7jguu8nbv8fAWpXjiU96iw3JbR/EWirImrD6i9?=
 =?us-ascii?Q?wtPQ6kjfO1hgzAqDkm8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9dc0d47-baba-42ed-6ef2-08dc4fa7555e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 04:18:49.1423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +3ObqK+bS7N1wDPgHwklvqy3ATCewL40EXwXG0icLzgOgPMw/CDz1of0Yb2sVe03FBiXoDLJme/AT+zDz70rig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7813

On Fri, Mar 29, 2024 at 11:28:07AM +0800, Shengjiu Wang wrote:
> SSI and SPDIF are dual fifo interface, when support ASRC P2P
> with SSI and SPDIF, the src fifo or dst fifo number can be
> two.
> 
> The p2p watermark level bit 13 and 14 are designed for
> these use case. This patch is to complete this function
> in driver.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> Acked-by: Iuliana Prodan <iuliana.prodan@nxp.com>

This already in my sdma improvement patch list.

https://lore.kernel.org/imx/20240318-sdma_upstream-v3-0-da37ddd44d49@nxp.com/T/#m59e4e03a527103de7bf1a7fe86e8fbc570454970

This have more nice commit message. Can I take one into my patch series to
avoid conflict. 

Frank

> ---
>  drivers/dma/imx-sdma.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 9b42f5e96b1e..079e6e8f4f59 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -137,7 +137,11 @@
>   *						0: Source on AIPS
>   *	12		Destination Bit(DP)	1: Destination on SPBA
>   *						0: Destination on AIPS
> - *	13-15		---------		MUST BE 0
> + *	13		Source FIFO		1: Source is dual FIFO
> + *						0: Source is single FIFO
> + *	14		Destination FIFO	1: Destination is dual FIFO
> + *						0: Destination is single FIFO
> + *	15		---------		MUST BE 0
>   *	16-23		Higher WML		HWML
>   *	24-27		N			Total number of samples after
>   *						which Pad adding/Swallowing
> @@ -168,6 +172,8 @@
>  #define SDMA_WATERMARK_LEVEL_SPDIF	BIT(10)
>  #define SDMA_WATERMARK_LEVEL_SP		BIT(11)
>  #define SDMA_WATERMARK_LEVEL_DP		BIT(12)
> +#define SDMA_WATERMARK_LEVEL_SD		BIT(13)
> +#define SDMA_WATERMARK_LEVEL_DD		BIT(14)
>  #define SDMA_WATERMARK_LEVEL_HWML	(0xFF << 16)
>  #define SDMA_WATERMARK_LEVEL_LWE	BIT(28)
>  #define SDMA_WATERMARK_LEVEL_HWE	BIT(29)
> @@ -1255,6 +1261,16 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac)
>  		sdmac->watermark_level |= SDMA_WATERMARK_LEVEL_DP;
>  
>  	sdmac->watermark_level |= SDMA_WATERMARK_LEVEL_CONT;
> +
> +	/*
> +	 * Limitation: The p2p script support dual fifos in maximum,
> +	 * So when fifo number is larger than 1, force enable dual
> +	 * fifos.
> +	 */
> +	if (sdmac->n_fifos_src > 1)
> +		sdmac->watermark_level |= SDMA_WATERMARK_LEVEL_SD;
> +	if (sdmac->n_fifos_dst > 1)
> +		sdmac->watermark_level |= SDMA_WATERMARK_LEVEL_DD;
>  }
>  
>  static void sdma_set_watermarklevel_for_sais(struct sdma_channel *sdmac)
> -- 
> 2.34.1
>