Received-SPF: pass (google.com: domain of linux-kernel+bounces-124147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <629a2983-8db4-4ae0-8f68-72750985d5b3@quicinc.com>
Date: Fri, 29 Mar 2024 10:22:47 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc: qcom: cmd-db: map shared memory as WT, not WB
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Caleb Connolly <caleb.connolly@linaro.org>,
        "andersson@kernel.org >> Bjorn
 Andersson" <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        LKML
	<linux-kernel@vger.kernel.org>
References: <20240327200917.2576034-1-volodymyr_babchuk@epam.com>
 <19bb6ff0-04ff-4e88-8c8a-499c054bdea4@quicinc.com> <87sf0axanc.fsf@epam.com>
Content-Language: en-US
From: "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com>
In-Reply-To: <87sf0axanc.fsf@epam.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/29/2024 3:49 AM, Volodymyr Babchuk wrote:
> 
> Hi Maulik
> 
> "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com> writes:
> 
>> On 3/28/2024 1:39 AM, Volodymyr Babchuk wrote:
>>> It appears that hardware does not like cacheable accesses to this
>>> region. Trying to access this shared memory region as Normal Memory
>>> leads to secure interrupt which causes an endless loop somewhere in
>>> Trust Zone.
>>
>> Linux does not write into cmd-db region. This region is write
>> protected by XPU. Making this region uncached magically solves the XPU
>> write fault
>> issue.
>>
>> Can you please include above details?
> 
> Sure, I'll add this to the next version.
> 

Thanks.

>>
>> In downstream, we have below which resolved similar issue on qcm6490.
>>
>> cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WC);
>>
>> Downstream SA8155P also have MEMREMAP_WC. Can you please give it a try
>> on your device?
> 
> Yes, MEMREMAP_WC works as well. This opens the question: which type is
> more correct? I have no deep understanding in QCOM internals so it is
> hard to me to answer this question.
> 

XPU may have falsely detected clean cache eviction as "write" into the 
write protected region so using uncached flag MEMREMAP_WC may be helping 
here and is more correct in my understanding.

This can also be included in commit message.

Thanks,
Maulik