Received-SPF: pass (google.com: domain of linux-kernel+bounces-124149-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <91c0b375-55db-434e-aa3a-7ead0d714d40@intel.com>
Date: Thu, 28 Mar 2024 21:55:21 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 0/2] x86/resctrl: Pass domain to target CPU
To: Borislav Petkov <bp@alien8.de>
CC: Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, "Yu, Fenghua" <fenghua.yu@intel.com>, "Ingo
 Molnar" <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, James Morse <james.morse@arm.com>, Tony
 Luck <tony.luck@intel.com>
References: <ZdZPht8hY4J9uIOz@agluck-desk3>
 <20240308213846.77075-1-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240308213846.77075-1-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjRKbTFxaUJjOW1IcFBXYnZiTWt2Y1JrNngxSUgreTVKSCtMNEZRQkRZWUxC?=
 =?utf-8?B?UGFRUVN0QXdVSUI3MDQrdmNXVlVobnVzZy9PSmUreFJZZ1d3S0ZSOFBJNkJ0?=
 =?utf-8?B?NUU5U3ZGM2orczhBaVJLS0ZjSVBMV3FMZkZ2Wnl5b2w3OElFNG9WQTNUeXJU?=
 =?utf-8?B?U20xaGozNVZUckJVL2x1NUM0K3JnNFNhK1dSbHBxRXJvUnpqRnJ4dGMyRVhM?=
 =?utf-8?B?NE53K0ZCWWZQTnoyOGx4SkZTaGdQeFgxbGNFTjN1Y000d1NUY0FoSUJxNVI1?=
 =?utf-8?B?dUtxa1Z4VmY3czFwelg1cHJuYm1Ia0pWNVgrcFVWbS9JeHV3SEdMUlVlRUpx?=
 =?utf-8?B?akk2cjlnWUNnUzRteXBXSUJXT1VRajlpUDM5eFFWRDFVSzdrYUFObitEcXRw?=
 =?utf-8?B?VERXangrOUtaMk9sQWhGYlhlcnoyc21tcFlXQjl6ajk1U0RmS3BBckozUmVP?=
 =?utf-8?B?dGkvR3I4Ykcyc2VGTDZyS3lpdHUrc0p3UGRPeE9zT0xURHR5MW9CQkhsWVlK?=
 =?utf-8?B?R3hvTzVPT0Qyc25FVUwwZ1dhRmVSUGkrZEhWcVhEaGRQMzI1cEF1MjNNQXBM?=
 =?utf-8?B?eGFOYys5UHliVi91Uys3WFVuMGoxbnRuUnFzTU9hU0hDbUhocmtQdmx5aWp1?=
 =?utf-8?B?R1dDd0J0NFM4T0o1YW5oLzg0TDZLUjBTdVBTSUxaQ21WZUZrV2R5YkczZjc1?=
 =?utf-8?B?RUNpV2VobXF6VS9YT1N6c25BR0d4aFFqL1JBS2JPSHFtVW1zVEJadEdpU21T?=
 =?utf-8?B?WWZxOWhqbWJTQUUycHlEbHRHZWkrbFRQZFIya3RVaGhDb2hwREVBWlhwNVRS?=
 =?utf-8?B?aXBHSEp2eU9kaGxwMkpnN3NkZUNoR0NlU05BZEdVQ1gyY3RDb1ZZM0VaVmVt?=
 =?utf-8?B?WmNmZHRQQmwzdkhJZUhzeVJvRlZva2ZnNWMxR0JaWTFaNHRwR3BHT0EzaUJp?=
 =?utf-8?B?NERRREdyQ2MzMWxiMEZNR3ZQYStFamhyVWZ6dVZMVERuVlhTWC9WWnhJZCtC?=
 =?utf-8?B?TURQVDlvY1ZaQkJFZXlsb295U2NjekF0b3d2YWE4U0pPWVR5Rkptc3JMRy9W?=
 =?utf-8?B?RGdsTCtmRnRPTy9DV3VKdG1abGRiSzBRN2NJM1FPejBqQ0pTZmxhRCtJUXcy?=
 =?utf-8?B?Sjk3dnMzYXJhTzNDMlM3MzFXU25paG1PdDJIenNXY0x3L2FpQ0tteHZaUmIv?=
 =?utf-8?B?OU1nS01qbzFiVU5SMmZ3V3Y1czNmMFNjY25LMTBPdE9xWnk4NGVVcWxxcXF4?=
 =?utf-8?B?RGlDTWRUNGF0bjVxNUxKS2hHZlRzZHNPd05WU3ZDRk1hK1VkbFhpNVRYMjB3?=
 =?utf-8?B?NmNoTWlBSHE3ZVUwOVk5am0vbVZnaTM4L1ZWbVkvSDlhSlh6ckdoTXNwTXZ0?=
 =?utf-8?B?MHA5eVFxUlUyVGVEeTNDTWN6Skt3RHl2bFovVCtYV3J3R1FwT01PbGdhaW1F?=
 =?utf-8?B?b1U0RW9YenhyMVNNVUZDdkhtbGlzbXJZcnpIK1F1NmFPWlRadUFwMVVtcWwy?=
 =?utf-8?B?U3FkWEwrWldaUTd3QzNrNTdQVy9hdXhucWpDZlEwaytrS0ZFZzhUd1dFRE1V?=
 =?utf-8?B?cGVieEZDME1tTkZsTlEwZGtYLzVJUFJyZkxOMEhUeFNrUDB2VU9ZSExCTXZy?=
 =?utf-8?B?Sk1YT1FKNDBGOVlvNTR6clZiZ0xnSjUxQnRRUmdERXNTZnh3RytIZGpIQ2hN?=
 =?utf-8?B?NEowWlFKY20wQmZ6SWNIbVptd1YvVkVCWkxreG1vSmlQcFV3THVTSkZwOFEw?=
 =?utf-8?B?TXBKWDIvVEhJVVRQRjhWU0hqS1V0Y1Ntbi9OcEZKUXZ4Z004b3dmRWFSSkV2?=
 =?utf-8?B?ellZVDdJZGlack9Ud0NHMkVtb0xRM2hyU2ZGZXZpYTI5Zm5yWENRNUJuQnhL?=
 =?utf-8?B?QnlrWUwvdTg1eGRVKzJGMlZsTnhUMzAwejhxTzZYTllCbU5QSVJmcVpCOW9F?=
 =?utf-8?B?SFpmTVlxTVdBYWpnUlh6S2w5YkN3ekhnR24ySmlPMHZhbTN4MTJGWjFpMnll?=
 =?utf-8?B?NFlrdEdWd2JyU2RjVXpnb1BVQWlsMGpyYXY4dSsvMkRwSHdTMjBzK05qTE8v?=
 =?utf-8?B?c0RseUFxZFFOcHU3Z1JWN3pOelQ3QkhmODlrYlU2VWE3K1lLRG1kMTZocUZ4?=
 =?utf-8?B?d0lmcndQMXNWMWhvSzZrQWNqSDl5eDl6bSsvckVFbFp4S1FiaU1CcmpVaXVO?=
 =?utf-8?B?L3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 136e0b86-4e59-4e7e-ca39-08dc4fac7205
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 04:55:24.7272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KUh6Gt8geNTzvtpSlDg6GvrpsL015ZSXKGNvlzRdS5QjF5Y40ELXbgZeZYIgOlm/ntjrncP9dNqW+V+h3uSNWlL3GKJbk+QNwY06TDyEtUo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6419
X-OriginatorOrg: intel.com

Hi Boris,

Could you please consider this series for inclusion?

Thank you very much.

Reinette

On 3/8/2024 1:38 PM, Tony Luck wrote:
> reset_all_ctrls() and resctrl_arch_update_domains() use on_each_cpu_mask()
> to call rdt_ctrl_update() on potentially one CPU from each domain.
> 
> But this means rdt_ctrl_update() needs to figure out which domain to
> apply changes to. Doing so requires a search of all domains in a resource,
> which can only be done safely if cpus_lock is held. Both callers do hold
> this lock, but there isn't a way for a function called on another CPU
> via IPI to verify this.
> 
> Commit c0d848fcb09d ("x86/resctrl: Remove lockdep annotation that triggers
> false positive") removed the incorrect assertions.
> 
> Add the target domain to the msr_param structure and
> call rdt_ctrl_update() for each domain separately using
> smp_call_function_single(). This means that rdt_ctrl_update() doesn't
> need to search for the domain and get_domain_from_cpu() can safely assert
> that the cpus_lock is held since the remaining callers do not use IPI.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> 
> ---
> Changes since V4: Link: https://lore.kernel.org/all/20240228193717.8170-1-tony.luck@intel.com/
> 
> Reinette: Only assign "cpu" once in resctrl_arch_update_domains() [but
> see change from James below]
> 
> James: Use smp_call_function_any() instead of cpumask_any() +
> smp_call_function_single() to avoid unnecessary IPI in both
> resctrl_arch_update_domains() and reset_all_ctrls(). This
> eliminates a need for the "cpu" local variable.
> 
> Tony Luck (2):
>   x86/resctrl: Pass domain to target CPU
>   x86/resctrl: Simplify call convention for MSR update functions
> 
>  arch/x86/kernel/cpu/resctrl/internal.h    |  5 ++-
>  arch/x86/kernel/cpu/resctrl/core.c        | 55 +++++++++--------------
>  arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 40 ++++-------------
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 12 +----
>  4 files changed, 34 insertions(+), 78 deletions(-)
> 
> 
> base-commit: c0d848fcb09d80a5f48b99f85e448185125ef59f