Received-SPF: pass (google.com: domain of linux-kernel+bounces-124204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Wu Bo <bo.wu@vivo.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
	Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Wu Bo <wubo.oduw@gmail.com>,
	Wu Bo <bo.wu@vivo.com>
Subject: [PATCH] f2fs: fix 0 addr of multi devices when dio mapping
Date: Fri, 29 Mar 2024 00:55:08 -0600
Message-Id: <20240329065508.2398202-1-bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FnHEEaAoa7+SqxWpEDZQiX1pQK7abpNOly3MySgj/gQWxQ7TuVqSq1AVrXKw?=
 =?us-ascii?Q?guEuBO4StMuOWTOmGLM+HK5yorc3ZpLicaIssOpSrgeiALq9r/8bZYgtmOGh?=
 =?us-ascii?Q?zgVnAvg6N1GLKvXWYlE8wQq48qSYiJhC/1DdAilSMGgbb11kKi9qJ5oTlXCv?=
 =?us-ascii?Q?ycCp1zV9XHYSTltkMnjHM0kYLnOn/0F7LCl3gkZQtlbuB6JgZmW67jbwI+en?=
 =?us-ascii?Q?3JfhSAAhx4cbYYQ+BuS8kaS3uinIeDb9v3Qzb3b43+oyQ2NjfzUzTt/xaCG7?=
 =?us-ascii?Q?ptf3ycJFblQU69CqloFx7Xsngx9b6tZcdLQt3SeiFgLXxDyv2Rm7Z+5Wf2Cg?=
 =?us-ascii?Q?pj2xiz/QDYNRjnIKYudfhTMO3fdaBi0MyvfbR7c1jW94WqwIQwtj9wlBZ31A?=
 =?us-ascii?Q?UfDic42H0gW2D58/okVlNOYK//utbgLwNzpcKumWquDSOR4PGK584/dNnDLF?=
 =?us-ascii?Q?cOpTPMoXb7NcW05qv837BFWQvCXUfCUF5gKrHJ/DuUTEx8pdDoZuMeSeWoHX?=
 =?us-ascii?Q?9AkzcQVLUVNDig/ydaMCWXawxKzbpS70eVjZ0k+VDHeRP4I6OjRbLiUZXDvv?=
 =?us-ascii?Q?KzWLVwMUjuV46lNULkxBHolCIL9wIW0Gjl+F0LmeZhiLF8QH4NvJTNykg6RM?=
 =?us-ascii?Q?kOLd80kbJHo8P7VB/29z4hh+PGGpa6ilWrXqCWiS7EAbAXkrsOteDY8P2T3G?=
 =?us-ascii?Q?qtGQZQf/hRfuR/OwQ0RHAGio7iDMmxA3sGGa+6O6FsUlFxc7S/T3Cf2M2HAx?=
 =?us-ascii?Q?PrDektI5HazZMwGqLrl6u5PQM7JfBJ4MI7OJ9FeHAMIIyKjLjCkg9LCgNObx?=
 =?us-ascii?Q?hUxbTSXaQwmipHqIpePIcXuPBRjWHeidDVHaYpaL2OKFE09K4xMNX0SN14rr?=
 =?us-ascii?Q?pSpNY03HZw3W0NmCLTgzudyFsbPgaNBQ8nQNM66qDNGR5IO4FzxjiWZtwaKE?=
 =?us-ascii?Q?kahfV3NaX82u1G29tpskXQjyaEs1xUNQANqoFWh/TjRdtpY/0GVt49P1bXCq?=
 =?us-ascii?Q?wvbbCMlziCgjCzIowaFQrqAwLxoApymGxQaP197t6m9SnJ9sSAgH6CTj8qqD?=
 =?us-ascii?Q?qAyLtTZWG8VeLG69Kr+9dvfWZx/8JOPxC5aGXn+NQAdk/QJ/vFIpM0pQcGI1?=
 =?us-ascii?Q?lI8IBNe4UKhWa3uzUwYLPdoZi9w/ZDEDu57IJL2cPrrIORAiKXAL3ISitec9?=
 =?us-ascii?Q?Zg28E30hpNyaKbAKoG18/I2aIcRMeyvi9iL3WXY59csJClPapjVMuHBwmny2?=
 =?us-ascii?Q?r8mx2EbnuBpz3M/8sCw8NghfpFTAV1BVDgkwmZQb4uHvIvSbAJkCyYLkPuyO?=
 =?us-ascii?Q?kgJAUygA1zBJQzeIa4+9V6TzTGTFzSyNWE33j6xKF0L96bO+wgwGlYmAaYu3?=
 =?us-ascii?Q?d2YwLbxwZXRwRNoRLZEEAg52BVD/yGvhILwsMQfgem25J8fUeu7msO3SOlO4?=
 =?us-ascii?Q?9IrjDvSgORemPPBKcdn8B6dH0aDu1g3vh2C4We9CRB4FZ6vdZfel4h2Vig7d?=
 =?us-ascii?Q?0xDsS0IHGDr+ItES+eP5KZeDo8WHrH6WUrtek9i1nRWR7tjgr1gLakXotVsk?=
 =?us-ascii?Q?Q9wIDooAw85/l66SlCVgPmUzydv03luyToDErDjf?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3afa1f57-006f-4476-babf-08dc4fbb743a
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4486.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 06:42:51.0069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mDXRMn2f7Kvh4HGPA9YAymmX4p1C2LHckevlHvZCsDIofJ9hdei+duFR87fOC4P+ojFCbDDGux/wXMT9FtYT1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS8PR06MB7466

Consider of a f2fs system with 2 devices:
Info: Device[0] : /dev/block/dm-46 blkaddr = 0--3fffff
Info: Device[1] : /dev/block/dm-47 blkaddr = 400000--67fffff

f2fs_map_blocks will return logical addr of fs when doing buffered io:
f2fs_map_blocks: dev = (254,46), ino = 40020, file offset = 462865, start blkaddr = 0x400000

While dio mapping will return the addr of device:
f2fs_map_blocks: dev = (254,47), ino = 40020, file offset = 462865, start blkaddr = 0x0

So the addr=0 is valid when the map.m_bdev is not s_bdev.

Fixes: 8d3c1fa3fa5e ("f2fs: don't rely on F2FS_MAP_* in f2fs_iomap_begin")
Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 fs/f2fs/data.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index d9494b5fc7c1..dca3628932c7 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -4185,7 +4185,8 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
 	if (WARN_ON_ONCE(map.m_pblk == COMPRESS_ADDR))
 		return -EINVAL;
 
-	if (map.m_pblk != NULL_ADDR) {
+	if (map.m_pblk != NULL_ADDR ||
+		(map.m_multidev_dio && map.m_bdev != inode->i_sb->s_bdev)) {
 		iomap->length = blks_to_bytes(inode, map.m_len);
 		iomap->type = IOMAP_MAPPED;
 		iomap->flags |= IOMAP_F_MERGED;
-- 
2.25.1