Received-SPF: pass (google.com: domain of linux-kernel+bounces-124213-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240326202859.960577-1-weilin.wang@intel.com>
 <20240326202859.960577-2-weilin.wang@intel.com> <CAM9d7cjm6uOhffsiuVKk=2GBEUBZUyhNe-5QM5--tw3-X+UBJw@mail.gmail.com>
 <CO6PR11MB5635E6DE9643226FF76D08B3EE3A2@CO6PR11MB5635.namprd11.prod.outlook.com>
In-Reply-To: <CO6PR11MB5635E6DE9643226FF76D08B3EE3A2@CO6PR11MB5635.namprd11.prod.outlook.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 28 Mar 2024 23:55:37 -0700
Message-ID: <CAM9d7chTRNS_fR-Qzo8egW4rBG9XFzZyKFWb-_LHygBypP6u9A@mail.gmail.com>
Subject: Re: [RFC PATCH v5 1/6] perf stat: Parse and find tpebs events when
 parsing metrics to prepare for perf record sampling
To: "Wang, Weilin" <weilin.wang@intel.com>
Cc: Ian Rogers <irogers@google.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	"Hunter, Adrian" <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	"linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Taylor, Perry" <perry.taylor@intel.com>, 
	"Alt, Samantha" <samantha.alt@intel.com>, "Biggers, Caleb" <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 28, 2024 at 11:43=E2=80=AFPM Wang, Weilin <weilin.wang@intel.co=
m> wrote:
>
>
>
> > -----Original Message-----
> > From: Namhyung Kim <namhyung@kernel.org>
> > Sent: Thursday, March 28, 2024 10:46 PM
> > To: Wang, Weilin <weilin.wang@intel.com>
> > Cc: Ian Rogers <irogers@google.com>; Arnaldo Carvalho de Melo
> > <acme@kernel.org>; Peter Zijlstra <peterz@infradead.org>; Ingo Molnar
> > <mingo@redhat.com>; Alexander Shishkin
> > <alexander.shishkin@linux.intel.com>; Jiri Olsa <jolsa@kernel.org>; Hun=
ter,
> > Adrian <adrian.hunter@intel.com>; Kan Liang <kan.liang@linux.intel.com>=
;
> > linux-perf-users@vger.kernel.org; linux-kernel@vger.kernel.org; Taylor,=
 Perry
> > <perry.taylor@intel.com>; Alt, Samantha <samantha.alt@intel.com>; Bigge=
rs,
> > Caleb <caleb.biggers@intel.com>
> > Subject: Re: [RFC PATCH v5 1/6] perf stat: Parse and find tpebs events =
when
> > parsing metrics to prepare for perf record sampling
> >
> > On Tue, Mar 26, 2024 at 1:29=E2=80=AFPM <weilin.wang@intel.com> wrote:
> > >
> > > From: Weilin Wang <weilin.wang@intel.com>
> > >
> > > Metrics that use tpebs values would use the :retire_latency keyword i=
n
> > > formulas. We put all these events into a list and pass the list to pe=
rf
> > > record to collect their retire latency value.
> > >
> > > Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> > > Reviewed-by: Ian Rogers <irogers@google.com>
> > > ---
> > [SNIP]
> > > @@ -681,8 +685,56 @@ static int metricgroup__build_event_string(struc=
t
> > strbuf *events,
> > >         hashmap__for_each_entry(ctx->ids, cur, bkt) {
> > >                 const char *sep, *rsep, *id =3D cur->pkey;
> > >                 enum perf_tool_event ev;
> > > +               /*
> > > +                * Parse and search for event name with retire_latenc=
y modifier.
> > > +                * If found, put event name into the tpebs_events lis=
t. This list
> > > +                * of events will be passed to perf record for sampli=
ng to get
> > > +                * their reitre_latency value.
> > > +                * Search for ":R" in event name without "@". Search =
for the
> > > +                * last "@R" in event name with "@".
> >
> > What is the retire_latency modifier exactly?
> > Why do you search for :R and @R?  What's the difference?
> > Why don't you search for "retire_latency"?
>
> We decided to use R as the modifier for retire_latency in one of the prev=
ious
> version of code review. Therefore, the code searches for R instead of "re=
tire_latency".
>
> It should search for :R in usual cases. But in hybrid platform, event nam=
e might be in
> format like cpu_core@event_name@R.

Ok, thanks for the explanation.  Please update the commit message and
the comment with this info.

Thanks,
Namhyung