Received-SPF: pass (google.com: domain of linux-kernel+bounces-124250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Fri, 29 Mar 2024 08:36:09 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Shuah Khan <shuah@kernel.org>,
	"Chang S. Bae" <chang.seok.bae@intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	angquan yu <angquan21@gmail.com>, kernel@collabora.com,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] selftests: x86: skip the tests if prerequisites
 aren't fulfilled
Message-ID: <ZgZvaUbZIr0qpxK5@gmail.com>
References: <20240327111720.3509180-1-usama.anjum@collabora.com>
 <1d6418a3-67eb-4a39-891a-7d653a26f1fc@linuxfoundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1d6418a3-67eb-4a39-891a-7d653a26f1fc@linuxfoundation.org>


* Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 3/27/24 05:17, Muhammad Usama Anjum wrote:
> > Skip instead of failing when prerequisite conditions aren't fulfilled,
> > such as invalid xstate values etc. This patch would make the tests show
> > as skip when run by:
> >    make -C tools/testing/selftests/ TARGETS=x86 run_tests
> > 
> >    ...
> >    # timeout set to 45
> >    # selftests: x86: amx_64
> >    # # xstate cpuid: invalid tile data size/offset: 0/0
> >    ok 42 selftests: x86: amx_64 # SKIP
> >    # timeout set to 45
> >    # selftests: x86: lam_64
> >    # # Unsupported LAM feature!
> >    ok 43 selftests: x86: lam_64 # SKIP
> >    ...
> > 
> > In amx test, Move away from check_cpuid_xsave() and start using
> > arch_prctl() to find out if amx support is present or not. In the
> > kernels where amx isn't present, arch_prctl returns -EINVAL. Hence it is
> > backward compatible.
> > 
> > Reviewed-by: Chang S. Bae <chang.seok.bae@intel.com>
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> > ---
> > Changes since v2:
> > - Update the changelog
> > 
> 
> Thank you - applied to linux-kselftest next for 6.10-rc1

Please don't, I've applied the patch to tip:x86/cpu with a tidied up 
changelog.

Thanks,

	Ingo