Received-SPF: pass (google.com: domain of linux-kernel+bounces-124360-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5c9523db-0cbd-44b7-ab49-4ef0ee48dd80@yahoo.com>
Date: Fri, 29 Mar 2024 10:42:22 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] V2 arm64: dts: qcom: Add support for Samsung Galaxy Z
 Fold5
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
 Bjorn Andersson <andersson@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240329-v2-dts-add-support-for-samsung-galaxy-zfold5-v1-0-9a91e635cacc@yahoo.com>
 <20240329-v2-dts-add-support-for-samsung-galaxy-zfold5-v1-1-9a91e635cacc@yahoo.com>
 <1cdbd387-e937-4d5c-bedb-b4275fdf84cc@linaro.org>
Content-Language: en-US
From: Alexandru Serdeliuc <serdeliuk@yahoo.com>
In-Reply-To: <1cdbd387-e937-4d5c-bedb-b4275fdf84cc@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Thanks, i added some notes inline as I do not know how to proceed with 
some if the requirements.

Just to be noted, the sm8550-samsung-q5q.dts it is based on 
sm8550-mtp.dts so most of the stuff is from there


On 29/3/24 1:52, Konrad Dybcio wrote:
> On 29.03.2024 12:08 AM, Alexandru Marc Serdeliuc via B4 Relay wrote:
>> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com>
>>
>> Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone
>>
>> Currently working features:
>> - Framebuffer
>> - UFS
>> - i2c
>> - Buttons
>>
>> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com>
>> ---
The [PATCH] string is added automatically to the subject by b4, I don't 
know how to add/insert custom text in there, I am going to read the b4 
docs and see if i can spot how to do it.
> Your commit title now includes "V2". Move it inside the square braces the
> next time around, so it's like [PATCH v3 1/2]. With b4, this should be done
> automagically, though..
>
> [...]
>
>> +/ {
>> +	model = "Samsung Galaxy Z Fold5";
>> +	compatible = "samsung,q5q", "qcom,sm8550";
>> +	#address-cells = <0x02>;
>> +	#size-cells = <0x02>;

thanks, going to remove them

> These two can go
>
> [...]
>
>> +	reserved-memory {
>> +		/*
>> +		 * The bootloader will only keep display hardware enabled
>> +		 * if this memory region is named exactly 'splash_region'
>> +		 */
this is a reality, without it the framebuffer do not work, due to abl

https://git.codelinaro.org/clo/la/abl/tianocore/edk2/-/blob/LA.VENDOR.1.0.r2-09400-WAIPIO.QSSI14.0/QcomModulePkg/Library/BootLib/UpdateDeviceTree.c?ref_type=tags#L220

How to proceed?

> Ouch.
>
> [...]
>
>> +		vreg_l15b_1p8: ldo15 {
>> +			regulator-name = "vreg_l15b_1p8";
>> +			regulator-min-microvolt = <1800000>;
>> +			regulator-max-microvolt = <1800000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +			regulator-allow-set-load;
>> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
>> +						   RPMH_REGULATOR_MODE_HPM>;
>> +			regulator-always-on;

I have removed the nodes that uses this as the driver for "Texas 
Instruments i2c eUSB2" is not yet submitted by the porter, however, 
those are took from the existing sm8550-mtp.dts

How to proceed?

> Any particular reason as to why?
>
> [...]
>
>> +&remoteproc_adsp {
>> +	firmware-name = "qcom/sm8550/adsp.mbn",
>> +			"qcom/sm8550/adsp_dtb.mbn";
>> +	status = "okay";
>> +};
>> +
>> +&remoteproc_cdsp {
>> +	firmware-name = "qcom/sm8550/cdsp.mbn",
>> +			"qcom/sm8550/cdsp_dtb.mbn";
>> +	status = "okay";
>> +};
>> +
>> +&remoteproc_mpss {
>> +	firmware-name = "qcom/sm8550/modem.mbn",
>> +			"qcom/sm8550/modem_dtb.mbn";
>> +	status = "okay";

Those are took from the device's running Android /firmware and load 
without error, I used this kind of firmware loaded on other devices as 
well and seems to do the job, the lines are as well on existing 
sm8550-mtp.dts

How to proceed?

> Unless you stole one from the factory, these firmwares will not
> load on your phone..
>
>> +};
>> +
>> +&sleep_clk {
>> +	clock-frequency = <32000>;
>> +};
>> +
>> +&tlmm {
>> +	gpio-reserved-ranges = <36 4>, <50 2>;
I have no idea, i took the ranges from  the running Android FDT, without 
those ranges the kernel do not boot, i can dig more into these ranges if 
required
> Would you have an idea what these GPIOs are used for?
>
> Konrad