Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp965431lqh; Fri, 29 Mar 2024 02:49:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWbd1k5KXKkdMpoyrtGS6t844y0T0qEi97Xj2/tk6SPKgF6oiZGLc2Z62A823RsN5ESU4fUc9oGgq7JIGOzQZJl879Cv4QUr0gz2EmzEA== X-Google-Smtp-Source: AGHT+IF3kwZvA+dcCC+hNVXdURZbtIWzLIR0w8Jab+2Gb/+onYDbM5XniQ8bl7t+Lg9emzekkDLY X-Received: by 2002:a50:aa92:0:b0:568:bda1:9640 with SMTP id q18-20020a50aa92000000b00568bda19640mr1236296edc.13.1711705777724; Fri, 29 Mar 2024 02:49:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711705777; cv=pass; d=google.com; s=arc-20160816; b=I+QG4Lc8AvRM/bVoJ8Wb/rbiyU0iIB5ArhN5OfhWH9QcH69qgbu3hzE0F3EgUnEKgm T8XeJ68Ws3W/XGdCm43/IjYgewsnpnb3izGTF5SnMlEekGNtX8f0/D0AH6eRHpx/AdFp C+5KjyPeO31TIScQl7TBxjCAqFS/klIDV4NOtLoVexNx1HoKbXgJ+Ah/GxUBnLQmpZus x6yM4IZ3SZU0Puuyz5en8mYTjokt1PNcXvhANeZrAu6X4fmzxn8u9Ufj7O+2lQKPW7Tb jwNkkxr3/+b3OdWG6+qPvZYZ2iY+RPcvlm3eWklgp9AM/8gqkUHG5X6vccbjYzi21eff VAIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=jHuZMAvqETWpA2oAM/qjqgqoLGUBb7pOip+JvCK0Qno=; fh=YT9zlFwbznkRloiPK1ml4mLS7D8bRaQpW3D/sTvAW4M=; b=eW9DX1zviQOD0TdesoNuOKQukGINIYLU6tMuLHWAlgOkFiGcA8mpRHSG4UFGouiGj7 x9MgnDKU4gM7G3P1JJINSpYQZwBTPzutCsds9wVNGtW4+KdSMpPuMB2MhM0Ue+MbGnRg McppC3mEXpKvj8f1iuRXadS/4ayB1rjM3YHNZCZeqp7oPCAPJGwGINN/ZzI/cof3kNCZ eonO+LQEdEKydFREsDdU60r/reg7cRfTE9ACuUyv5C0QMQ7ZC1ndFqynrPYjWc5Jl2jS kPSCGw2vTO47WPLn4kBdKx9frUyCZGvYODgbIgy4kiruZffkdSLIjeI7Lja/0AjyifUB DAkw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LVSL5i1v; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-124366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-124366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 23-20020a508e17000000b0056529e7d47esi1659786edw.494.2024.03.29.02.49.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 02:49:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-124366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LVSL5i1v; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-124366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-124366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 71C281F22F45 for ; Fri, 29 Mar 2024 09:49:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25E7250A70; Fri, 29 Mar 2024 09:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVSL5i1v" Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92A654D9E4; Fri, 29 Mar 2024 09:49:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711705767; cv=none; b=tIP+gJPJkpCc/lN85nZp0c88DsiuKE/BzHk5UOrbMm0iaycyGReRYOYQt4gQjG4NAR5AQ2r/Kzb6oJGgmS+PAw6rMWhw3Sg927BHTCWn+6bxZFSRtPZSKO93U19VXc7I0p6FiGN8Or+FPyjgsexStmOve8rJtA+xZnr62lOoJC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711705767; c=relaxed/simple; bh=DvUbrtPIF4GBmAsevCPo7ZbTOF7jHWk2TFBBpRZ2HfM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=FgtaqaNs4s1VZLwAyCLRKs8FbNm6qNcaZssGXfuCsa4GmWuirSJe4PGBQKT8HNVCSCKe9zXMMYVUlSPz6pWA+AjOLekoEj4rDR2vfYe0aK0QqDLYCm6QIdfWH4rfZqXR8HmidoR3PdXndldr9hVeGEl4WhHLm38DM6IfmMfgv+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LVSL5i1v; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-56b0af675deso2100704a12.1; Fri, 29 Mar 2024 02:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711705764; x=1712310564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jHuZMAvqETWpA2oAM/qjqgqoLGUBb7pOip+JvCK0Qno=; b=LVSL5i1vP5Z0UcGpPjjwyjSxptleJyEOTwBla+95OxY4kkyKmtMq5dVl6hr7i+JG+m p1vRw/JR2fIophcDmfStMwep4MTUUHlRfcdV5k4wCvrkPVFYX8oxqTN7AJlYNczqyQ5R fLwqiHWOjJ3nVWmRR1gFtv79nGXnHLglvC2ynpuPdLlt3mvU5PieecLnWnP+WcjPc9lc GdHGyj68GqWIVR1p1idv5klY+AFTQE7IW2qv5vmEK3sZ9krAtGBtoM4YoNLFv4GEuZ2e 7AcCxSOIp2T5a0mC8Ij46GkntZKoSi4/XsWMvyp30Bhzt8+kH6TdW0DhYSCgikccY7Bg 9dZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711705764; x=1712310564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jHuZMAvqETWpA2oAM/qjqgqoLGUBb7pOip+JvCK0Qno=; b=jU7dFtbych6vZTGhwn78J9tAmibdDCFEQD72ru2m0mPfQK6KLKk4xgzOHkPHyBuu4x 158dUiSHWnx7JUKUIW3quVNC6/Yv/NxX/dvUJo5HyyAZyOgqJzTZiAyMdJz9kqB+XXW4 OCTcTf3Tzi9nVXh8bbhCXw1k003XGb95E3KUbdKjc69BL6AyxQArHZVp5Dpytrhvl+ia V7iy5BiEcEBmrEtWxLMoDtsGuLRJj/cCiC91ZSwpQlOyh3pcg8CkRHQ6IizIXT1p28ue f9zKYIgYTNAnA8iJ2JHeylIA2L4Au+NRpsP8zPFmXkZdpvuFy/XRZRjamUXkMX8biBt/ jN+w== X-Forwarded-Encrypted: i=1; AJvYcCX8zP6IdrekPR6XbTRVSDkl2uk+2qAkY5IymBDR5MzFX/EoWQgCew8JhN5EyQRxMC6C9W2LnYrhhxw8sqFksiSJLP6jaJan2m/OwHAJJHuzCHx5NSkgPefLmx8RbflcTS3v+1/0prPLHH0/WEHjaVTFvcU9bWXdYXJd X-Gm-Message-State: AOJu0YzwXOpHDngbMtDdphJI7bYJ9F3xM7+svrSMcwPtSngu00uJd1q4 4D7gV0QkmMnHW5rvsvqbT/7JUrg8QzuGq3d/IHczvOyEAC+Wf8VuOL3ZQSaPnlY= X-Received: by 2002:a05:6402:35ca:b0:56b:b5a1:4685 with SMTP id z10-20020a05640235ca00b0056bb5a14685mr1393321edc.27.1711705763631; Fri, 29 Mar 2024 02:49:23 -0700 (PDT) Received: from fedora.iskraemeco.si ([193.77.86.250]) by smtp.gmail.com with ESMTPSA id b4-20020a0564021f0400b0056c1cca33bfsm1829733edb.6.2024.03.29.02.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 02:49:23 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Alexei Starovoitov , Daniel Borkmann , =?UTF-8?q?Joan=20Bruguera=20Mic=C3=B3?= Subject: [PATCH RESEND bpf 0/2] x86/bpf: Fixes for the BPF JIT with retbleed=stuff Date: Fri, 29 Mar 2024 10:46:16 +0100 Message-ID: <20240329094906.18147-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Joan Bruguera Micó Fixes two issues that cause kernels panic when using the BPF JIT with the call depth tracking / stuffing mitigation for Skylake processors (`retbleed=stuff`). Both issues can be triggered by running simple BPF programs (e.g. running the test suite should trigger both). The first (resubmit) fixes a trivial issue related to calculating the destination IP for call instructions with call depth tracking. The second is related to using the correct IP for relocations, related to the recently introduced %rip-relative addressing for PER_CPU_VAR. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Joan Bruguera Micó Joan Bruguera Micó (2): x86/bpf: Fix IP after emitting call depth accounting x86/bpf: Fix IP for relocating call depth accounting arch/x86/include/asm/alternative.h | 4 ++-- arch/x86/kernel/callthunks.c | 4 ++-- arch/x86/net/bpf_jit_comp.c | 22 ++++++++++------------ 3 files changed, 14 insertions(+), 16 deletions(-) -- 2.44.0