Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763444AbYARS3j (ORCPT ); Fri, 18 Jan 2008 13:29:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760992AbYARS3c (ORCPT ); Fri, 18 Jan 2008 13:29:32 -0500 Received: from mx1.redhat.com ([66.187.233.31]:40675 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758104AbYARS3b (ORCPT ); Fri, 18 Jan 2008 13:29:31 -0500 Date: Fri, 18 Jan 2008 13:28:50 -0500 From: Rik van Riel To: Miklos Szeredi Cc: torvalds@linux-foundation.org, peterz@infradead.org, miklos@szeredi.hu, salikhmetov@gmail.com, linux-mm@kvack.org, jakob@unthought.net, linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu, ksm@42.dk, staubach@redhat.com, jesper.juhl@gmail.com, akpm@linux-foundation.org, protasnb@gmail.com, r.e.wolff@bitwizard.nl, hidave.darkstar@gmail.com, hch@infradead.org Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files Message-ID: <20080118132850.044537e5@bree.surriel.com> In-Reply-To: References: <12006091182260-git-send-email-salikhmetov@gmail.com> <12006091211208-git-send-email-salikhmetov@gmail.com> <1200651337.5920.9.camel@twins> <1200651958.5920.12.camel@twins> Organization: Red Hat, Inc. X-Mailer: Claws Mail 3.0.2 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 27 On Fri, 18 Jan 2008 19:11:47 +0100 Miklos Szeredi wrote: > > And even in that four-liner, I suspect that the *last* two lines are > > actually incorrect: there's no point in updating the file time when the > > page *becomes* dirty, > > Actually all four lines do that. The first two for a write access on > a present, read-only pte, the other two for a write on a non-present > pte. > > > we should update the file time when it is marked > > clean, and "msync(MS_SYNC)" should update it as part of *that*. > > That would need a new page flag (PG_mmap_dirty?). Do we have one > available? I thought the page writing stuff looked at (and cleared) the pte dirty bit, too? -- All rights reversed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/