Received-SPF: pass (google.com: domain of linux-kernel+bounces-124463-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Valentin Obst <kernel@valentinobst.de>
To: wedsonaf@gmail.com
Cc: a.hindborg@samsung.com,
	alex.gaynor@gmail.com,
	aliceryhl@google.com,
	benno.lossin@proton.me,
	bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com,
	gary@garyguo.net,
	linux-kernel@vger.kernel.org,
	ojeda@kernel.org,
	rust-for-linux@vger.kernel.org,
	walmeida@microsoft.com
Subject: Re: [PATCH v2 0/5] In-place module initialisation
Date: Fri, 29 Mar 2024 13:10:33 +0100
Message-ID: <20240329121033.401403-1-kernel@valentinobst.de>
In-Reply-To: <20240328195457.225001-1-wedsonaf@gmail.com>
References: <20240328195457.225001-1-wedsonaf@gmail.com>
Precedence: bulk
MIME-Version: 1.0
UI-OutboundReport: notjunk:1;M01:P0:GZ3mcmPnGl8=;i9TJrGnPDlTWlikV5zRua8uI+pV
 9ACvqXgr3w60PfiM9UGAb19wY9f+AN5RwyZpMsIToISicwUbxSRfnxniXjg0nlBMpOmZn5jva
 pO8R8c3/9XBR/LyCOVLR2fnO2BmozrFSEqk11xUbJoORrs9fvtJo4GHjUPjQqHZA9ocFEUpFS
 8mBF3rITI4Az8uN0vlg4ce23Dya2oCM1YTAeeu27t4FyE72RUS8oajprOfMBMgpjOZWbDbuIw
 K+1IU3hoDjHySccJgNojNd6MfFnpgwsQkRXmALqCGl9yFr/K2qp/8M9Q5+VOPni/3AaylCSPm
 DT3bRODzzZ+H3pc8I9pzrDLHnS4Bz9mrXV6tVmrdUPzC+4celkjJt/2w78Xqp8hGWYlXIsHU0
 697jYYQ39pNb4nzTEJDQxErNt/JhqFe1hvEEJ47sFyyVzUnSRvy17Y83/2AyVrwD/67CPYZi8
 fgqP0AIQiYPx/boHzozwn/hn4r2AXFEIxPEAWjsyGOvycLr5JOiabDF7mHgyAbLvx360DyQab
 bNEr0yxs+Aw5s1u0DY1jauWW2jIIQHIxAoI554wxL1PRWdLhVJ82JpeD3ojikp1SizAD3PfK0
 ak2e1decZeE1CiOibh3wCKvmDQ7PJnCeqc+4haTEY/0Yumi8g09gNs0H2x5t2/k9xvgaJCMO3
 3pHaXz9XIionF7cAUxtYZmfRIOQk8dLhOFC/T4UThcLw2emhP6w93Q1gCN0KOhUSuJaYUvYSF
 wu3kFxMwiDiKEZloOHTzYnhiPI+IyCaevvpVlV45ymcYOS9s8EyxzA=

> Introduce `InPlaceModule`, which allows modules to be initialised
> inplace, as opposed to the current state where modules must return an
> instance which is moved to its final memory location.
>
> This allows us to have modules whose state hold objects that must be
> initialised inplace like locks. It also allows us to implement
> registrations (e.g., driver registration) inplace and have them similar
> to their C counterparts where no new allocations are needed.
>
> This is built on top of the allocation APIs because the sample module is
> a modified version of rust_minimal, which would be incompatible with the
> allocation API series because it uses vectors.
>
> ---
>
> Changes in v2:
>
> - Rebased to latest rust-next
> - Split off adding `Send` requirement to `Module` into a separate patch

I think the idea in [1] was to have this patch being included in the
stable trees. I got little experience with stable trees but wouldn't the
easiest way be that you add:

	Cc: stable@vger.kernel.org # 6.8.x: 715dd8950d4e rust: phy: implement `Send` for `Registration`
	Cc: stable@vger.kernel.org
	Fixes: 247b365dc8dc ("rust: add `kernel` crate")

in the sign-off section for this patch? (Or mark the first one for stable
inclusion as well, [2] has more information on that).

	- Best Valentin

[1]: https://lore.kernel.org/rust-for-linux/20240327032337.188938-1-wedsonaf@gmail.com/T/#m4b4daf27038f920a0c6fafff453efb3c8da72067
[2]: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

> - Prefixed all `core` and `kernel` references with `::` in
>   `module!` macro-generated code.
> - Calling `__pinned_init` with explicit full path.
> - Add `Mutex` to `rust_inplace`  sample.
> - Added `Send` implementation for `Registration` in net/phy.
> - Link to v1: https://lore.kernel.org/rust-for-linux/20240327032337.188938-1-wedsonaf@gmail.com/T/#t
>
> ---
> Wedson Almeida Filho (5):
>   rust: phy: implement `Send` for `Registration`
>   rust: kernel: require `Send` for `Module` implementations
>   rust: module: prefix all module paths with `::`
>   rust: introduce `InPlaceModule`
>   samples: rust: add in-place initialisation sample
>
>  rust/kernel/lib.rs           | 25 +++++++++++++++++++-
>  rust/kernel/net/phy.rs       |  4 ++++
>  rust/macros/module.rs        | 36 ++++++++++++-----------------
>  samples/rust/Kconfig         | 11 +++++++++
>  samples/rust/Makefile        |  1 +
>  samples/rust/rust_inplace.rs | 44 ++++++++++++++++++++++++++++++++++++
>  6 files changed, 99 insertions(+), 22 deletions(-)
>  create mode 100644 samples/rust/rust_inplace.rs
>
>
> base-commit: 453275c66aa4d87c73c5152140b3573ab2435bb7
> --
> 2.34.1