Received-SPF: pass (google.com: domain of linux-kernel+bounces-124196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f52734ac-704a-49f7-bbee-de5909d53b14@linux.intel.com>
Date: Fri, 29 Mar 2024 14:22:12 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 038/130] KVM: TDX: create/destroy VM structure
To: Isaku Yamahata <isaku.yamahata@intel.com>, Chao Gao <chao.gao@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
 isaku.yamahata@gmail.com, Paolo Bonzini <pbonzini@redhat.com>,
 erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
 Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
 chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
 Sean Christopherson <sean.j.christopherson@intel.com>,
 isaku.yamahata@linux.intel.com
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <7a508f88e8c8b5199da85b7a9959882ddf390796.1708933498.git.isaku.yamahata@intel.com>
 <ZfpwIespKy8qxWWE@chao-email>
 <20240321141709.GK1994522@ls.amr.corp.intel.com>
From: Binbin Wu <binbin.wu@linux.intel.com>
In-Reply-To: <20240321141709.GK1994522@ls.amr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/21/2024 10:17 PM, Isaku Yamahata wrote:
> On Wed, Mar 20, 2024 at 01:12:01PM +0800,
> Chao Gao <chao.gao@intel.com> wrote:
>
>>> config KVM_SW_PROTECTED_VM
>>> 	bool "Enable support for KVM software-protected VMs"
>>> -	depends on EXPERT

This change is not needed, right?
Since you intended to use KVM_GENERIC_PRIVATE_MEM, not KVM_SW_PROTECTED_VM.

>>> 	depends on KVM && X86_64
>>> 	select KVM_GENERIC_PRIVATE_MEM
>>> 	help
>>> @@ -89,6 +88,8 @@ config KVM_SW_PROTECTED_VM
>>> config KVM_INTEL
>>> 	tristate "KVM for Intel (and compatible) processors support"
>>> 	depends on KVM && IA32_FEAT_CTL
>>> +	select KVM_SW_PROTECTED_VM if INTEL_TDX_HOST
>> why does INTEL_TDX_HOST select KVM_SW_PROTECTED_VM?
> I wanted KVM_GENERIC_PRIVATE_MEM.  Ah, we should do
>
>          select KKVM_GENERIC_PRIVATE_MEM if INTEL_TDX_HOST
>
>
>>> +	select KVM_GENERIC_MEMORY_ATTRIBUTES if INTEL_TDX_HOST
>>> 	help
>>> 	.vcpu_precreate = vmx_vcpu_precreate,
>>> 	.vcpu_create = vmx_vcpu_create,
>>
[...]