Date: Fri, 18 Jan 2008 10:56:41 -0800 (PST)
From: Christoph Lameter <clameter@sgi.com>
To: Andi Kleen <ak@suse.de>
cc: travis@sgi.com, Andrew Morton <akpm@linux-foundation.org>, mingo@elte.hu,
       linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses
In-Reply-To: <200801181933.05662.ak@suse.de>
Message-ID: <Pine.LNX.4.64.0801181055320.30775@schroedinger.engr.sgi.com>
References: <20080118183011.354965000@sgi.com> <20080118183012.050317000@sgi.com>
 <200801181933.05662.ak@suse.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 934
Lines: 21

On Fri, 18 Jan 2008, Andi Kleen wrote:

> On Friday 18 January 2008 19:30:16 travis@sgi.com wrote:
> > Provide a means to trap usages of per_cpu map variables before
> > they are setup.  Define CONFIG_DEBUG_PER_CPU_MAPS to activate.
> 
> Are you sure that debug option is generally useful enough
> to merge? It seems very specific to your patchkit, but I'm not
> sure it would be worth carrying forever in the kernel.
> 
> Better would be probably to just unmap those areas anyways.

Its generally useful also for the cpu_alloc changes that may lead 
to the moving around of early initialization code for consolidation of 
code between i386 and x86_64 once Mike's initial patchset is in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/