Received-SPF: pass (google.com: domain of linux-kernel+bounces-125063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 29 Mar 2024 14:24:54 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Karel Balej <balejk@matfyz.cz>
Cc: regressions@lists.linux.dev, linux-kernel@vger.kernel.org, 
	linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: Fix setting period with #pwm-cells = <1> and
 of_pwm_single_xlate()
Message-ID: <v5jwouykt37up3bcjiigjgipzfdwgo5cguskunxjmyags43gql@dmrcrynj4zvj>
References: <D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz>
 <20240329103544.545290-2-u.kleine-koenig@pengutronix.de>
 <D06708BSGQ0J.1L4YOKOADM7T6@matfyz.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wdi6njopmh7ee7fl"
Content-Disposition: inline
In-Reply-To: <D06708BSGQ0J.1L4YOKOADM7T6@matfyz.cz>


--wdi6njopmh7ee7fl
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Karel,

On Fri, Mar 29, 2024 at 12:21:15PM +0100, Karel Balej wrote:
> Uwe Kleine-K=F6nig, 2024-03-29T11:35:40+01:00:
> > For drivers making use of of_pwm_single_xlate() (i.e. those that don't
> > pass a hwpwm index) and also don't pass flags, setting period was
> > wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers.
> >
> > Reported-by: Karel Balej <balejk@matfyz.cz>
> > Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references=
 without period")
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/pwm/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> > index 54a62879fffa..ee3ef3f44bc5 100644
> > --- a/drivers/pwm/core.c
> > +++ b/drivers/pwm/core.c
> > @@ -512,7 +512,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const st=
ruct of_phandle_args *args)
> >  	if (IS_ERR(pwm))
> >  		return pwm;
> > =20
> > -	if (args->args_count > 1)
> > +	if (args->args_count > 0)
> >  		pwm->args.period =3D args->args[0];
> > =20
> >  	pwm->args.polarity =3D PWM_POLARITY_NORMAL;
> > --=20
> > 2.43.0
>=20
> Thank you, this fixes the issue for me.
>=20
> Tested-by: Karel Balej <balejk@matfyz.cz>

Great, thanks for your report and test.

> Just a nit: I am not sure if perhaps this being part of the report
> thread is sufficient, but generally there should probably also be a
> Closes: trailer for regzbot to automatically mark the report as resolved
> among other reasons.

I applied this patch and added

Link: https://lore.kernel.org/r/D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz

to the Signoff area which should be good enough to make the regzbot
recognize this as the matching fix.

Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wdi6njopmh7ee7fl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYGwSUACgkQj4D7WH0S
/k7rfAgAqO6NeqaoVOvG7Y09tLueKEqMEPyTFhtJfvi8sloEpgS3fFEh0OZY869r
lpX3gFuIE5o0UuK40CCHxIZ8Q2vLv48GiNO7/v8Vsf/EEgxMwxcZ72Ne2BRXvctI
DITqa6L7WuRfeJyRbl0fNE+1mxJd7j4ehEwzSERPzIGzV5S6lcN6Ku33rvoJbSED
JK2KLejk5F3VcToE/1Fht8By1Rr+p9jIZ2UFz7B2HF19OUG/5UPU9wTT1yr3d+uu
+J7pHPL+gcmBA62R8Yb0GacWQdeA8cebhpeYWnUgTb8Zig9ATGIB9q9ww8ckr80n
C3jCKZoCWRvz6/wetY7fjEYGD3dgFQ==
=r3am
-----END PGP SIGNATURE-----

--wdi6njopmh7ee7fl--