Received-SPF: pass (google.com: domain of linux-kernel+bounces-125098-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1e0e0f42-950a-6971-dc12-a7beed7efdc8@amd.com>
Date: Fri, 29 Mar 2024 09:52:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 5/5] x86/CPU/AMD: Track SNP host status with
 cc_platform_*()
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
 Ashish Kalra <ashish.kalra@amd.com>, Joerg Roedel <joro@8bytes.org>,
 Michael Roth <michael.roth@amd.com>
References: <20240327154317.29909-1-bp@alien8.de>
 <20240327154317.29909-6-bp@alien8.de>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240327154317.29909-6-bp@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QlhtdkdGL1VtSHgxVk5xRzAvUHJiT0tFVEtGUG90RTJGako4SHVtdy80Nk5G?=
 =?utf-8?B?RkdSQXU4WDZNaEI2V0Y0VWZqbXN2QUNiVHJPRmFFWjBWaHQ5ZGtBaE9Tazd1?=
 =?utf-8?B?QURJd3lQTXp4Y2lTbDJpYkttOG82Qk5PZUtPNFBUdTdzQkMrWkUwMXkxRWgw?=
 =?utf-8?B?Nm1uZ2dzUTNON3Qya3pHVkdRMTcyUnpYSlkvTTBKdnR3SzdWMndBK3ZMelNo?=
 =?utf-8?B?NUUzSjhWNEdlcmtwWXEreVA3VVpwQVhTZEFNbkxGRkkySTcrVS9zUmRDL3Vo?=
 =?utf-8?B?ME41WHZQQkdlSWVQbWgrR0ljUUJhQTBid1FlQlN5OXFsQXJ1Um1sKzR1bUIx?=
 =?utf-8?B?dEVRcWdMOEZueGdhQlNTZ05KeXczZWk0dHp2UW92R1I2N3ByLzloZ1lCUjRj?=
 =?utf-8?B?d0EvNGlQVmEzSnliMnZWWmVIUlVqL04yQnp6QlF4Q25uVC9jNkpWRjJIbzRR?=
 =?utf-8?B?L2hkY1FvZ1dEbEtPN0hXWFhEeVVYbCtjSXV6am9aYUdQQjBIZXpxb3pKMXE1?=
 =?utf-8?B?N2g5RC8wYTJmd1RTTTNtMTVPTk55REdobVkwYVI2NlJWWkY4RkhpTHIrdzY2?=
 =?utf-8?B?c3NCSkNBNXhtSnF6ODRndStwMzl1UGFGNW0wTnUwZWY0eSswT3RUeVdWenV4?=
 =?utf-8?B?OUJlWGhiOU10Sld5Y2g0allwRGM2cnFJZUxkdWYwcUkrME42aCtWcU50MTVm?=
 =?utf-8?B?T0tyQUpZOTJpMGw4WmlrVGhYSC9OMExQYWtJb1VIRUFNQ04vcGdVY2w0REZq?=
 =?utf-8?B?alF4ZDc2eW50SEVJVmJXOWR0am1rb0VnbkhiNTM3MFJ2azI0ZTFxTjFNYWd3?=
 =?utf-8?B?RGZCdXIxMFh3cUhqc3pqYzRBOTNXMEw4Nlp0K2xpeDJGZXRJeU5XcEgzSzRX?=
 =?utf-8?B?dDZiM28vVlJKSU1mRXNVbW9uZ1NKU05LK2ZCTGlBd2ZZNDBCYzAwdk1CTHNB?=
 =?utf-8?B?MzFocXZzMU9tS255UXBzK1VBR2hlR3BvbGsyTTl3R1ZlazRUcUtYRlB2K0FL?=
 =?utf-8?B?K2hSSjE1ZGlwMmJDT2g5Yk5KRnBxYWZtRHdmbTRNTVZSbCttUTBJSVF5bkVD?=
 =?utf-8?B?blluSzU4SU1NQ1JYblBsQWFiSytYNGltRFdxU1E5dk9DbDh1ZEJNeEx0cVRK?=
 =?utf-8?B?QXB0TDlEUWozMHlHYWVOQ2dkY2p1SEhBMlViMlI2K2hTaitBZVdzZ0UxOTU1?=
 =?utf-8?B?Uk9Zdm9nTXcvZnhrM1NKT1c3bm5zdTNoTHRvazQ5ZHNhTTdWYkJOaE9ud3ZC?=
 =?utf-8?B?M24zandNRjJOYUsvUnczWml6ZXZsSSswKytKWEdEU3BoK2RsU1VpbG4vWUJQ?=
 =?utf-8?B?emtkUjRqZnFhSHRqMFY4UUlKelBJTk9Pb2kxZXpzVHRoZjh1c2VtbHJYRkN5?=
 =?utf-8?B?OG9WdFlnYk1TT1hNNTViNzFaZm5MTmxyd2gwcThZSjBlb3lTLzFVLzZsdEZj?=
 =?utf-8?B?R1FUNDhOSXlWYVg4cHBCVDlnMUlUMEx3M0djMld6cDhUZWNCNWZkTFFtVlgr?=
 =?utf-8?B?YUc5d2RuZWZJbHcvRWt5QmV1SWxZNEdERVArZHluQjhCS2h5cEp0YzVqekpH?=
 =?utf-8?B?ZVhnRkttVXpWNlVQOFZXUG96SUZoZllFQU1HTzhtaXYxbXIvU2Z0TVRYcEt1?=
 =?utf-8?B?TTdINzJPZndNTVlIZHF0bEc2TFRlS2E0em4rMmJhaElLNmJocmxYMzFHYTE2?=
 =?utf-8?B?cHFNT25iTHc1ZVFtMTZrMnFwK1JlNUE1Z0JRM2FrTzErNEo1cm5jUnVxalVD?=
 =?utf-8?B?NTdhTnVHZVV3OUF6WVZXWlR6ei9xbTByRTFMMTB4bFBuaytVZEFRR1oxNWZD?=
 =?utf-8?B?TjZ3NWQwbzFNM09Rcmx5alJHRmVVckN3ajVJUEVTeEJEeXFybWVpMFMwOGxp?=
 =?utf-8?B?eW42L1dhOVlQY3hjamdXc3Z6OUo0ZW1lU1Nzam4wZklJWVRVaVEyOFE0NjB6?=
 =?utf-8?B?TDFlOG1UNWYyS1JLSmxJZzl1eS82a0VhTzlVaG5EVFJzdG12K0dLYTBNUldj?=
 =?utf-8?B?enVHcGk4UERMU3pyNThyb1FDRXdqaThsWTdSRWVzeVFIRXdOYWlVbm1lOFMz?=
 =?utf-8?B?WlNHMklKMjRvT0FaczdSenIzeEtybm14Yk9BeGdFZUtsUG5aM2RGSFVTMHov?=
 =?utf-8?Q?jYGq2LTDkzEdsKgfidFw6+clN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6427c88e-db45-4af3-d3fa-08dc4fffcc93
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 14:52:04.8425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aN+W1v7R6tUiSqXbgCeOhWY9AWb2vpzSwpfkPsmmlRpbgMhspMWVOEB3xjAaHb9/2ZNXh3sVyexaUXXoq7ZCag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6794

On 3/27/24 10:43, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> The host SNP worthiness can determined later, after alternatives have
> been patched, in snp_rmptable_init() depending on cmdline options like
> iommu=pt which is incompatible with SNP, for example.
> 
> Which means that one cannot use X86_FEATURE_SEV_SNP and will need to
> have a special flag for that control.
> 
> Use that newly added CC_ATTR_HOST_SEV_SNP in the appropriate places.
> 
> Move kdump_sev_callback() to its rightfull place, while at it.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>

If late disabling of CPU feature flags is ever supported in the future, we 
should come back and possibly remove this. But until then...

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   arch/x86/include/asm/sev.h         |  4 ++--
>   arch/x86/kernel/cpu/amd.c          | 38 ++++++++++++++++++------------
>   arch/x86/kernel/cpu/mtrr/generic.c |  2 +-
>   arch/x86/kernel/sev.c              | 10 --------
>   arch/x86/kvm/svm/sev.c             |  2 +-
>   arch/x86/virt/svm/sev.c            | 26 +++++++++++++-------
>   drivers/crypto/ccp/sev-dev.c       |  2 +-
>   drivers/iommu/amd/init.c           |  4 +++-
>   8 files changed, 49 insertions(+), 39 deletions(-)
>