Received-SPF: pass (google.com: domain of linux-kernel+bounces-125137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 29 Mar 2024 15:37:35 +0000
From: Conor Dooley <conor@kernel.org>
To: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Bjorn Helgaas <bhelgaas@google.com>, Kyle Tso <kyletso@google.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	u.kleine-koenig@pengutronix.de,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
	quic_jackp@quicinc.com
Subject: Re: [RFC PATCH 1/2] dt-bindings: connector: Add gpio-usb-c-connector
 compatible
Message-ID: <20240329-worrisome-grasp-c70b2af9105b@spud>
References: <20240329071948.3101882-1-quic_kriskura@quicinc.com>
 <20240329071948.3101882-2-quic_kriskura@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="uFYv4NM+KoKHxWIC"
Content-Disposition: inline
In-Reply-To: <20240329071948.3101882-2-quic_kriskura@quicinc.com>


--uFYv4NM+KoKHxWIC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2024 at 12:49:47PM +0530, Krishna Kurapati wrote:
> QDU1000 IDP [1] has a Type-c connector and supports USB 3.0.
> However it relies on usb-conn-gpio driver to read the vbus and id
> gpio's and provide role switch. However the driver currently has
> only gpio-b-connector compatible present in ID table. Adding that
> in DT would mean that the device supports Type-B connector and not
> Type-c connector.
>=20
> Add gpio-usb-c-connector compatible to the driver to support such
> cases.

This is not a driver. Bindings commit messages should talk about the
hardware they're supporting, not about drivers.

>=20
> [1]: https://lore.kernel.org/all/20240319091020.15137-3-quic_kbajaj@quici=
nc.com/
>=20
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
>  Documentation/devicetree/bindings/connector/usb-connector.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.ya=
ml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index fb216ce68bb3..2af27793c639 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -30,6 +30,9 @@ properties:
>            - const: samsung,usb-connector-11pin
>            - const: usb-b-connector
> =20
> +      - items:
> +          - const: gpio-usb-c-connector

This is over complicated, just needs to be "- const: gpio-usb-c-connector"

Thanks,
Conor.

> +
>    reg:
>      maxItems: 1
> =20
> --=20
> 2.34.1
>=20

--uFYv4NM+KoKHxWIC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgbgPwAKCRB4tDGHoIJi
0hs5APwLYBIyg1CBbwmd1i3CIR/+JuoYmz6qiCnxRLnOPFrm8wEA9XPaqdnvAPH+
OPEf/VJ23+e4l/uaxevEitWieixpzQA=
=v0XQ
-----END PGP SIGNATURE-----

--uFYv4NM+KoKHxWIC--