Received-SPF: pass (google.com: domain of linux-kernel+bounces-125222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 29 Mar 2024 14:09:41 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	Changbin Du <changbin.du@huawei.com>
Subject: Re: [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler
Message-ID: <Zgb1uj_VQ1pjFdKE@x1>
References: <20240328232009.466018-1-namhyung@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240328232009.466018-1-namhyung@kernel.org>

On Thu, Mar 28, 2024 at 04:20:05PM -0700, Namhyung Kim wrote:
> Hello,
> 
> As we've added libcapstone support, it's natural to use it for perf annotate
> as well.  This change added the capstone support on x86 first.  Other archs
> can be added later (by someone who can verify it doesn't break things).
> 
> For now it tries to use capstone (if available) before objdump.  But it
> doesn't support source file and line number info.  So users should use the
> objdump (by passing --objdump=PATH option) if they need them.  For example,
> this command line will keep the existing behavior (i.e. using objdump).
> 
>   # not to use capstone for disassembly
>   $ perf annotate --objdump=objdump
> 
> The capstone uses LLVM objdump style output which is slightly different than
> the GNU objdump.  But it should not have differences besides that.  I've
> verified the result of data type profiling and it produced the same output
> but gave me ~3x speedups.

Excellent news, I'll try and test all this soon!

- Arnaldo