Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp123780lqz; Fri, 29 Mar 2024 10:30:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXPjw0UDuahHmdbOUHtQOog8eci67pOuugHoO9tgdponJ+1FgITc6gOFbakdQOv8FEUdJu0GTa5KN1RBYlZ4gm9KCQlOVOOrDHZLPGnSA== X-Google-Smtp-Source: AGHT+IG2gUwUnhQugkbIL7qs4o8AbV1HsKq77Uro97fcYcCBTkE0LjBjaKuYqnL0iqY0aUeS/VmY X-Received: by 2002:a17:903:22c2:b0:1de:ff81:f666 with SMTP id y2-20020a17090322c200b001deff81f666mr3484957plg.21.1711733413278; Fri, 29 Mar 2024 10:30:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711733413; cv=pass; d=google.com; s=arc-20160816; b=v+Y3MkiUI88n+Flr0edVeB9pQsmOJVCAPxkfi/19JqAy4hw52Zr7dGCkyWJ0Ouyxje r4tYOu7Th0/RDZh/ccjF4dmACsZLGaCg3zC/rpCPFUJioKrTCOpCwrfvxjU5OoVsVR9H k6ZWdUdA/HLmsZ11Ed0paw+5hkpAGwTeGZ2iMafR7Ls8UZ1ptaFAx/kBiUptRtd94QZW /QPJj3jj/7LN++Pll8mrsmI6Y0apMpMeUK9gM0FTvW0UP37oqq7t9L9Ymp8gBMC6KmdQ 14ACshTl65iVtmov/8KtweqwAMSk3nb1Jb1P0YtFN47+5EbuXJERtFp3M6dTPOOi7+NO S1WA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=t++1nC+qRXSN1ZZrXUG5rktHfRs6+r0BtHLmKU53npk=; fh=XQ7yrdKiQCK4W5MUR52SM6EFEYNEDyofu7YfqBh7Bhc=; b=gdWjdyIbxFEwC1ultvy/FE898F4vk6p/a0JLz6ZOeMY12YPZE1LtBCWOVA6GZwq7QH erUooMi+KF2B2dCknBtXXh842a3TZ5KU5cok2oFfx8btUG0wT/enHFHRnmPg74tC8zOe AyiUhw6fl4DTmJZ69c2enaIRLset2PbcwnluNEKfeSFiiki3fe8FClL7DBEuV00IgiAr vl/cmbKHzE2DyX+cFyEP2MVhpf+a0PPaL5veOnj47T4X+DUzaD3SdhNVdAsgDhfTZI2U S8wwp3td+H6f4jznGKe+g2nRdeSxq8KtWP3cUt5iS+/9HUhIUl8YEDC4LBC4WGfC0PHX uXZA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QVFN7BIf; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-125248-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125248-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s2-20020a170902ea0200b001e0db863822si4230800plg.499.2024.03.29.10.30.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:30:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-125248-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QVFN7BIf; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-125248-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125248-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D5A13288391 for ; Fri, 29 Mar 2024 17:29:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B83BC136665; Fri, 29 Mar 2024 17:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QVFN7BIf" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5503485925; Fri, 29 Mar 2024 17:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711733327; cv=none; b=Vi3GGI/nXlDXCV1D2qqUA1JlzeBAGQqiksdYUYoKqG4q/tA7HfC4cqSBj3k4lymTnT8v8vLnRZYOzo2CEE/FPYKV73Cv2oPjjrLN7krOqEc8PIX5g2zlao9UGcN8MFOkBnDmEg63rfnVr0siTl5YJhcbQhJJ8IWD604tJU+K8M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711733327; c=relaxed/simple; bh=yFDVjGYfjWII0t1wE88WD1st8TP3w0lvfG9W2m2CZOE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WcW6c3Ao1+e3iA+naMeh3HVBsY6BvHZZjyNNXJ4ELs6jvpC4hBsdkURsy2SqzU9MX4MGbtdS3zQ6IOC4AmMmB/Z27kR24t1fP+aQI35V7P6CijfGWe9aWDmGISiGrb7oVdBzahd0A2IRN7ipQbYRfX/yB74qvZLfkJSwKBdN0og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QVFN7BIf; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711733326; x=1743269326; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yFDVjGYfjWII0t1wE88WD1st8TP3w0lvfG9W2m2CZOE=; b=QVFN7BIfnn4x8y7CpO+mo+KH7FiVqfbhR6OvfgL/VD24ZsFFxuIJLG++ wcZX+p57CZig7RkmU/l1z7i1CInY+mFguaalyrPK5iKWO81E0W9gycLCb RM9XV8TOoyjdHTL+lRLHOaWd1uzJ8ADSP1SWjElfllugUJNzd2MDrlA4p Wu0fkcPYmAzQmW89dY7wU4Sy60hW4kbBR5hzCIF5yBmKwyJImjBTxn+0j 9bzVf6AEhhsNfgxGVgSfsQLIxYdz+yUQk5W8dwKnxea7xXc+M+hamd19H N65mTUuF/k+G+rL9msFsgsMoVNo665fmKsKmNAmgUPEgGq401/PBB/6iX g==; X-CSE-ConnectionGUID: 7cYnQ/HkRS2eXCJq+KMszw== X-CSE-MsgGUID: qu73ez8KSIi+Kg22f2Z7eA== X-IronPort-AV: E=McAfee;i="6600,9927,11028"; a="9882635" X-IronPort-AV: E=Sophos;i="6.07,165,1708416000"; d="scan'208";a="9882635" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 10:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,165,1708416000"; d="scan'208";a="40178285" Received: from sergeyko-mobl.amr.corp.intel.com (HELO [10.212.56.129]) ([10.212.56.129]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 10:28:45 -0700 Message-ID: Date: Fri, 29 Mar 2024 10:28:44 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT To: Samuel Holland , Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Borislav Petkov , Dave Hansen , Ingo Molnar , Thomas Gleixner References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-11-samuel.holland@sifive.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240329072441.591471-11-samuel.holland@sifive.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/29/24 00:18, Samuel Holland wrote: > +# > +# CFLAGS for compiling floating point code inside the kernel. > +# > +CC_FLAGS_FPU := -msse -msse2 > +ifdef CONFIG_CC_IS_GCC > +# Stack alignment mismatch, proceed with caution. > +# GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3 > +# (8B stack alignment). > +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383 > +# > +# The "-msse" in the first argument is there so that the > +# -mpreferred-stack-boundary=3 build error: > +# > +# -mpreferred-stack-boundary=3 is not between 4 and 12 > +# > +# can be triggered. Otherwise gcc doesn't complain. > +CC_FLAGS_FPU += -mhard-float > +CC_FLAGS_FPU += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-stack-boundary=4) > +endif I was expecting to see this (now duplicate) hunk come _out_ of lib/Makefile somewhere in the series. Did I miss that, or is there something keeping the duplicate there?