Received-SPF: pass (google.com: domain of linux-kernel+bounces-125371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240328232009.466018-1-namhyung@kernel.org> <CAP-5=fX296_EROp6D+zX4OOABOkwkHrE-2v7F0K=Jo5zSZ_-zw@mail.gmail.com>
In-Reply-To: <CAP-5=fX296_EROp6D+zX4OOABOkwkHrE-2v7F0K=Jo5zSZ_-zw@mail.gmail.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Fri, 29 Mar 2024 12:57:35 -0700
Message-ID: <CAM9d7cgyMFZLvacgV6SKazzy2Vg7Kk=qTtDyPef1W8fVFNy+cQ@mail.gmail.com>
Subject: Re: [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler
To: Ian Rogers <irogers@google.com>
Cc: Changbin Du <changbin.du@huawei.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, 
	Kan Liang <kan.liang@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
	linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ian,

On Fri, Mar 29, 2024 at 9:33=E2=80=AFAM Ian Rogers <irogers@google.com> wro=
te:
>
> On Thu, Mar 28, 2024 at 4:20=E2=80=AFPM Namhyung Kim <namhyung@kernel.org=
> wrote:
> >
> > Hello,
> >
> > As we've added libcapstone support, it's natural to use it for perf ann=
otate
> > as well.  This change added the capstone support on x86 first.  Other a=
rchs
> > can be added later (by someone who can verify it doesn't break things).
> >
> > For now it tries to use capstone (if available) before objdump.  But it
> > doesn't support source file and line number info.  So users should use =
the
> > objdump (by passing --objdump=3DPATH option) if they need them.  For ex=
ample,
> > this command line will keep the existing behavior (i.e. using objdump).
> >
> >   # not to use capstone for disassembly
> >   $ perf annotate --objdump=3Dobjdump
> >
> > The capstone uses LLVM objdump style output which is slightly different=
 than
> > the GNU objdump.  But it should not have differences besides that.  I'v=
e
> > verified the result of data type profiling and it produced the same out=
put
> > but gave me ~3x speedups.
> >
> > Thanks,
> > Namhyung
>
> I wanted to see what -fsanitize=3Daddress would think of libcaptstone
> and no issues,  so:
>
> Tested-by: Ian Rogers <irogers@google.com>

Thanks for checking it!

>
> Some thoughts:
>  - it may be worth adding to the commit message in "perf annotate:
> Split out util/disasm.c" that there's no functional change,
>  - we lack perf annotate testing,
>  - it seems capstone should be opt-out rather than opt-in as a library
> dependency (given the performance delta and the objdump interactions
> are at best messy),
>  - if libcapstone could solve our addr2line issues too this would be grea=
t :-).

I think addr2line should be handled using libdw.  I'll take a look.

Thanks,
Namhyung