Received-SPF: pass (google.com: domain of linux-kernel+bounces-125394-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240329174236.2278217-1-edliaw@google.com> <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com>
In-Reply-To: <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com>
From: Edward Liaw <edliaw@google.com>
Date: Fri, 29 Mar 2024 13:33:12 -0700
Message-ID: <CAG4es9UYvT5tRPFtsRUqJnz9obLuAz03b0+61aAagmGjGTMnsA@mail.gmail.com>
Subject: Re: [PATCH] selftests/mm: import strings.h for ffsl
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, 
	Shuah Khan <shuah@kernel.org>, Nathan Chancellor <nathan@kernel.org>, 
	Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling <morbo@google.com>, 
	Justin Stitt <justinstitt@google.com>, Peter Xu <peterx@redhat.com>, 
	David Hildenbrand <david@redhat.com>, "Mike Rapoport (IBM)" <rppt@kernel.org>, 
	Axel Rasmussen <axelrasmussen@google.com>, linux-kselftest@vger.kernel.org, 
	kernel-team@android.com, linux-mm@kvack.org, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2024 at 12:32=E2=80=AFPM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> On 3/29/24 10:42 PM, Edward Liaw wrote:
> > Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fi=
x
> > map_hugetlb failure on 64K page size systems") imported vm_util.h.
> >
> > Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
> Why do you think this Fixes tag is needed? This refers to a patch which i=
s
> just moving code. It doesn't seem to have any thing related to strings.h.
Oops, I guess it should be:

Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and
PAGE_SHIFT")