Received-SPF: pass (google.com: domain of linux-kernel+bounces-125447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 29 Mar 2024 16:29:32 -0500
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: Rob Herring <robh@kernel.org>
To: wefu@redhat.com
Cc: nuno.sa@analog.com, okan.sahin@analog.com, palmer@dabbelt.com, 
 conor@kernel.org, mike.looijmans@topic.nl, devicetree@vger.kernel.org, 
 jic23@kernel.org, marcelo.schmitt@analog.com, marius.cristea@microchip.com, 
 guoren@kernel.org, andriy.shevchenko@linux.intel.com, jszhang@kernel.org, 
 bigunclemax@gmail.com, lee@kernel.org, linux-kernel@vger.kernel.org, 
 linux-riscv@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, 
 linux-iio@vger.kernel.org, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, 
 marcus.folkesson@gmail.com, lars@metafoo.de, fr0st61te@gmail.com, 
 schnelle@linux.ibm.com
In-Reply-To: <20240329200241.4122000-4-wefu@redhat.com>
References: <20240329200241.4122000-1-wefu@redhat.com>
 <20240329200241.4122000-4-wefu@redhat.com>
Message-Id: <171174777168.1262622.1612528543919451612.robh@kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: adc: Document XuanTie TH1520 ADC


On Sat, 30 Mar 2024 04:01:26 +0800, wefu@redhat.com wrote:
> From: Wei Fu <wefu@redhat.com>
> 
> Document devicetree bindings for the XuanTie TH1520 AP sub-system ADC.
> 
> Signed-off-by: Wei Fu <wefu@redhat.com>
> ---
>  .../bindings/iio/adc/thead,th1520.yaml        | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/iio/adc/thead,th1520.example.dts'
Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: found a tab character where an indentation space is expected
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/iio/adc/thead,th1520.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: found a tab character where an indentation space is expected
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240329200241.4122000-4-wefu@redhat.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.