Received-SPF: pass (google.com: domain of linux-kernel+bounces-125464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: [PATCH v2 0/5] perf annotate: Use libcapstone as a disasssembler
Date: Fri, 29 Mar 2024 14:58:07 -0700
Message-ID: <20240329215812.537846-1-namhyung@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hello,

As we've added libcapstone support, it's natural to use it for perf annotate
as well.  This change added the capstone support on x86 first.  Other archs
can be added later (by someone who can verify it doesn't break things).

* v2 changes
 - Show global symbols in the comment  (Changbin)
 - Update the commit message for split  (Ian) 
 - Add Ian's Tested-by

For now it tries to use capstone (if available) before objdump.  But it
doesn't support source file and line number info.  So users should use the
objdump (by passing --objdump=PATH option) if they need them.  For example,
this command line will keep the existing behavior (i.e. using objdump).

  # not to use capstone for disassembly
  $ perf annotate --objdump=objdump

The capstone uses LLVM objdump style output which is slightly different than
the GNU objdump.  But it should not have differences besides that.  I've
verified the result of data type profiling and it produced the same output
but gave me ~3x speedups.

Thanks,
Namhyung


Namhyung Kim (5):
  perf annotate: Use ins__is_xxx() if possible
  perf annotate: Add and use ins__is_nop()
  perf annotate: Split out util/disasm.c
  perf annotate: Use libcapstone to disassemble
  perf annotate: Add symbol name when using capstone

 tools/perf/util/Build      |    1 +
 tools/perf/util/annotate.c | 1711 ++--------------------------------
 tools/perf/util/annotate.h |   59 +-
 tools/perf/util/disasm.c   | 1814 ++++++++++++++++++++++++++++++++++++
 tools/perf/util/disasm.h   |  112 +++
 5 files changed, 1989 insertions(+), 1708 deletions(-)
 create mode 100644 tools/perf/util/disasm.c
 create mode 100644 tools/perf/util/disasm.h

-- 
2.44.0.478.gd926399ef9-goog