Received-SPF: pass (google.com: domain of linux-kernel+bounces-125470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 29 Mar 2024 14:59:04 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Chintan Vankar <c-vankar@ti.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>, Siddharth Vadapalli
 <s-vadapalli@ti.com>, Grygorii Strashko <grygorii.strashko@ti.com>, "Heiner
 Kallweit" <hkallweit1@gmail.com>, Vladimir Oltean
 <vladimir.oltean@nxp.com>, Andrew Lunn <andrew@lunn.ch>, Roger Quadros
 <rogerq@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Paolo
 Abeni <pabeni@redhat.com>, Eric Dumazet <edumazet@google.com>, "David S.
 Miller" <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
 <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: ethernet: ti: am65-cpsw: Enable RX
 HW timestamp only for PTP packets
Message-ID: <20240329145904.0b7cb60f@kernel.org>
In-Reply-To: <20240327054234.1906957-2-c-vankar@ti.com>
References: <20240327054234.1906957-1-c-vankar@ti.com>
	<20240327054234.1906957-2-c-vankar@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 27 Mar 2024 11:12:33 +0530 Chintan Vankar wrote:
> To prevent port lock up, disable TSTAMP_EN bit in CPTS_CONTROL
> register. The workaround for timestamping received packets is to
> utilize the CPTS Event FIFO that records timestamps corresponding to
> certain events, with one such event being the reception of an
> Ethernet packet with the EtherType field set to Precision Time
> Protocol (PTP).

You mention EtherType here but the drive retains L4 support,
which is somewhat confusing. Perhaps mention L4 / UDP ports
here, too.