Received-SPF: pass (google.com: domain of linux-kernel+bounces-125511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <4244b729-2eec-4999-9427-00b5c9f3e6fc@intel.com>
Date: Fri, 29 Mar 2024 16:06:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in limbo
 list
To: Haifeng Xu <haifeng.xu@shopee.com>, <james.morse@arm.com>
CC: <fenghua.yu@intel.com>, <babu.moger@amd.com>, <bp@alien8.de>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<hpa@zytor.com>, <peternewman@google.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <corbet@lwn.net>, <linux-doc@vger.kernel.org>
References: <20240319083039.223088-1-haifeng.xu@shopee.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240319083039.223088-1-haifeng.xu@shopee.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDUxTkU5WE5jZWkwSXExaTZUQXVaSFJuWCtpOFUvV0JmVlRUckJ6R2x0enQx?=
 =?utf-8?B?cEpBdERaM0xZVkpmcE5Ycld1VVZaNVVjLy8wZ0ZveUtCOE9RTWZzZi9kRWl6?=
 =?utf-8?B?MFhSTEdvOWVYdW9UYWtJYzBnU1NEQlBkOTRqdEEvMXNxeEJQTnp2TGN3WW94?=
 =?utf-8?B?SFJsTUF4cmM3VW1uVTNUZVNaNmJqYmozM1FsckR4M0tJc1IwdmtpR1I5SXhm?=
 =?utf-8?B?TW5mZmU3V2liYzVwMlZORkE0U1U2bG13QUVwWXl1dHoxaUl3Rm8xMGtybTJt?=
 =?utf-8?B?dEwrS2tYNmRNWEZEblF6ZHAwamtrR1hzMUl6UmgwbGEzZ2wyNmVzUVdKRnZQ?=
 =?utf-8?B?SGZENGF5NTZucEN0UXRoNDYyejNmejMwTjJ2b2FzcW9vbzZOSzluR1VOOERF?=
 =?utf-8?B?aS91WW53YUUwajBlSHVBT1BTTklHY3liZ01uRExBMlBJVDJibTZIRmt2WUdo?=
 =?utf-8?B?NlZaaUhkeUVZbDNXWVY0MDAyQVQwVysrTG50L0YyTEtvQzJBdVdaRkJyY3Ni?=
 =?utf-8?B?UHd0SXA3dmV3eklnRmJyUW83eU80bGxjUGdjWHI2Nm1CTk5vQ1JCKzhyNGVp?=
 =?utf-8?B?WkVvY2pySGpmdVNYRU1xZnhhT1FVdGZSdnpEeXpUaWtqMHJJRmF3UFBtV2hj?=
 =?utf-8?B?eEtzMi9lS3NadUxXYlI1NFdjNGRiVmp2ZnFDTHp0c25hb1RlajVXTktnZE1P?=
 =?utf-8?B?T1V1WitxaVFwWEo4TjZSbTJWUGhvSjZmUFB2ays2ZWZwSy9pZGM4cTFFS2M4?=
 =?utf-8?B?aUZWYU5OZC9vTGtpRlZGN3ZiaEhQWWxpUFY5S0poQmVUdDB2UWZTZkFmeW5i?=
 =?utf-8?B?R2pEcWZXdVlrY0tEbXdFSis4Zk9jV3dqRUNCL0xJdnFMWjBpc3UwMUpsVndU?=
 =?utf-8?B?MUx5ZlpwdHRpWkdSMng3TzE0K2xrMTEzZ0RjdDJrY01aT0U0cm9uNlR2NU5S?=
 =?utf-8?B?bzRFaHF2K0lVVkhGN0VHQWU0T2NKN2p4Q2x5VVFMZGtLNjVuSXVDTDNCMVIv?=
 =?utf-8?B?bStvcTZSc0ErUUgvQUVNZHhUdTBsZVhuSGVDQVFPcmt4dGpZUTBVS2ZCTnIy?=
 =?utf-8?B?eUlJaHppNnlhaWdLWjE4bytub2xLYnZVY2QvekdGZGVYY0tBT01tUVY1TFBN?=
 =?utf-8?B?dnpBVDlsZGdRd1UzNC81UzUrSHQxeWpYTEZUNXN0aDhYc3U3WkZlZ2lLSXk4?=
 =?utf-8?B?ZlZxMkFCOUV2dEJDOS9GU2xrYWdNY3dNOXZkSEFzWSt3Z1BsNStaaEpTUlA5?=
 =?utf-8?B?WDNPNVBpT1B4c2ppZWl3Y3NVRWg0SXpadG16MXpRdHRLOHdPeDVFQTBFemJv?=
 =?utf-8?B?VXQyUHRFN0huR3BaeG5PTFZINXlveFF4b3ZRckhPK2htU2JoY3I0V01VdGpp?=
 =?utf-8?B?WWVXMHM5Wk9YMTNNa1d4aC9TMXE5WDNPTDNjOVh0OXFwRVpEbkFXZzJxaTBK?=
 =?utf-8?B?UkpUNHBLTW44K0hhL2kwbjUyd1F6d2VsbWV0V0ZkUUdUMUtEMzlwa3NPSGtK?=
 =?utf-8?B?ckN3M1NISURoeFBtYUk1bHZ6SXAyTTVhSGpFNG1za0VVbTQ3TmtBYlRwOWQw?=
 =?utf-8?B?MXZxVE03U3VtdkxIbGJxSnNqaUZIUmV6cnRwbkhXdVlQKytNSkJZSWU2azJl?=
 =?utf-8?B?SUw4MWN1am1nUGRxdEV2blh3Y2I2MmE3WmgzbjBBN2cvMXBFR3hCdC9NL1VD?=
 =?utf-8?B?NkJsZmI2Ym1mVjR0MzJUeUUwVjQ0Uy9WdUkxTGJzMFFnRHZVd1R3MTd3M2ow?=
 =?utf-8?B?anFvYkE1aHE2a3dCRnJpdjdTQnFMb2YzRmRmZ0daTWsybkcrbFUxVDE2Ymp6?=
 =?utf-8?B?eUk4WTcrc28zMXdReWl1cVNEUlgrMk9MSmpWMDhxbXVVSitqYXByMnFwak5T?=
 =?utf-8?B?emdDckRLZy9RQU1DZlhjbFpoRzMzUm5KWlY4M0tVeVExbkJuTUJ4QzRQWjdU?=
 =?utf-8?B?M2dxTjVzQ1Q0OHV1NlEyQnZ1c2s3c1VjTDkyUWlGemxZOXFnbUJaMWF0U0xB?=
 =?utf-8?B?VE94SWIyK1JUY1hLZ2FLYjZ5dlFIQy9wbXJmcEoyNytJZjc4M0JhRmxmSUlx?=
 =?utf-8?B?L1VsOWp5UTBROUwybTg4TTN3ODU5YisyOXlMMWdMYXJLSFpuc2ZEZ2Vkc3dt?=
 =?utf-8?B?YUljc0xqbUlmUzV1a0FtelZVemN3c0xlZlpVWVNmSTBpMVBOWVdZU3Z6YXJT?=
 =?utf-8?B?NXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fbebdd7-fbea-4f64-ebe6-08dc5044d54d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 23:06:14.7389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3CCDWKH5ZAKF4wTu1bXpRkBaFwO3N7P4nYn+KRn4kwTU7hAiCoBkb26uNswWrzz005M9L/LkeYH0MhwttQoJC6QdkQu5cc4wgFcEXEZDSqU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7449
X-OriginatorOrg: intel.com

Hi Haifeng,

On 3/19/2024 1:30 AM, Haifeng Xu wrote:
> After removing a monitor group, its RMID may not be freed immediately
> unless its llc_occupancy is less than the re-allocation threshold. If
> turning up the threshold, the RMID can be reused. In order to know how
> much the threshold should be, it's necessary to acquire the llc_occupancy.
> 
> The patch series provides a new tracepoint to track the llc_occupancy.

There seems to be a problem with the DKIM attestation. Here is what I see
when I download this series:

    $ b4 am -Q 20240319083039.223088-1-haifeng.xu@shopee.com
    Grabbing thread from lore.kernel.org/all/20240319083039.223088-1-haifeng.xu@shopee.com/t.mbox.gz
    Analyzing 3 messages in the thread
    Looking for additional code-review trailers on lore.kernel.org
    Checking attestation on all messages, may take a moment...
    ---
      ✗ [PATCH v6 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h
      ✗ [PATCH v6 2/2] x86/resctrl: Add tracepoint for llc_occupancy tracking
    ---
      ✗ BADSIG: DKIM/shopee.com
    ---
    Total patches: 2
    ---

The patches look good to me. Thank you very much for adding this.
Please resubmit with the DKIM attestation fixed and then you can add:

| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette